From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id E36D73858405; Thu, 28 Oct 2021 23:23:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E36D73858405 Received: by mail-wr1-x431.google.com with SMTP id s13so5795601wrb.3; Thu, 28 Oct 2021 16:23:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OzTi+ph+qLELYli0BNR6no/ipXJNHNHDbuicIqlQxGc=; b=0pslPZ5GBT84zu9enwNsLVuQiXme+0HoikKrh8WGijGbY+Ysl8YCfdCtBxvugEH7zK RdZywbxhHuySkki7yfkPKC86kXaNadpUjvRx9hMcBRvSlbM12DhQS9ByksRt2h2nevSM WlrWE91A4gdpU+I0QF9G85uXtP6Und8aEsmzDR6Wee3TECRY9rzThyZDtbLhL1gvd4JC EsjaRL5xgrM1nlFwvenRdzw5aGXzS/3mTWvxIvHeZ+3KtrferLBknOjNz+bz8BvR4ZQt hDO5TixweKRvssALjg8BfhGZvJY4KYS/RMUy+nK8cCxy0CccPRBTYljEdCCCetZDesqv dCOQ== X-Gm-Message-State: AOAM533vG5XW7NQ7HbXxfuVN+Slr2WIEiVTB25FQ3kTz+MPXuehv9Kxl OmNV3iYF4g2jHVAv5ni81gE= X-Google-Smtp-Source: ABdhPJwGbgj0KKS8qAaJboJ40dQ1VedVWoJvB7q21vC93dokivWc3QUJa3miuDiTtocq0uqSFcEkyg== X-Received: by 2002:a5d:47cd:: with SMTP id o13mr9750221wrc.85.1635463386064; Thu, 28 Oct 2021 16:23:06 -0700 (PDT) Received: from nbbrfq (dynamic-2bq7di4u2lfl4qjka9-pd01.res.v6.highway.a1.net. [2001:871:227:33a8:f6a3:c58c:7641:e771]) by smtp.gmail.com with ESMTPSA id r4sm4155211wrp.26.2021.10.28.16.23.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Oct 2021 16:23:05 -0700 (PDT) Date: Fri, 29 Oct 2021 01:23:02 +0200 From: Bernhard Reutner-Fischer To: Harald Anlauf Cc: rep.dot.nop@gmail.com, fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [PATCH,FORTRAN] Fix memory leak of gsymbol Message-ID: <20211029012302.052fc4c4@nbbrfq> In-Reply-To: References: <20181021140434.30743-1-rep.dot.nop@gmail.com> <20211027234320.16fc848b@nbbrfq> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Oct 2021 23:23:08 -0000 On Thu, 28 Oct 2021 23:37:59 +0200 Harald Anlauf wrote: > Hi Bernhard, > > Am 27.10.21 um 23:43 schrieb Bernhard Reutner-Fischer via Gcc-patches: > > ping > > [I'll rebase and retest this too since it's been a while. > > Ok if it passes?] > > > > On Sun, 21 Oct 2018 16:04:34 +0200 > > Bernhard Reutner-Fischer wrote: > >> gcc/fortran/ChangeLog: > >> > >> 2018-10-21 Bernhard Reutner-Fischer > >> > >> * parse.c (clean_up_modules): Free gsym. > this essentially looks fine, but did you inspect the callers? > > With the change to the interface (*gsym -> *&gsym), it could have > effects not visible here due to the explicit gsym = NULL. > > Assuming you checked that, and if it regtests fine, then it is > OK for mainline. The only caller is translate_all_program_units. Since we free only module gsyms, even -fdump-fortran-global is unaffected by this, fwiw. It regtests cleanly and i will push it when the rest is approved. Thanks!