From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by sourceware.org (Postfix) with ESMTPS id E1C44385840C for ; Sat, 30 Oct 2021 16:52:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E1C44385840C Received: by mail-wr1-x42a.google.com with SMTP id k7so21508818wrd.13 for ; Sat, 30 Oct 2021 09:52:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=I+sBdw+vOh9kN3mOuXHIFjWF0pUQAkSROIcc719t7M8=; b=ao1gHRCwzdXOsYSbLIuM/hxh51vu5BC0jOnuvxm0PGmhz/AuHMV7XVQuTFWkJsJv4j ijPhuYEK5voLovGffEilLowk9nnZ4Zwxilrya9Z8TCalK4rhTbIs0zJKPrfhoTjMgAYq EzVtR7Z86ZgVfPrUtw+1Ae9SSm4867c//7SBKwbsSIxeb/7nbjGlQSPGtPm8x8b63d40 7CK70k8Lu9C94TqEg3C1TNcuw5n6ZOUBFAwTKdFRgHVza0R/x0xNqDG+lmyz4sbKhbRr zBkGTU2g45dyEH5Rj4DPE3IBkaU6x+5QrUSwG7fRAIfPnnr54JCHonFFyCaqJdyMfauA YwmQ== X-Gm-Message-State: AOAM531Zu8ZAxQLFVVNw4Rfyf9YoZm+I0ZRm6tioKIURXo31lkycjdb1 EZ0RScN9NCcmjeehqWB3OeI= X-Google-Smtp-Source: ABdhPJzEtaf9WHvxS5kDxWeLG25ahULyBAaYhkaRiBdB1Y9Xc+4uQfewxe+VSDOu5QBu4WqelsM9rA== X-Received: by 2002:adf:f04d:: with SMTP id t13mr9178738wro.324.1635612779006; Sat, 30 Oct 2021 09:52:59 -0700 (PDT) Received: from nbbrfq (dynamic-2bq7di4u2lfl4qjka9-pd01.res.v6.highway.a1.net. [2001:871:227:33a8:f6a3:c58c:7641:e771]) by smtp.gmail.com with ESMTPSA id f18sm9000028wrg.3.2021.10.30.09.52.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Oct 2021 09:52:58 -0700 (PDT) Date: Sat, 30 Oct 2021 18:52:56 +0200 From: Bernhard Reutner-Fischer To: Harald Anlauf Cc: rep.dot.nop@gmail.com, fortran@gcc.gnu.org Subject: Re: [PATCH,FORTRAN] Fix memory leak of gsymbol Message-ID: <20211030185256.2e1c4434@nbbrfq> In-Reply-To: <20211029012302.052fc4c4@nbbrfq> References: <20181021140434.30743-1-rep.dot.nop@gmail.com> <20211027234320.16fc848b@nbbrfq> <20211029012302.052fc4c4@nbbrfq> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Oct 2021 16:53:01 -0000 On Fri, 29 Oct 2021 01:23:02 +0200 Bernhard Reutner-Fischer wrote: > On Thu, 28 Oct 2021 23:37:59 +0200 > Harald Anlauf wrote: > > > Hi Bernhard, > > > > Am 27.10.21 um 23:43 schrieb Bernhard Reutner-Fischer via Gcc-patches: > > > ping > > > [I'll rebase and retest this too since it's been a while. > > > Ok if it passes?] > > > > > > On Sun, 21 Oct 2018 16:04:34 +0200 > > > Bernhard Reutner-Fischer wrote: > > > >> gcc/fortran/ChangeLog: > > >> > > >> 2018-10-21 Bernhard Reutner-Fischer > > >> > > >> * parse.c (clean_up_modules): Free gsym. > > > this essentially looks fine, but did you inspect the callers? > > > > With the change to the interface (*gsym -> *&gsym), it could have > > effects not visible here due to the explicit gsym = NULL. > > > > Assuming you checked that, and if it regtests fine, then it is > > OK for mainline. > > The only caller is translate_all_program_units. > Since we free only module gsyms, even -fdump-fortran-global is > unaffected by this, fwiw. > > It regtests cleanly and i will push it when the rest is approved. > Thanks! Pushed as r12-4804 thanks,