public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: Harald Anlauf <anlauf@gmx.de>
To: fortran <fortran@gcc.gnu.org>, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: *PING* [PATCH] PR fortran/69419 - ICE: tree check: expected array_type, have real_type in gfc_conv_array_initializer, at fortran/trans-array.c:5618
Date: Wed, 3 Nov 2021 21:00:41 +0100	[thread overview]
Message-ID: <20c557a7-3769-b8ba-aa53-bd977146e348@gmx.de> (raw)
Message-ID: <20211103200041.oQiNI3HFJcS8Bw1OyQbw2yJVt4AmFOjaS-40g9m41-8@z> (raw)
In-Reply-To: <trinity-e29ae6f6-871e-4ad9-ba32-87892e503bb6-1635361763453@3c-app-gmx-bap04>

*PING*

Am 27.10.21 um 21:09 schrieb Harald Anlauf via Fortran:
> Dear Fortranners,
>
> when debugging the testcase, I noticed that a coarray declaration in
> a COMMON statement wrongly set the dimension attribute instead of the
> codimension.  As a consequence, subsequent checks that catch this
> invalid situation would not trigger.
>
> I see two possible solutions:
>
> - in gfc_match_common, replace
>
> 	  /* Deal with an optional array specification after the
> 	     symbol name.  */
> 	  m = gfc_match_array_spec (&as, true, true);
>
>    by
>
>    m = gfc_match_array_spec (&as, true, false);
>
>    which in turn would lead to a syntax error.  Interestingly, the Intel
>    compiler also takes this route and gives a syntax error.
>
> - check the resulting as->corank and emit an error as in the attached
>    patch.
>
> The attached patch regtests fine on x86_64-pc-linux-gnu.  OK for mainline?
>
> Thanks,
> Harald
>


  reply	other threads:[~2021-11-03 20:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-27 19:09 Harald Anlauf
2021-11-03 20:00 ` Harald Anlauf [this message]
2021-11-03 20:00   ` *PING* " Harald Anlauf
2021-11-04  9:06   ` Bernhard Reutner-Fischer
2021-11-04 19:49     ` Harald Anlauf
2021-11-04 19:49       ` Harald Anlauf
2021-11-05 21:46       ` Mikael Morin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20c557a7-3769-b8ba-aa53-bd977146e348@gmx.de \
    --to=anlauf@gmx.de \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).