From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 0359D385DC07 for ; Fri, 14 Jan 2022 11:56:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0359D385DC07 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-149-HY38VFBPMgWQwdoeL6Qgqg-1; Fri, 14 Jan 2022 06:56:04 -0500 X-MC-Unique: HY38VFBPMgWQwdoeL6Qgqg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F1C89802925; Fri, 14 Jan 2022 11:56:02 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.195.246]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6E6AB7AB5D; Fri, 14 Jan 2022 11:56:01 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 20EBtw7U257647 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 14 Jan 2022 12:55:59 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 20EBtvJO257646; Fri, 14 Jan 2022 12:55:57 +0100 Date: Fri, 14 Jan 2022 12:55:57 +0100 From: Jakub Jelinek To: Tobias Burnus Cc: Thomas Schwinge , Hafiz Abid Qadeer , gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org Subject: Re: [PATCH] [gfortran] Add support for allocate clause (OpenMP 5.0). Message-ID: <20220114115557.GK2646553@tucnak> Reply-To: Jakub Jelinek References: <20211022130502.2211568-1-abidh@codesourcery.com> <20211102162714.GF304296@tucnak> <20211220200650.GN2646553@tucnak> <87bl0evg25.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jan 2022 11:56:09 -0000 On Fri, Jan 14, 2022 at 12:45:54PM +0100, Tobias Burnus wrote: > On 14.01.22 10:10, Thomas Schwinge wrote: > > > + integer :: x > > > ... > > > + !$omp parallel allocate (0: x) private(x) ! { dg-error "Expected integer expression of the 'omp_allocator_handle_kind' kind at .1." } > > We do for x86_64 default '-m64', but for '-m32' and '-mx32' compilation, > > we're not seeing this latter diagnostic: > > FAIL: gfortran.dg/gomp/allocate-2.f90 -O (test for errors, line 36) > > > > I suppose the reason is unintended congruence of data types? Would it > > work to make 'x' a floating-point data type, for example -- or is this > > meant to explicitly check certain integer data type characteristics? > > Alternatively, you could use 'integer(kind=1)' (which is a 1-byte/8-bits > type.) I assume we do not have any platform which still uses 8-bit > pointers and supports libgomp :-) If we want to check intptr_t, we should guard the dg-error with "" { target { lp64 || llp64 } } or so. Otherwise yes, we can add some other kind and hope it is not the same as omp_allocator_handle_kind. Or we can do both, keep the current one with the target lp64 || llp64 and add another one with some integer(kind=1). Jakub