From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ciao.gmane.io (ciao.gmane.io [116.202.254.214]) by sourceware.org (Postfix) with ESMTPS id 7BEBC3853801 for ; Tue, 25 Jan 2022 21:30:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7BEBC3853801 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1nCTOZ-0000jy-HT for fortran@gcc.gnu.org; Tue, 25 Jan 2022 22:30:31 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: fortran@gcc.gnu.org From: Harald Anlauf Subject: Re: [PR103970, Fortran, Coarray] Multi-image co_broadcast of derived type with allocatable components fails^ Date: Tue, 25 Jan 2022 22:30:22 +0100 Message-ID: <3a178fe2-7e38-f4f5-9efd-b861f9740abd@gmx.de> References: <20220125173213.1265f8e3@vepi2> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Content-Language: en-US In-Reply-To: <20220125173213.1265f8e3@vepi2> Cc: gcc-patches@gcc.gnu.org X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Jan 2022 21:30:34 -0000 Message-ID: <20220125213022.kZMWTwPAsmZJ3hHC7giDS8Wa3EAOxsrdc6VrXyUjmiU@z> Hi Andre', Am 25.01.22 um 17:32 schrieb Andre Vehreschild via Fortran: > Hi all, > > attached patch fixes wrong code generation when broadcasting a derived type > containing allocatable and non-allocatable scalars. Furthermore does it prevent > broadcasting of coarray-tokens, which are always local this_image. Thus having > them on a different image makes no sense. > > Bootstrapped and regtested ok on x86_64-linux/F35. > > Ok, for trunk and backport to 12 and 11-branch after decent time? > > I perceived that 12 is closed for this kind of bugfix, therefore asking ok for > 13. I do not think that 12 is closed for bugfixing, especially not for fortran. And if my cursory reading of the patch is not misleading, the impact of the patch is really limited to coarrays. You may want to wait for another 1-2 days for additional comments. If not, it is OK from my side. Thanks for the patch! Harald > Regards, > Andre > -- > Andre Vehreschild * Email: vehre ad gmx dot de