From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) by sourceware.org (Postfix) with ESMTPS id 150BA3858C78 for ; Wed, 26 Jan 2022 16:02:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 150BA3858C78 Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.16.1/8.16.1) with ESMTPS id 20QG2VMK042584 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 26 Jan 2022 08:02:31 -0800 (PST) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.16.1/8.16.1/Submit) id 20QG2V89042583; Wed, 26 Jan 2022 08:02:31 -0800 (PST) (envelope-from sgk) Date: Wed, 26 Jan 2022 08:02:31 -0800 From: Steve Kargl To: Tobias Burnus Cc: FX , fortran@gcc.gnu.org Subject: Re: New signaling NaN causes 12 testsuite failures Message-ID: <20220126160231.GA42566@troutmask.apl.washington.edu> References: <20220125004453.GA16729@troutmask.apl.washington.edu> <1DA16214-53F0-4B2E-AB56-503AAD59B266@gmail.com> <20220125193526.GA69322@troutmask.apl.washington.edu> <154020AE-C99E-400F-B86C-A8AF4720F16F@gmail.com> <20220125204544.GE69322@troutmask.apl.washington.edu> <33b4ec6c-5867-6eab-6200-02a964c43ccd@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <33b4ec6c-5867-6eab-6200-02a964c43ccd@codesourcery.com> X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Jan 2022 16:02:35 -0000 On Wed, Jan 26, 2022 at 11:47:27AM +0100, Tobias Burnus wrote: > On 25.01.22 21:56, FX via Fortran wrote: > > What I wonder is: if those conditions failed, then the struct they define should have been empty, and therefore the code shouldn’t compile anyway (that was the intent). > > Wouldn't it make more sense to add '#else' / '#error "...."' in that case? > AFAICT, the first condition does not fail due to the missing trailing underscores. #if __FLOAT_WORD_ORDER == __BIG_ENDIAN becomes (I believe) #if 0 == 0 so FreeBSD was using big endian in FX's issignaling_fallback when it needed little endian. PS: Thanks FX for your patch! -- Steve