From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by sourceware.org (Postfix) with ESMTPS id 1FD8F3858D1E; Fri, 28 Jan 2022 09:36:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1FD8F3858D1E X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from vepi2 ([79.194.174.218]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MOA3F-1mtLig3eqv-00OVpS; Fri, 28 Jan 2022 10:36:23 +0100 Date: Fri, 28 Jan 2022 10:36:23 +0100 From: Andre Vehreschild To: Tobias Burnus Cc: Fortran , Harald Anlauf , Damian Rouson , Subject: Re: [Submitted, PR103970, Fortran, Coarray] Multi-image co_broadcast of derived type with allocatable components fails^ Message-ID: <20220128103623.5ecb18fc@vepi2> In-Reply-To: <0ccb632a-af49-1fb6-3bce-f055690d1c68@codesourcery.com> References: <20220125173213.1265f8e3@vepi2> <3a178fe2-7e38-f4f5-9efd-b861f9740abd@gmx.de> <20220128100720.4128c9ce@vepi2> <0ccb632a-af49-1fb6-3bce-f055690d1c68@codesourcery.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:A+LWL/Y9B62Upvsy0+IBSZCc7c7vuBTHY6c52tFmArB8QAhKo5A OUUwEAvnu3n6XqkQb1NNA/tAaYe4UiTTGhL4dFoiH4fnH9M9LNpJvgmhqZ3cC5GJLMjMynk I8ddCM/vGC9famwgp+BOjQocJb2ni/GhGmpWPj8hMkzHDBrrXsGx92soljRAu3EHHRGzwOc b7gfyIp7cLaCBzuJksF0A== X-UI-Out-Filterresults: notjunk:1;V03:K0:BNKJJlbp9sg=:ZCmglT7obOGR1kyZ0g9F/S +04JWWUp+qT8bLu+DEnwcJQq3PW8lKdkucXHQpafqnlEqOGtGVgZqNig8h1VL3c4pHfH3HLvS j+1pk8dx0yd7n0VhWiim2tjMSZUUCkYWoA/qP2YpwcIOo3FXHZGlkuNnG0sBvsc/gwXmtJmm3 GH94zrp7jGlIgP3TDoUYwYRwFCaznEYMkxpGyXeLEeq0EJ+LAJrwHpX24y8thtUIpe9ZyBKMD vlBe3yx6d++KbOWoTI616Ri8qqK/8t2ImbNCheXbtRnXgwi7sTl0wgsVhHGjllt9XiKjucW71 jPRErA80UYNtytgvonR4lGUI8ZVgHmSjuO21Ml394dJ9Lfe7ZWu8v+l5M+rnpKZkOim9UejJk 916WvSfqSwcyUErqV9OluueXw7j1lexge32N8KN9JwpVLCLP26oZ20u57m7sA1DSMtbjzzrWw l1O5V52NDX9x4b6nfxx167eK1mU7WD3wmrNye6qxgXgw6P+oqTN33Iz2GsyivZ5Y060SA9hfs RroIsTMgB2nqHyQyPMbVJvfbS8VOXfEoSxYjFh1PIFpwh0Zq6acXVxYU/cCcANEMWSdEHnXRk GHcEMUreRREnOy/3a5Y9O5GqeeecrUJWQvrA5V+AYow0ZD4hUGxXQq/NgU+/vTO2UgDoumMIp OuEK+UXa9D+HYwxbewoc2Ex9krIEp0UBPDgaqW1UVsAHNe3MCLqxxiALiNOXlyQlb080ghNAF W4x4Gim6VaRPIzUhHQmYdC/1QU9KwfXl4XZTxCj9VtxxZ9A4CXLL82Ta4CZnRH7yJv4CwfSrA 5hLepBPmo5N8O9usrsHsA/gmm8I9zeaFWzc3ch62Grlo8jMRZQT3rr73PuHHi/aC5BpKqIqfT D9gO4CzhIbu9fzc1GWxCr3hORQ7q+JeyW1jDk/VOzGOkqInRHpcDQNPZLITekG9WkCawE+Fko j+1PkcriE2KiB9LTjJKS1dBnhWnn3DU1t6FspZDwoJuybyRrU8cvcDbIvcgA/hEB15fTxWmXy d3hHS5n/RWx+3SHPVM8d7E3Oab0KLt6A+j3iJMbpP2Y1Klnd1bkiNPU45hsRAAJhuQHe2rjMK VtdzhHCRWy3caW46iaMlzN5zKWQaNhUaXBbXqZU+GhqRl+oc6bm0An0EU2/153qO5Vv3U24ar 3zbHeQ0ggS/mLVJudRzNwnjjC7 X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Jan 2022 09:36:31 -0000 Hi Tobias, ups, sorry, reverted immediately. Regards, Andre On Fri, 28 Jan 2022 10:27:26 +0100 Tobias Burnus wrote: > Hi Andre, >=20 > your patch breaks bootstrapping: >=20 > ../../repos/gcc/gcc/fortran/trans-array.cc: In function =E2=80=98tree_nod= e* > structure_alloc_comps(gfc_symbol*, tree, tree, int, int, int, > gfc_co_subroutines_args*)=E2=80=99: > ../../repos/gcc/gcc/fortran/trans-array.cc:9200:42: error: =E2=80=98cdesc= =E2=80=99 may be > used uninitialized [-Werror=3Dmaybe-uninitialized] 9200 | > gfc_conv_descriptor_data_set (&tmpblock, cdesc, comp); | > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~ > ../../repos/gcc/gcc/fortran/trans-array.cc:9082:16: note: =E2=80=98cdesc= =E2=80=99 was > declared here 9082 | tree cdesc; | ^~~~~ cc1plus: > all warnings being treated as errors make[3]: *** [Makefile:1143: > fortran/trans-array.o] Error 1 >=20 > Tobias >=20 > On 28.01.22 10:07, Andre Vehreschild via Fortran wrote: > > Hi Harald, > > > > thanks for the fast review. I have submitted as c9c48ab7bad. > > > > Will wait for two weeks (reminder set :-)) before backporting to gcc-11. > > > > Thank you and regards, > > Andre > > > > On Tue, 25 Jan 2022 22:30:22 +0100 > > Harald Anlauf via Fortran wrote: > > =20 > >> Hi Andre', > >> > >> Am 25.01.22 um 17:32 schrieb Andre Vehreschild via Fortran: =20 > >>> Hi all, > >>> > >>> attached patch fixes wrong code generation when broadcasting a derived > >>> type containing allocatable and non-allocatable scalars. Furthermore = does > >>> it prevent broadcasting of coarray-tokens, which are always local > >>> this_image. Thus having them on a different image makes no sense. > >>> > >>> Bootstrapped and regtested ok on x86_64-linux/F35. > >>> > >>> Ok, for trunk and backport to 12 and 11-branch after decent time? > >>> > >>> I perceived that 12 is closed for this kind of bugfix, therefore aski= ng ok > >>> for 13. =20 > >> I do not think that 12 is closed for bugfixing, especially not for > >> fortran. And if my cursory reading of the patch is not misleading, > >> the impact of the patch is really limited to coarrays. > >> > >> You may want to wait for another 1-2 days for additional comments. > >> If not, it is OK from my side. > >> > >> Thanks for the patch! > >> > >> Harald > >> =20 > >>> Regards, > >>> Andre > >>> -- > >>> Andre Vehreschild * Email: vehre ad gmx dot de =20 > >> =20 > > > > -- > > Andre Vehreschild * Email: vehre ad gmx dot de =20 > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 2= 01, 80634 > M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3=A4ftsf= =C3=BChrer: Thomas > Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaft: M=C3=BCnchen; Registe= rgericht > M=C3=BCnchen, HRB 106955 --=20 Andre Vehreschild * Email: vehre ad gmx dot de=20