From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by sourceware.org (Postfix) with ESMTPS id BC69F385840F; Fri, 28 Jan 2022 11:39:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BC69F385840F X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from vepi2 ([79.194.174.218]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MtwUm-1mPiDy2MMm-00uIC7; Fri, 28 Jan 2022 12:39:18 +0100 Date: Fri, 28 Jan 2022 12:39:17 +0100 From: Andre Vehreschild To: Andre Vehreschild via Fortran Cc: Andre Vehreschild , Tobias Burnus , Damian Rouson , gcc-patches@gcc.gnu.org, Harald Anlauf Subject: Re: [Submitted, PR103970, Fortran, Coarray] Multi-image co_broadcast of derived type with allocatable components fails^ Message-ID: <20220128123917.53516098@vepi2> In-Reply-To: <20220128103623.5ecb18fc@vepi2> References: <20220125173213.1265f8e3@vepi2> <3a178fe2-7e38-f4f5-9efd-b861f9740abd@gmx.de> <20220128100720.4128c9ce@vepi2> <0ccb632a-af49-1fb6-3bce-f055690d1c68@codesourcery.com> <20220128103623.5ecb18fc@vepi2> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:bUKk3NhSzZiCdLFfLlUcgRREtLh9bbsca+Kk1ynBodgb/zm225i gp0/Ol/tgt9SK+8qVYP2iUN21j/ktta4y91v2A1vXNRqx3XyfNNLLWt90pzwwUiCT2EAxbA 6VkNLVQhBhfRP+BIjBeCOCj0DuRDC0+N5Vs+6yUOkAbO71BKrzO8jEFLWLAybFoPKUjG0Wa BlyKQ1dXHeXFYdb5iG+CQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:kZ7dU1FuOIs=:CdHlfNv8Ozk8u1EfzUG8ox m6a7GCoG4R2VM/CIkduJwcH25zCOCBE/KnDkgGOvZIwRNa/oxBnyJ9m6Hxai3sSMN5qz9aKHh dUr7xwJ4B72GPrm6KWTd9db1rXKGB9O/Cou096BysecCeP2pOHGOvMZJkir5xS6JHPXCru2d0 CGHKOs55giqZQhVnRSFddjJFBrW0zvs21de+1IKNtolet96yNjkmTLySU02T3S1OlMnvPHnj3 prnUwgM7zruSOy+68jlF48k32JxaQuXpeeEhKLOD4mbCF4Dho+ndxSTMIlBwj3oWcBAcNpvj3 gtgrjifrwEueTtaqABlSlB49degFjlusphMkldHuWFnJAIRcAB01dnZ2COKHufhPiR/7sao8f JyjB1tM8zuI62LpB9FTa2M7EpbWlz6BMx/dYQjawlAUGoXr1hb7NU/rvyIaPxJN8wtu0ypjxQ 8ZVOcWIs3hUNFf5QYrj0mGZO4AU2WukhP8vRjqtmuhkRATVmOb0yYQ7HlWz2D+2OasvLnx5WQ AVl8t6HIrjvMsJYewReqhDpBvEFDtLeUyx05RS07Zwp4NrX/Mj9MAT4cDjXbLZ+U72pKbCN10 Lq5W/fEy/svnfpFCn4mudW82yyvWnzJWkPn/NVceSY1o2Ajb8GB1YQhOk8oECGwgPgfDWE2bB LhXckZWBSxMMl3ghcZ/7C+6pQk2ivdcwsfRTu6s7pF/pTZg46gAQ/WC1O021B4Q+C8GUvYZ6C LJpL+uXQrOFgeRSL2uufhyxpcEq2HJeiZfhk+BS9SxbUdMdygAckn61hxt6Z9/6/+hHPKe1lC eq6N7orqvW18OVq5UgDx0IfrQ2o+eIl3hBQayncXBRhupWdghDRjXL7IldFTJdTwO1WUKPjbN atDjkurd3//ekZprb+ySPI3F72iUXQ6/1NF4bDoLT2Bq8fgLfYqZ/enCzrzQ/mTd1LXf9vblc +5yftkCR+jT7qv2FM3UmtyQYxIh2/YvNudfZNBquQlSFccx4BE76NgGtzXHnl2OIPj3ONH3Yn FG0dhLXPkHiCXBk5yaVka0BWMcN4XQzFu49oLi9EMjpm6537PRLWBYsHe9ij32BKrapK1WzV5 i2xaxzqRRLrgmzvovXpNbyr+tGuGLeOWZg2PxTLVuCP7DHGWXqrlHE35KZqDwZDqfPHDADr3j RjN67fwfjCMUbwK1lGDhVvnZ/3 X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Jan 2022 11:39:27 -0000 Hi Tobias, I don't know why that bootstrapped initially. I fixed the patch (naming a ``` else=20 /* Prevent warning. */ cdesc =3D NULL_TREE; ``` obvious) and rerun bootstrap making sure to purge everything beforehand. It= did not break bootstrap on x86_64-linux/f35. Hope it doesn't elsewhere with sub= mit 26e237fb5b8. Thanks for pointing this out. Regards, Andre On Fri, 28 Jan 2022 10:36:23 +0100 Andre Vehreschild via Fortran wrote: > Hi Tobias, >=20 > ups, sorry, reverted immediately. >=20 > Regards, > Andre >=20 > On Fri, 28 Jan 2022 10:27:26 +0100 > Tobias Burnus wrote: >=20 > > Hi Andre, > >=20 > > your patch breaks bootstrapping: > >=20 > > ../../repos/gcc/gcc/fortran/trans-array.cc: In function =E2=80=98tree_n= ode* > > structure_alloc_comps(gfc_symbol*, tree, tree, int, int, int, > > gfc_co_subroutines_args*)=E2=80=99: > > ../../repos/gcc/gcc/fortran/trans-array.cc:9200:42: error: =E2=80=98cde= sc=E2=80=99 may be > > used uninitialized [-Werror=3Dmaybe-uninitialized] 9200 | > > gfc_conv_descriptor_data_set (&tmpblock, cdesc, comp); | > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~ > > ../../repos/gcc/gcc/fortran/trans-array.cc:9082:16: note: =E2=80=98cdes= c=E2=80=99 was > > declared here 9082 | tree cdesc; | ^~~~~ cc1pl= us: > > all warnings being treated as errors make[3]: *** [Makefile:1143: > > fortran/trans-array.o] Error 1 > >=20 > > Tobias > >=20 > > On 28.01.22 10:07, Andre Vehreschild via Fortran wrote: =20 > > > Hi Harald, > > > > > > thanks for the fast review. I have submitted as c9c48ab7bad. > > > > > > Will wait for two weeks (reminder set :-)) before backporting to gcc-= 11. > > > > > > Thank you and regards, > > > Andre > > > > > > On Tue, 25 Jan 2022 22:30:22 +0100 > > > Harald Anlauf via Fortran wrote: > > > =20 > > >> Hi Andre', > > >> > > >> Am 25.01.22 um 17:32 schrieb Andre Vehreschild via Fortran: =20 > > >>> Hi all, > > >>> > > >>> attached patch fixes wrong code generation when broadcasting a deri= ved > > >>> type containing allocatable and non-allocatable scalars. Furthermore > > >>> does it prevent broadcasting of coarray-tokens, which are always lo= cal > > >>> this_image. Thus having them on a different image makes no sense. > > >>> > > >>> Bootstrapped and regtested ok on x86_64-linux/F35. > > >>> > > >>> Ok, for trunk and backport to 12 and 11-branch after decent time? > > >>> > > >>> I perceived that 12 is closed for this kind of bugfix, therefore as= king > > >>> ok for 13. =20 > > >> I do not think that 12 is closed for bugfixing, especially not for > > >> fortran. And if my cursory reading of the patch is not misleading, > > >> the impact of the patch is really limited to coarrays. > > >> > > >> You may want to wait for another 1-2 days for additional comments. > > >> If not, it is OK from my side. > > >> > > >> Thanks for the patch! > > >> > > >> Harald > > >> =20 > > >>> Regards, > > >>> Andre > > >>> -- > > >>> Andre Vehreschild * Email: vehre ad gmx dot de =20 > > >> =20 > > > > > > -- > > > Andre Vehreschild * Email: vehre ad gmx dot de =20 > > ----------------- > > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe= 201, > > 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch= =C3=A4ftsf=C3=BChrer: > > Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaft: M=C3=BCnchen; > > Registergericht M=C3=BCnchen, HRB 106955 =20 >=20 >=20 --=20 Andre Vehreschild * Email: vehre ad gmx dot de=20