From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by sourceware.org (Postfix) with ESMTPS id 298B73858412; Mon, 14 Feb 2022 15:20:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 298B73858412 X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from vepi2 ([79.194.174.218]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MS3mz-1nhSL80hmV-00TTur; Mon, 14 Feb 2022 16:20:45 +0100 Date: Mon, 14 Feb 2022 16:20:44 +0100 From: Andre Vehreschild To: GCC-Fortran-ML Cc: Damian Rouson , gcc-patches@gcc.gnu.org Subject: Re: [Backport, committed, PR103970, Fortran, Coarray] Multi-image co_broadcast of derived type with allocatable components fails^ Message-ID: <20220214162044.10074acf@vepi2> In-Reply-To: <20220128123917.53516098@vepi2> References: <20220125173213.1265f8e3@vepi2> <3a178fe2-7e38-f4f5-9efd-b861f9740abd@gmx.de> <20220128100720.4128c9ce@vepi2> <0ccb632a-af49-1fb6-3bce-f055690d1c68@codesourcery.com> <20220128103623.5ecb18fc@vepi2> <20220128123917.53516098@vepi2> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:Zb3+Vs1XTVQxI3BxK0BgY9r8lZaXhZVmHqpfJJ7krOzbYPh1anW G2aSg2AIApSkhwctYgwLABr+xCJF21vxkz6vEPCcdoeA7uPqqQwBa27JUTk4npkaAeH6e50 E+GLGQtnjUftavHWaFYEtfHmjC+YW+l3NneOq425NTiqmAfagHtBw+Xv0O/XWZDu3M7i3DB 1vmzozJ9mgrjlnKtlVrJQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:PI1A/8QKogU=:Iks4L1WTodMj9pO8HXGHsU Pd40xC5fiTCWwlXKZUSW4XrJOJTp0jQewsgeubHxqVKTZiYk9ADIca6Sa6maPeExbnQITcIVi Inh0lKmTrgJ3hASd6lVsy8sBzVIQ9AA1eMuAwA17y4c7SGwpZGEts6NnUmSCU7WmJi0ja6skH lt6czd9jCoxhiVZG3EOdiDih/nIXymnWJbBIyLGbwoMTp2HadYQIJoD/vwjkKO56jUqTXt7s0 iFJmjLqY57lSmJEOiY+u6/0sb/LY5yeAKdVQpfRe4z3Ah/HIG4xzJ3uAXUMyLqBxXcL2U2o/b lgFdFpUkEK9YhwvfPNOIsMqfTm8RsWF4v8x7aBkPfRsLEIm7ic+UrFxLixFw6Z9Hs98SVkUgx eVMC4qKy5ZCmXdMLxRyyKenmLLZP2kMqekJLaUieCcUvDyh4r4bowfHf7RvTdk7513EZ5fbsC n/JWmL1eY6fmKHmq/EA+DXETcgqPhZ8zsiD7HP/jUVjh1SODWnCgiyFSuz0BBTx6AdqQvlQQF f2B2G4gJAQoM6vr5zlwLq0PfvRgBxhc0pWrUYOUZYryLO43YVde/LvOLNUamT7j52XYRnW5Ab FnKekoPRI07Tpf4fkBaDDs70S++dpTDeuBoxdvcYebYecpeT7xHo5LxmOhfbpGPl92My3MWqz azC6A6q9yxa7nSNV4FFJNsgEXMhTAQpBSs3Ys8rsdqdayMXaht11le++79Kp3y/nq7sjzkjvP 5U434oedLOu1TQ/hdhPXBgESpjFa0MiyZYwGLyWk8yDIWIzp2+g+lOcUt8N+yW3jCuUmIgqnk AN8m/q3m5Yn67cSWRc+chC/T1efelPTO8mmmrSB7aooAN3XnsbBxYgroQxGoSJGcM5+VO5uLY T7y1HolSzhe1EhXlCzbKrtVyQ5Jc18vqccMLlSt62IPU1/ab187wMGfG4g5/0Y46tls64w15B 0ErsR53SRoO1LVa6rJzx0mWOCxASkrdSsMEfwHHynmKsXw0Baev5odjiN7tECbYT5J+P6+f67 HiaHuzt2JEiCBnCy2Q5Y17i77ec3EHnenqg/9rbI3Tp8yN6C8NTFpKnQrXE5+8xIIA== X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Feb 2022 15:20:50 -0000 Hi all, two weeks have passed with no complains about the patch for PR103970. There= fore backported and pushed to gcc-11 as 680ee9c3332. Regards, Andre On Fri, 28 Jan 2022 12:39:17 +0100 Andre Vehreschild wrote: > Hi Tobias, >=20 > I don't know why that bootstrapped initially. I fixed the patch (naming a > ``` > else=20 > /* Prevent warning. */ > cdesc =3D NULL_TREE; > ``` > obvious) and rerun bootstrap making sure to purge everything beforehand. = It > did not break bootstrap on x86_64-linux/f35. Hope it doesn't elsewhere wi= th > submit 26e237fb5b8. >=20 > Thanks for pointing this out. >=20 > Regards, > Andre >=20 > On Fri, 28 Jan 2022 10:36:23 +0100 > Andre Vehreschild via Fortran wrote: >=20 > > Hi Tobias, > >=20 > > ups, sorry, reverted immediately. > >=20 > > Regards, > > Andre > >=20 > > On Fri, 28 Jan 2022 10:27:26 +0100 > > Tobias Burnus wrote: > > =20 > > > Hi Andre, > > >=20 > > > your patch breaks bootstrapping: > > >=20 > > > ../../repos/gcc/gcc/fortran/trans-array.cc: In function =E2=80=98tree= _node* > > > structure_alloc_comps(gfc_symbol*, tree, tree, int, int, int, > > > gfc_co_subroutines_args*)=E2=80=99: > > > ../../repos/gcc/gcc/fortran/trans-array.cc:9200:42: error: =E2=80=98c= desc=E2=80=99 may be > > > used uninitialized [-Werror=3Dmaybe-uninitialized] 9200 | > > > gfc_conv_descriptor_data_set (&tmpblock, cdesc, comp); | > > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~ > > > ../../repos/gcc/gcc/fortran/trans-array.cc:9082:16: note: =E2=80=98cd= esc=E2=80=99 was > > > declared here 9082 | tree cdesc; | ^~~~~ cc1= plus: > > > all warnings being treated as errors make[3]: *** [Makefile:1143: > > > fortran/trans-array.o] Error 1 > > >=20 > > > Tobias > > >=20 > > > On 28.01.22 10:07, Andre Vehreschild via Fortran wrote: =20 > > > > Hi Harald, > > > > > > > > thanks for the fast review. I have submitted as c9c48ab7bad. > > > > > > > > Will wait for two weeks (reminder set :-)) before backporting to gc= c-11. > > > > > > > > Thank you and regards, > > > > Andre > > > > > > > > On Tue, 25 Jan 2022 22:30:22 +0100 > > > > Harald Anlauf via Fortran wrote: > > > > =20 > > > >> Hi Andre', > > > >> > > > >> Am 25.01.22 um 17:32 schrieb Andre Vehreschild via Fortran: =20 > > > >>> Hi all, > > > >>> > > > >>> attached patch fixes wrong code generation when broadcasting a de= rived > > > >>> type containing allocatable and non-allocatable scalars. Furtherm= ore > > > >>> does it prevent broadcasting of coarray-tokens, which are always = local > > > >>> this_image. Thus having them on a different image makes no sense. > > > >>> > > > >>> Bootstrapped and regtested ok on x86_64-linux/F35. > > > >>> > > > >>> Ok, for trunk and backport to 12 and 11-branch after decent time? > > > >>> > > > >>> I perceived that 12 is closed for this kind of bugfix, therefore > > > >>> asking ok for 13. =20 > > > >> I do not think that 12 is closed for bugfixing, especially not for > > > >> fortran. And if my cursory reading of the patch is not misleading, > > > >> the impact of the patch is really limited to coarrays. > > > >> > > > >> You may want to wait for another 1-2 days for additional comments. > > > >> If not, it is OK from my side. > > > >> > > > >> Thanks for the patch! > > > >> > > > >> Harald > > > >> =20 > > > >>> Regards, > > > >>> Andre > > > >>> -- > > > >>> Andre Vehreschild * Email: vehre ad gmx dot de =20 > > > >> =20 > > > > > > > > -- > > > > Andre Vehreschild * Email: vehre ad gmx dot de =20 > > > ----------------- > > > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3= =9Fe 201, > > > 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch= =C3=A4ftsf=C3=BChrer: > > > Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaft: M=C3=BCnch= en; > > > Registergericht M=C3=BCnchen, HRB 106955 =20 > >=20 > > =20 >=20 >=20 --=20 Andre Vehreschild * Email: vehre ad gmx dot de=20