From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ciao.gmane.io (ciao.gmane.io [116.202.254.214]) by sourceware.org (Postfix) with ESMTPS id C35AC3858C74 for ; Tue, 8 Mar 2022 21:44:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C35AC3858C74 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1nRhcv-000A95-1I for fortran@gcc.gnu.org; Tue, 08 Mar 2022 22:44:17 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: fortran@gcc.gnu.org From: Harald Anlauf Subject: Re: [Patch] Fortran: Fix gfc_conv_gfc_desc_to_cfi_desc with NULL [PR104126] Date: Tue, 8 Mar 2022 22:44:11 +0100 Message-ID: References: <5535ea6a-80d1-c674-fa5b-a28ec26c2ce0@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Content-Language: en-US In-Reply-To: <5535ea6a-80d1-c674-fa5b-a28ec26c2ce0@codesourcery.com> Cc: gcc-patches@gcc.gnu.org X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_SHORT, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Mar 2022 21:44:19 -0000 Message-ID: <20220308214411.aoDHxi_ESZLp34XEW1INSpv1KkdJ9ThCuMe726pkRVA@z> Hi Tobias, Am 07.03.22 um 15:16 schrieb Tobias Burnus: > Pre-remark: Related NULL, there some accepts-invalid issues, not > addressed in this > patch. See https://gcc.gnu.org/PR104819 > > This patch fixes an ICE (12 regression) with NULL() that has no MOLD > argument. the patch does fix the ICE. But given your short pre-remark: are you saying that the testcase is invalid, and with the patch we silently accept it now? (The testcase compiles with Intel, but triggers a funny bug in crayftn, which made me read 16.9.144 to learn more about the tricks of NULL. But I tend to think this case is valid.) > OK for mainline? LGTM. Thanks for the patch! Harald > Tobias > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, > 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: > Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; > Registergericht München, HRB 106955