From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: fortran@gcc.gnu.org
Subject: allocatable arrays and -fmax-stack-var-size
Date: Thu, 31 Mar 2022 10:07:47 -0700 [thread overview]
Message-ID: <20220331170747.GA57166@troutmask.apl.washington.edu> (raw)
So, it seems that at some point in the past, the option
-fmax-stack-var-size was expanded to allow the placement
of an allocatable array into static memory. This has
a possibly unintended consequence in that automatic
deallocation of an allocatable array does not (or can
not) occur.
program foo
implicit none
call testAutoDealloc(20)
call testAutoDealloc(200)
contains
subroutine testAutoDealloc(n)
integer, intent(in) :: n
real, allocatable :: temp(:)
allocate(temp(n))
temp = n
if (temp(n) /= n) stop n
end
end program foo
% gfcx -o u a.f90 && ./u
% gfcx -o u -fmax-stack-var-size=10 -fdump-tree-original a.f90 && ./u
At line 9 of file a.f90
Fortran runtime error: Attempting to allocate already allocated variable 'temp'
% head -4 u-a.f90.005t.original
__attribute__((fn spec (". r ")))
void testautodealloc (integer(kind=4) & restrict n)
{
static struct array01_real(kind=4) temp = {.data=0B};
Now, it seems that an explicit deallocation of temp at the end of
the subroutine testAutoDealloc suppresses the runtime error. Looking
at a -fdump-tree-original with the modified code shows
if ((real(kind=4)[0:] * restrict) temp.data == 0B)
{
_gfortran_runtime_error_at (...Attempt to DEALLOCATE unallocated...);
}
else
{
__builtin_free ((void *) temp.data);
(real(kind=4)[0:] * restrict) temp.data = 0B;
}
Should the automatic deallocation of allocatable arrays be restore?
I'll let someone who cares enough to pursue this route. Until then,
here's a patch to the manual to caution the unwary.
diff --git a/gcc/fortran/invoke.texi b/gcc/fortran/invoke.texi
index 6435dc4d4de..b5002d2a31a 100644
--- a/gcc/fortran/invoke.texi
+++ b/gcc/fortran/invoke.texi
@@ -1786,13 +1786,19 @@ The default value for @var{n} is 65535.
@item -fmax-stack-var-size=@var{n}
@opindex @code{fmax-stack-var-size}
This option specifies the size in bytes of the largest array that will be put
-on the stack; if the size is exceeded static memory is used (except in
-procedures marked as RECURSIVE). Use the option @option{-frecursive} to
-allow for recursive procedures which do not have a RECURSIVE attribute or
-for parallel programs. Use @option{-fno-automatic} to never use the stack.
+on the stack. If the size of an array exceeds @var{n}, then the array is
+placed in static memory (except in procedures marked as RECURSIVE). Use
+the option @option{-frecursive} to allow for recursive procedures which
+do not have a RECURSIVE attribute or for parallel programs.
+Use @option{-fno-automatic} to never use the stack.
+
+The @option{-Wsurprising} option can be used to determine which arrays
+have been placed into static memory.
+
+@option{-fmax-stack-var-size} can inhibit the automatic deallocation of
+allocatable arrays. Proper memory management is required if this option
+is used (i.e., explicit deallocation is encouraged).
-This option currently only affects local arrays declared with constant
-bounds, and may not apply to all character variables.
Future versions of GNU Fortran may improve this behavior.
The default value for @var{n} is 65536.
--
Steve
next reply other threads:[~2022-03-31 17:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 17:07 Steve Kargl [this message]
2022-03-31 18:36 ` Thomas Koenig
2022-03-31 18:49 ` Steve Kargl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220331170747.GA57166@troutmask.apl.washington.edu \
--to=sgk@troutmask.apl.washington.edu \
--cc=fortran@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).