From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ciao.gmane.io (ciao.gmane.io [116.202.254.214]) by sourceware.org (Postfix) with ESMTPS id A2080385780F for ; Fri, 8 Apr 2022 20:45:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A2080385780F Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1ncvTZ-0001Nq-5Q for fortran@gcc.gnu.org; Fri, 08 Apr 2022 22:45:01 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: fortran@gcc.gnu.org From: Harald Anlauf Subject: [PATCH, v2] PR fortran/105184 - ICE in gfc_array_init_size, at fortran/trans-array.cc:5841 Date: Fri, 8 Apr 2022 22:44:54 +0200 Message-ID: <00368e5d-a283-0069-fa5e-1f0401516ddf@gmx.de> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------xbjJXChCMlhcjexzjtNPx46r" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US In-Reply-To: Cc: gcc-patches@gcc.gnu.org X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_NUMSUBJECT, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, WEIRD_PORT autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Apr 2022 20:45:05 -0000 Message-ID: <20220408204454.gCQoMH5S8prPmxKWIvakOtYUMmP4aO3a0xr5jOXwIAQ@z> This is a multi-part message in MIME format. --------------xbjJXChCMlhcjexzjtNPx46r Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Dear all, Am 06.04.22 um 22:30 schrieb Harald Anlauf via Fortran: > Dear all, > > the logic for checking the allocate-coshape-spec in an ALLOCATE > statement was sort of sideways, and allowed to pass invalid > specifications to the code generation. > > The fix seems obvious (to me). after submitting the previous patch, I found another invalid case with a missing lower bound which was still silently accepted. The attached revised patch adds this check, improves the original error message to actually point to the coarray specification, and renames the testcase to align better with existing coarray testcases. > Regtested on x86_64-pc-linux-gnu. OK for mainline? > (12 or wait for 13?). Regtested again with no new failures. OK for mainline? Thanks, Harald --------------xbjJXChCMlhcjexzjtNPx46r Content-Type: text/x-patch; charset=UTF-8; name="0001-Fortran-fix-checking-of-coshape-specification-in-ALL.patch" Content-Disposition: attachment; filename*0="0001-Fortran-fix-checking-of-coshape-specification-in-ALL.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA0ODNjYmY5OTQyZGNmY2Y3NGE5MTIzMTJkYmJjZGEyZjEwODIwMGVhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIYXJhbGQgQW5sYXVmIDxhbmxhdWZAZ214LmRlPgpE YXRlOiBXZWQsIDYgQXByIDIwMjIgMjI6MjQ6MjEgKzAyMDAKU3ViamVjdDogW1BBVENIXSBG b3J0cmFuOiBmaXggY2hlY2tpbmcgb2YgY29zaGFwZSBzcGVjaWZpY2F0aW9uIGluIEFMTE9D QVRFCiBzdGF0ZW1lbnQKCmdjYy9mb3J0cmFuL0NoYW5nZUxvZzoKCglQUiBmb3J0cmFuLzEw NTE4NAoJKiBhcnJheS5jYyAobWF0Y2hfc3Vic2NyaXB0KTogUmVqZWN0IGFzc3VtZWQgc2l6 ZSBjb2FycmF5CglzcGVjaWZpY2F0aW9uIHdpdGggbWlzc2luZyBsb3dlciBib3VuZC4KCSog cmVzb2x2ZS5jYyAocmVzb2x2ZV9hbGxvY2F0ZV9leHByKTogRml4IGxvZ2ljIGZvciBjaGVj a2luZwoJYWxsb2NhdGUtY29zaGFwZS1zcGVjIGluIEFMTE9DQVRFIHN0YXRlbWVudC4KCmdj Yy90ZXN0c3VpdGUvQ2hhbmdlTG9nOgoKCVBSIGZvcnRyYW4vMTA1MTg0CgkqIGdmb3J0cmFu LmRnL2NvYXJyYXlfNDQuZjkwOiBBZGp1c3QgZXhwZWN0ZWQgb3V0cHV0LgoJKiBnZm9ydHJh bi5kZy9jb2FycmF5X2FsbG9jYXRlXzExLmY5MDogTGlrZXdpc2UuCgkqIGdmb3J0cmFuLmRn L2NvYXJyYXlfYWxsb2NhdGVfMTIuZjkwOiBOZXcgdGVzdC4KLS0tCiBnY2MvZm9ydHJhbi9h cnJheS5jYyAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgNyArKysrKysrCiBnY2MvZm9y dHJhbi9yZXNvbHZlLmNjICAgICAgICAgICAgICAgICAgICAgICAgfCAxMSArKysrKystLS0t LQogZ2NjL3Rlc3RzdWl0ZS9nZm9ydHJhbi5kZy9jb2FycmF5XzQ0LmY5MCAgICAgIHwgIDIg KysKIC4uLi9nZm9ydHJhbi5kZy9jb2FycmF5X2FsbG9jYXRlXzExLmY5MCAgICAgICB8ICA2 ICsrKy0tLQogLi4uL2dmb3J0cmFuLmRnL2NvYXJyYXlfYWxsb2NhdGVfMTIuZjkwICAgICAg IHwgMTkgKysrKysrKysrKysrKysrKysrKwogNSBmaWxlcyBjaGFuZ2VkLCAzNyBpbnNlcnRp b25zKCspLCA4IGRlbGV0aW9ucygtKQogY3JlYXRlIG1vZGUgMTAwNjQ0IGdjYy90ZXN0c3Vp dGUvZ2ZvcnRyYW4uZGcvY29hcnJheV9hbGxvY2F0ZV8xMi5mOTAKCmRpZmYgLS1naXQgYS9n Y2MvZm9ydHJhbi9hcnJheS5jYyBiL2djYy9mb3J0cmFuL2FycmF5LmNjCmluZGV4IGViOWVk ODU4MGEwLi45MGVhODEyZDY5OSAxMDA2NDQKLS0tIGEvZ2NjL2ZvcnRyYW4vYXJyYXkuY2MK KysrIGIvZ2NjL2ZvcnRyYW4vYXJyYXkuY2MKQEAgLTEzNCw2ICsxMzQsMTMgQEAgZW5kX2Vs ZW1lbnQ6CiAgIGlmIChtID09IE1BVENIX0VSUk9SKQogICAgIHJldHVybiBNQVRDSF9FUlJP UjsKIAorICBpZiAoc3RhciAmJiBhci0+c3RhcnRbaV0gPT0gTlVMTCkKKyAgICB7CisgICAg ICBnZmNfZXJyb3IgKCJNaXNzaW5nIGxvd2VyIGJvdW5kIGluIGFzc3VtZWQgc2l6ZSAiCisJ CSAiY29hcnJheSBzcGVjaWZpY2F0aW9uIGF0ICVDIik7CisgICAgICByZXR1cm4gTUFUQ0hf RVJST1I7CisgICAgfQorCiAgIC8qIFNlZSBpZiB3ZSBoYXZlIGFuIG9wdGlvbmFsIHN0cmlk ZS4gICovCiAgIGlmIChnZmNfbWF0Y2hfY2hhciAoJzonKSA9PSBNQVRDSF9ZRVMpCiAgICAg ewpkaWZmIC0tZ2l0IGEvZ2NjL2ZvcnRyYW4vcmVzb2x2ZS5jYyBiL2djYy9mb3J0cmFuL3Jl c29sdmUuY2MKaW5kZXggMjFjODc5N2M5MzguLjA1ZjhmMWJmNmMyIDEwMDY0NAotLS0gYS9n Y2MvZm9ydHJhbi9yZXNvbHZlLmNjCisrKyBiL2djYy9mb3J0cmFuL3Jlc29sdmUuY2MKQEAg LTgxMDgsMTIgKzgxMDgsMTMgQEAgcmVzb2x2ZV9hbGxvY2F0ZV9leHByIChnZmNfZXhwciAq ZSwgZ2ZjX2NvZGUgKmNvZGUsIGJvb2wgKmFycmF5X2FsbG9jX3dvX3NwZWMpCiAJICAgIGdv dG8gZmFpbHVyZTsKIAogCSAgY2FzZSAgRElNRU5fUkFOR0U6Ci0JICAgIGlmIChhci0+c3Rh cnRbaV0gPT0gMCB8fCBhci0+ZW5kW2ldID09IDApCisJICAgIC8qIEYyMDE4OlI5Mzc6CisJ ICAgICAqIGFsbG9jYXRlLWNvc2hhcGUtc3BlYyBpcyBbIGxvd2VyLWJvdW5kLWV4cHIgOiBd IHVwcGVyLWJvdW5kLWV4cHIKKwkgICAgICovCisJICAgIGlmIChhci0+c3RhcnRbaV0gPT0g MCB8fCBhci0+ZW5kW2ldID09IDAgfHwgYXItPnN0cmlkZVtpXSAhPSBOVUxMKQogCSAgICAg IHsKLQkJLyogSWYgYXItPnN0cmlkZVtpXSBpcyBOVUxMLCB3ZSBpc3N1ZWQgYSBwcmV2aW91 cyBlcnJvci4gICovCi0JCWlmIChhci0+c3RyaWRlW2ldID09IE5VTEwpCi0JCSAgZ2ZjX2Vy cm9yICgiQmFkIGFycmF5IHNwZWNpZmljYXRpb24gaW4gQUxMT0NBVEUgc3RhdGVtZW50ICIK LQkJCSAgICAgImF0ICVMIiwgJmUtPndoZXJlKTsKKwkJZ2ZjX2Vycm9yICgiQmFkIGNvYXJy YXkgc3BlY2lmaWNhdGlvbiBpbiBBTExPQ0FURSBzdGF0ZW1lbnQgIgorCQkJICAgImF0ICVM IiwgJmUtPndoZXJlKTsKIAkJZ290byBmYWlsdXJlOwogCSAgICAgIH0KIAkgICAgZWxzZSBp ZiAoZ2ZjX2RlcF9jb21wYXJlX2V4cHIgKGFyLT5zdGFydFtpXSwgYXItPmVuZFtpXSkgPT0g MSkKZGlmZiAtLWdpdCBhL2djYy90ZXN0c3VpdGUvZ2ZvcnRyYW4uZGcvY29hcnJheV80NC5m OTAgYi9nY2MvdGVzdHN1aXRlL2dmb3J0cmFuLmRnL2NvYXJyYXlfNDQuZjkwCmluZGV4IDE1 ZmI4Yzc2Y2U0Li41NDViNTQ2MjI1MSAxMDA2NDQKLS0tIGEvZ2NjL3Rlc3RzdWl0ZS9nZm9y dHJhbi5kZy9jb2FycmF5XzQ0LmY5MAorKysgYi9nY2MvdGVzdHN1aXRlL2dmb3J0cmFuLmRn L2NvYXJyYXlfNDQuZjkwCkBAIC0xMCwzICsxMCw1IEBAIHByb2dyYW0gcHI3MDA3MQogICBh bGxvY2F0ZSAoeigyKVsxOjoyLCpdKSAgISB7IGRnLWVycm9yICJCYWQgYXJyYXkgZGltZW5z aW9uIiB9CiAgIGFsbG9jYXRlICh6KDE6OjIpWzIsKl0pICAhIHsgZGctZXJyb3IgIkJhZCBh cnJheSBzcGVjaWZpY2F0aW9uIGluIEFMTE9DQVRFIiB9CiBlbmQgcHJvZ3JhbSBwcjcwMDcx CisKKyEgeyBkZy1wcnVuZS1vdXRwdXQgIkJhZCBjb2FycmF5IHNwZWNpZmljYXRpb24gaW4g QUxMT0NBVEUgc3RhdGVtZW50IiB9CmRpZmYgLS1naXQgYS9nY2MvdGVzdHN1aXRlL2dmb3J0 cmFuLmRnL2NvYXJyYXlfYWxsb2NhdGVfMTEuZjkwIGIvZ2NjL3Rlc3RzdWl0ZS9nZm9ydHJh bi5kZy9jb2FycmF5X2FsbG9jYXRlXzExLmY5MAppbmRleCAwZTgwNmYwOTU1Yi4uMGU0ZjY0 ZTFlM2QgMTAwNjQ0Ci0tLSBhL2djYy90ZXN0c3VpdGUvZ2ZvcnRyYW4uZGcvY29hcnJheV9h bGxvY2F0ZV8xMS5mOTAKKysrIGIvZ2NjL3Rlc3RzdWl0ZS9nZm9ydHJhbi5kZy9jb2FycmF5 X2FsbG9jYXRlXzExLmY5MApAQCAtMywxMCArMywxMCBAQAogcHJvZ3JhbSBwCiAgICBpbnRl Z2VyLCBhbGxvY2F0YWJsZSA6OiB6WzosOl0KICAgIGludGVnZXIgOjogaQotICAgYWxsb2Nh dGUgKHpbMTosKl0pICEgeyBkZy1lcnJvciAiQmFkIGFycmF5IHNwZWNpZmljYXRpb24gaW4g QUxMT0NBVEUgc3RhdGVtZW50IiB9Ci0gICBhbGxvY2F0ZSAoels6MiwqXSkgISB7IGRnLWVy cm9yICJCYWQgYXJyYXkgc3BlY2lmaWNhdGlvbiBpbiBBTExPQ0FURSBzdGF0ZW1lbnQiIH0K KyAgIGFsbG9jYXRlICh6WzE6LCpdKSAhIHsgZGctZXJyb3IgIkJhZCBjb2FycmF5IHNwZWNp ZmljYXRpb24gaW4gQUxMT0NBVEUgc3RhdGVtZW50IiB9CisgICBhbGxvY2F0ZSAoels6Miwq XSkgISB7IGRnLWVycm9yICJCYWQgY29hcnJheSBzcGVjaWZpY2F0aW9uIGluIEFMTE9DQVRF IHN0YXRlbWVudCIgfQogICAgYWxsb2NhdGUgKHpbMjoxLCpdKSAhIHsgZGctZXJyb3IgIlVw cGVyIGNvYm91bmQgaXMgbGVzcyB0aGFuIGxvd2VyIGNvYm91bmQiIH0KLSAgIGFsbG9jYXRl ICh6WzowLCpdKSAhIHsgZGctZXJyb3IgIkJhZCBhcnJheSBzcGVjaWZpY2F0aW9uIGluIEFM TE9DQVRFIHN0YXRlbWVudCIgfQorICAgYWxsb2NhdGUgKHpbOjAsKl0pICEgeyBkZy1lcnJv ciAiQmFkIGNvYXJyYXkgc3BlY2lmaWNhdGlvbiBpbiBBTExPQ0FURSBzdGF0ZW1lbnQiIH0K ICAgIGFsbG9jYXRlICh6WzAsKl0pICEgeyBkZy1lcnJvciAiVXBwZXIgY29ib3VuZCBpcyBs ZXNzIHRoYW4gbG93ZXIgY29ib3VuZCIgfQogICAgYWxsb2NhdGUgKHpbMSwqXSkgISBUaGlz IGlzIE9LCiAgICBhbGxvY2F0ZSAoelsxOjEsKl0pICEgVGhpcyBpcyBPSwpkaWZmIC0tZ2l0 IGEvZ2NjL3Rlc3RzdWl0ZS9nZm9ydHJhbi5kZy9jb2FycmF5X2FsbG9jYXRlXzEyLmY5MCBi L2djYy90ZXN0c3VpdGUvZ2ZvcnRyYW4uZGcvY29hcnJheV9hbGxvY2F0ZV8xMi5mOTAKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAuLjIxNjlhYTE5OTk4Ci0tLSAv ZGV2L251bGwKKysrIGIvZ2NjL3Rlc3RzdWl0ZS9nZm9ydHJhbi5kZy9jb2FycmF5X2FsbG9j YXRlXzEyLmY5MApAQCAtMCwwICsxLDE5IEBACishIHsgZGctZG8gY29tcGlsZSB9CishIHsg ZGctb3B0aW9ucyAiLWZjb2FycmF5PXNpbmdsZSIgfQorIQorISBQUiBmb3J0cmFuLzEwNTE4 NAorISBCYXNlZCBvbiB0ZXN0Y2FzZXMgYnkgR2VyaGFyZCBTdGVpbm1ldHoKKworcHJvZ3Jh bSBwCisgIHJlYWwsIGFsbG9jYXRhYmxlIDo6IHhbOiw6XQorICBpbnRlZ2VyIDo6IG4gPSAy CisgIGFsbG9jYXRlICh4WyAgbiwgKl0pCisgIGFsbG9jYXRlICh4WzE6biwgKl0pCisgIGFs bG9jYXRlICh4W246biwgKl0pCisgIGFsbG9jYXRlICh4W24sIDU6Kl0pCisgIGFsbG9jYXRl ICh4WyA6biwgICAqXSkgISB7IGRnLWVycm9yICJCYWQgY29hcnJheSBzcGVjaWZpY2F0aW9u IiB9CisgIGFsbG9jYXRlICh4Wzo6biwgICAqXSkgISB7IGRnLWVycm9yICJCYWQgY29hcnJh eSBzcGVjaWZpY2F0aW9uIiB9CisgIGFsbG9jYXRlICh4WyA6MToxLCAqXSkgISB7IGRnLWVy cm9yICJCYWQgY29hcnJheSBzcGVjaWZpY2F0aW9uIiB9CisgIGFsbG9jYXRlICh4WzE6bjpu LCAqXSkgISB7IGRnLWVycm9yICJCYWQgY29hcnJheSBzcGVjaWZpY2F0aW9uIiB9CisgIGFs bG9jYXRlICh4WzEsICAgOiAqXSkgISB7IGRnLWVycm9yICJNaXNzaW5nIGxvd2VyIGJvdW5k IiB9CitlbmQKLS0gCjIuMzQuMQoK --------------xbjJXChCMlhcjexzjtNPx46r--