From: Hans-Peter Nilsson <hp@axis.com>
To: <morin-mikael@orange.fr>
Cc: <mikael@gcc.gnu.org>, Thomas Koenig <tkoenig@netcologne.de>,
<gcc-patches@gcc.gnu.org>, <fortran@gcc.gnu.org>,
<stefansf@linux.ibm.com>
Subject: Re: *PING* [PATCH 0/4] Use pointer arithmetic for array references [PR102043]
Date: Tue, 26 Apr 2022 16:40:33 +0200 [thread overview]
Message-ID: <20220426144033.723E720430@pchp3.se.axis.com> (raw)
In-Reply-To: <daf30a34-2bf6-51d4-6088-cb113b247403@netcologne.de> (message from Thomas Koenig via Gcc-patches on Fri, 22 Apr 2022 15:59:45 +0200)
> From: Thomas Koenig via Gcc-patches <gcc-patches@gcc.gnu.org>
> Date: Fri, 22 Apr 2022 15:59:45 +0200
> Hi Mikael,
>
> > Ping for the four patches starting at
> > https://gcc.gnu.org/pipermail/fortran/2022-April/057759.html :
> > https://gcc.gnu.org/pipermail/fortran/2022-April/057757.html
> > https://gcc.gnu.org/pipermail/fortran/2022-April/057760.html
> > https://gcc.gnu.org/pipermail/fortran/2022-April/057758.html
> > https://gcc.gnu.org/pipermail/fortran/2022-April/057761.html
> >
> > Richi accepted the general direction and the middle-end interaction.
> > I need a fortran frontend ack as well.
>
> Looks good to me.
>
> Thanks a lot for taking this on! This would have been a serious
> regression if released with gcc 12.
>
> Best regards
>
> Thomas
These, or specifically r12-8227-g89ca0fffa48b79, "fortran:
Pre-evaluate string pointers. [PR102043]" have further
exposed (the issue existed before but now fails for more
platforms) PR78054 "gfortran.dg/pr70673.f90 FAILs at -O0",
at least for cris-elf and apparently also
s390x-ibm-linux-gnu.
In the PR it is mentioned that running the test through
valgrind shows invalid accesses also on x86_64-linux-gnu.
Could it be that the test-case is invalid and has undefined
behavior? I don't know fortran so I can't tell.
That exact commit causing a regression for s390x is somewhat
an assumption based on posted date and testresults, as the
s390x results don't include a git version. (@Stefansf: I'm
referring to
https://gcc.gnu.org/pipermail/gcc-testresults/2022-April/760060.html
https://gcc.gnu.org/pipermail/gcc-testresults/2022-April/760137.html
Perhaps that tester isn't using the contrib/gcc_update and
contrib/test_summary scripts, thus no LAST_UPDATED
included?)
brgds, H-P
next prev parent reply other threads:[~2022-04-26 14:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-16 16:56 Mikael Morin
2022-04-16 16:56 ` [PATCH 1/4] fortran: Pre-evaluate string pointers. [PR102043] Mikael Morin
2022-04-16 16:56 ` [PATCH 2/4] fortran: Update index extraction code. [PR102043] Mikael Morin
2022-04-16 16:56 ` [PATCH 3/4] fortran: Generate an array temporary reference [PR102043] Mikael Morin
2022-04-16 16:56 ` [PATCH 4/4] fortran: Use pointer arithmetic to index arrays [PR102043] Mikael Morin
2022-04-19 15:05 ` [PATCH 0/4] Use pointer arithmetic for array references [PR102043] Richard Biener
2022-04-22 11:09 ` *PING* " Mikael Morin
2022-04-22 13:59 ` Thomas Koenig
2022-04-24 1:57 ` Jerry D
2022-04-26 14:40 ` Hans-Peter Nilsson [this message]
2022-04-27 5:48 ` Thomas Koenig
2022-05-02 7:16 ` Stefan Schulze Frielinghaus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220426144033.723E720430@pchp3.se.axis.com \
--to=hp@axis.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=mikael@gcc.gnu.org \
--cc=morin-mikael@orange.fr \
--cc=stefansf@linux.ibm.com \
--cc=tkoenig@netcologne.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).