From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by sourceware.org (Postfix) with ESMTPS id 43994384F025; Fri, 24 Jun 2022 11:13:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 43994384F025 Received: by mail-ed1-x52a.google.com with SMTP id o10so3006972edi.1; Fri, 24 Jun 2022 04:13:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cQ+fORL6Ss8HPM1vRs/tfyHsK634jj5XyChP4jnCrNA=; b=Om1Wwzkh3z/sANaCv4GMTc/Z5vlpeujOFbpVlkIFUMxgV2YVLk/oxYZfHkYF2jBAbZ vODXFAO4riuQmpAoGQ+oC8Dfcyu/fw5w+Nmzd3dDjQjw6lp7A34olYqpBQBN14ka6S2Q X/g8lkkc46NVXS1Ne21jKZHxjy3epfzNNfsd8i0c/LANSn3eRXRYCO4bJGGtMY8hrUdO dl5Ho/byrzYhKwB3jIdFLhf/dqTTxub+1aUnWhX1LU0Utpy6zd1EogQA2LYHGvJW3zjc B+IfAgxwNSNkaGSriDSB5m4HPUFD7Hh78CMQWIcz53hsiaBytWAzF+LyR5iKtYQnX9Hs XhfQ== X-Gm-Message-State: AJIora8cospS7HmLG+/Ty98B0lvGihaoSK/MGkwCdzQr4ttlboBegVVR asKTlKNN6z/J2rBPu+nW+dk= X-Google-Smtp-Source: AGRyM1vZRLMIDD6sTN9XQsAYQ6HdHDKo6b9+F4KukgWfeGuXG4GIvKrT2q+85Pl5j3YmPuK/HrBSXA== X-Received: by 2002:a05:6402:31f6:b0:435:5a08:d5e0 with SMTP id dy22-20020a05640231f600b004355a08d5e0mr16893779edb.308.1656069214992; Fri, 24 Jun 2022 04:13:34 -0700 (PDT) Received: from nbbrfq (80-110-214-113.static.upcbusiness.at. [80.110.214.113]) by smtp.gmail.com with ESMTPSA id z23-20020a170906435700b007094f98788csm933194ejm.113.2022.06.24.04.13.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jun 2022 04:13:34 -0700 (PDT) Date: Fri, 24 Jun 2022 13:13:31 +0200 From: Bernhard Reutner-Fischer To: Xi Ruoyao via Gcc-patches Cc: rep.dot.nop@gmail.com, Xi Ruoyao , fortran@gcc.gnu.org Subject: Re: [PATCH 6/8] fortran: use grep -F instead of fgrep Message-ID: <20220624131331.0b157480@nbbrfq> In-Reply-To: <3fe5664607c4e530fbb91048c2e363ddee917250.camel@xry111.site> References: <74ea0c62ebe19db186263053e4051f81d46e9da4.camel@xry111.site> <3fe5664607c4e530fbb91048c2e363ddee917250.camel@xry111.site> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jun 2022 11:13:39 -0000 On Fri, 24 Jun 2022 15:06:32 +0800 Xi Ruoyao via Gcc-patches wrote: > fgrep has been deprecated in favor of grep -F for a long time, and the > next grep release (3.8 or 4.0) will print a warning of fgrep is used. > Stop using fgrep so we won't see the warning. > > gcc/ChangeLog: > > * fortran/Make-lang.in: Use grep -F instead of fgrep. > --- > gcc/fortran/Make-lang.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/fortran/Make-lang.in b/gcc/fortran/Make-lang.in > index 1cb47cb1a52..51279b03aad 100644 > --- a/gcc/fortran/Make-lang.in > +++ b/gcc/fortran/Make-lang.in > @@ -278,7 +278,7 @@ $(DESTDIR)$(man1dir)/$(GFORTRAN_INSTALL_NAME)$(man1ext): doc/gfortran.1 \ > -chmod a-x $@ > > fortran.uninstall: > - if $(SHELL) -c 'install-info --version | sed 1q | fgrep -s -v -i debian' >/dev/null 2>&1; then \ > + if $(SHELL) -c 'install-info --version | sed 1q | grep -F -s -v -i debian' >/dev/null 2>&1; then \ > echo " install-info --delete --info-dir=$(DESTDIR)$(infodir) $(DESTDIR)$(infodir)/gfortran.info"; \ > install-info --delete --info-dir=$(DESTDIR)$(infodir) $(DESTDIR)$(infodir)/gfortran.info || : ; \ > else : ; fi; \ I'd replace -s >/dev/null 2>&1 with -q while at it. But why is -F used here in the first place? I do not see much in debian that can be interpreted as a regex? thanks,