From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by sourceware.org (Postfix) with ESMTPS id DC8473856964; Tue, 12 Jul 2022 18:23:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DC8473856964 X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.178.29] ([79.251.13.2]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MWRVh-1o51A71S4R-00Xv0t; Tue, 12 Jul 2022 20:23:48 +0200 Message-ID: <3b9de2bf-a196-d7ee-cef3-a4afd2b18866@gmx.de> Date: Tue, 12 Jul 2022 20:23:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] Fortran: error recovery simplifying PACK with invalid arguments [PR106049] Content-Language: en-US To: fortran , gcc-patches Newsgroups: gmane.comp.gcc.fortran,gmane.comp.gcc.patches References: From: Harald Anlauf In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:IWQ526DkEn2YF7eNMSe9ObWs1LJ8KzTETy2vK+IoovdfF4dEjqq 0prRrOncedk2exFr6/EO6LgkyKZGFeBeQYf3xxqOZiN9i7bcC8zYgMsEgAmQLiMGS97XnvT okEbee8u7VpIXBwSvRvFe6MiekvYWl+R/gJwU465BUx4+QiC1e/Pqoc/83WhDE4iC3mYVVS 6wrWMFyuqP84MIz5R6W2w== X-UI-Out-Filterresults: notjunk:1;V03:K0:a1uUzGdvev0=:UFIaGbPb4g2lcXAb5jqGiR aZJWcCKcJdN3iyv2a1XygUjAAe61iXwn5qsR7jIMHcF8UzOP/SMMnKhy9m4nAhiR+b6v+wc8J zOXJhUv3FIV+GcesxGXfkZFer9q/GdPgqQk+aT5xoH1Pdr+43jmTJROVgbktOyM7tJGlgpbqK 9id9xhlDTiGiYqckN8ToDKT88G4a5LoZQKUNkzE8fllomBU5dJYVhDXf3Eq0DvVRSCvxO2g6t V6x1wTdv6ZVhkG9nPHKUwjazsmNTmWGoyo/c3q8gkoDpFgakN2smf20iIo22U7RXnlab83Wwe c+06Czf4EZjK+gEoEL3JLcrcxYFXE2ysBCV6Z59tChLPk8CC6EfkPts5lqCkczVo1uTZ+W95H oxCDDwMLNzhKXQbR13iNQPhQ0FT1hmyba5pSD1po06kL12eSlyfRTFwc/yRhxr9bmZ9QEA0c8 MygOfWsuAbl2sdPAXo0p3wdDx6wlvJUgWXXUNyu/vTyXOoxKTUVot1633n3hWGc67YgiinP6j cxyh+HkM/k6Xq/lntC8tiJIM1X3ocAnm9cRrMJpbNCnOVm/s+gaMvbTSbpSZrQFCdsnASrKsq MXmhTd19vnjKiXV2+LDYd+XFvCUDKK1929FmnFgpkEvmiQ53jR4KdrmnrL1cGGwKkTvqyrvU5 LfEjs/uPSIW65UkXoRVJZRh9kb7RdDVRNXFLtjhmvr7Ivl5uU7ppCzfk9ktrpsR2Rbpv8qYYZ H884tg+6VXlyrnHTxk5hfdN9zJ0GlTPcyQMZviz4yUD8SPWdCCepXisRs2KNpFs+A02+05dry JCPUhOHlycXsSAVypq0ZzvghwhmQF+JPbvyRxuAx9tySiWaWKY164HmteIFURy2n+pxpCNlAc JsmU+pV0PBA5pZbb5YThwBFsA2LIX8NJDyQrQ/rmKURdLOk0H6LVGax7XTBYi1oEMFaTKzk8m BXEXN/eoXtZCZpDpy5VSQSbJ+TkjwaaAVPGPs/lQtLVZNzyke45cdAiW6+m1XBCYdXsV6wtlL c+tCyb7C39dGSD+l7W1vC+rGzPj7ebxmaLvlZ6G0Zq9XtrHw5ciDiXu+qpgguTMr5mB7yxyYB mYiafIfDcffn7eF0yEmal78TuhCeCS5sUjC X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jul 2022 18:23:51 -0000 Message-ID: <20220712182336.1ZWh-WCeXNnFO4_snmqs0ScXpb5uWqoBzAGZsYJU_T8@z> As there were no comments, committed as r13-1650. Am 05.07.22 um 22:31 schrieb Harald Anlauf via Fortran: > Dear all, > > poor error recovery while trying to simplify intrinsics with given > invalid arguments seems to be a recurrent theme in testcases submitted > by Gerhard. In the present case, simplification of PACK() chokes on > the array argument being a bad decl. > > The most general approach that came to my mind is to modify function > is_constant_array_expr: when the declared shape of the array indicates > a size greater than zero, but the constructor is missing or empty, > then something bad may have happened, and the array cannot be > considered constant. We thus punt on simplification of something > that cannot be simplified. With some luck, this might prevent issues > in similar cases elsewhere... > > Regtested on x86_64-pc-linux-gnu. OK for mainline? > > Thanks, > Harald >