From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcgf-fortran@m.gmane-mx.org>
Received: from ciao.gmane.io (ciao.gmane.io [116.202.254.214])
 by sourceware.org (Postfix) with ESMTPS id CCB6A385840F
 for <fortran@gcc.gnu.org>; Sat, 30 Jul 2022 18:32:47 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CCB6A385840F
Received: from list by ciao.gmane.io with local (Exim 4.92)
 (envelope-from <gcgf-fortran@m.gmane-mx.org>) id 1oHrGY-00066W-CL
 for fortran@gcc.gnu.org; Sat, 30 Jul 2022 20:32:46 +0200
X-Injected-Via-Gmane: http://gmane.org/
To: fortran@gcc.gnu.org
From: Harald Anlauf <anlauf@gmx.de>
Subject: Re: [PATCH, v3] Fortran: detect blanks within literal constants in
 free-form mode [PR92805]
Date: Sat, 30 Jul 2022 20:32:38 +0200
Message-ID: <d9059a89-8a22-16ee-63e3-2b413eb8c3c1@gmx.de>
References: <trinity-182352dd-523c-42bc-a3d1-17d9b69c0432-1659039117168@3c-app-gmx-bap60>
 <fbc69384-d5db-6a37-9ee0-477e61cf3933@orange.fr>
 <adec596c-edb1-462a-1f2b-a8d1ff7071f5@gmx.de>
 <46cc765d-469e-d6e8-23c5-dc470028d881@orange.fr>
 <fc72cd92-3f37-6d0f-30ac-0d93584524e4@gmx.de>
 <fda1ad07-970a-6f85-d081-8cabf5ef137d@netcologne.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Content-Language: en-US
In-Reply-To: <fda1ad07-970a-6f85-d081-8cabf5ef137d@netcologne.de>
Cc: gcc-patches@gcc.gnu.org
X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00, BODY_8BITS,
 FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,
 KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: fortran@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Fortran mailing list <fortran.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/fortran>,
 <mailto:fortran-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/fortran/>
List-Help: <mailto:fortran-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/fortran>,
 <mailto:fortran-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 30 Jul 2022 18:32:49 -0000
Message-ID: <20220730183238.v2J_kVe40aOBtOqcxH5zEdO82GS5VqDyp2_CQj-V9Cs@z>

Hi Thomas,

Am 30.07.22 um 09:46 schrieb Thomas Koenig via Fortran:
> 
> Hi Harald,
> 
>> This introduces the helper function gfc_match_next_char, which is
>> your second option.
> 
> I would be a little bit concerned about compilation times
> with the additional function call overhead.

the function it replaces (gfc_match_char) is also in a different
file, thus the overhead is at least neutral.  Given that the latter
has an additional call to gfc_gobble_whitespace(), we actually get
better...

> The function is used only in one place; would it make
> sense to put it into primary.cc and declare it static?

Can do that.

> Best regards
> 
>      Thomas
> 

Thanks,
Harald