From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ciao.gmane.io (ciao.gmane.io [116.202.254.214]) by sourceware.org (Postfix) with ESMTPS id 536C13858C56 for ; Tue, 18 Oct 2022 20:48:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 536C13858C56 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=m.gmane-mx.org Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1oktVQ-00071z-Ui for fortran@gcc.gnu.org; Tue, 18 Oct 2022 22:48:08 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: fortran@gcc.gnu.org From: Harald Anlauf Subject: Re: Proxy ping [PATCH] Fortran: Add missing TKR initialization to class variables [PR100097, PR100098] Date: Tue, 18 Oct 2022 22:48:02 +0200 Message-ID: <1d2bbc40-fe52-79d5-c2db-39d27eca212c@gmx.de> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------Z5xuwWtGWpRs1AFOSo70O2As" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Content-Language: en-US In-Reply-To: Cc: gcc-patches@gcc.gnu.org X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,KAM_SHORT,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Message-ID: <20221018204802.gyNkEV05XkDORR30Gj8XV7RKccr-N4JhRkZ3SCgQqBs@z> This is a multi-part message in MIME format. --------------Z5xuwWtGWpRs1AFOSo70O2As Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit I intended to add the updated patch but forgot, so here it is... Am 18.10.22 um 22:41 schrieb Harald Anlauf via Fortran: > Dear all, > > Jose posted a patch here that was never reviewed: > > https://gcc.gnu.org/pipermail/fortran/2021-April/055933.html > > I could not find any issues with his patch, it works as advertised > and fixes the reported problem. > > As his testcases did not reliably fail without the patch but rather > randomly due to the uninitialized descriptor, I added a check of > the tree-dumps to verify that the TKR initializer is generated. > > Does anybody else have any comments? > > Regtested on x86_64-pc-linux-gnu. OK for mainline? > > Thanks, > Harald > > > --------------Z5xuwWtGWpRs1AFOSo70O2As Content-Type: text/x-patch; charset=UTF-8; name="pr100098.diff" Content-Disposition: attachment; filename="pr100098.diff" Content-Transfer-Encoding: base64 RnJvbSA4ZDM2NGFjZjMzZjI3MjYyZWY1OTI5YTNjOGQ1MDRlZDZkZjBmOTQzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Sm9zPUMzPUE5PTIwUnVpPTIwRmF1 c3Rpbm89MjBkZT0yMFNvdXNhPz0KIDxqcmZzb3VzYUBnbWFpbC5jb20+CkRhdGU6IFR1ZSwg MTggT2N0IDIwMjIgMjI6Mjk6NTkgKzAyMDAKU3ViamVjdDogW1BBVENIXSBGb3J0cmFuOiBB ZGQgbWlzc2luZyBUS1IgaW5pdGlhbGl6YXRpb24gdG8gY2xhc3MgdmFyaWFibGVzCiBbUFIx MDAwOTcsIFBSMTAwMDk4XQoKZ2NjL2ZvcnRyYW4vQ2hhbmdlTG9nOgoKCVBSIGZvcnRyYW4v MTAwMDk3CglQUiBmb3J0cmFuLzEwMDA5OAoJKiB0cmFucy1hcnJheS5jYyAoZ2ZjX3RyYW5z X2NsYXNzX2FycmF5KTogTmV3IGZ1bmN0aW9uIHRvCglpbml0aWFsaXplIGNsYXNzIGRlc2Ny aXB0b3IncyBUS1IgaW5mb3JtYXRpb24uCgkqIHRyYW5zLWFycmF5LmggKGdmY190cmFuc19j bGFzc19hcnJheSk6IEFkZCBmdW5jdGlvbiBwcm90b3R5cGUuCgkqIHRyYW5zLWRlY2wuY2Mg KGdmY190cmFuc19kZWZlcnJlZF92YXJzKTogQWRkIGNhbGxzIHRvIHRoZSBuZXcKCWZ1bmN0 aW9uIGZvciBib3RoIHBvaW50ZXJzIGFuZCBhbGxvY2F0YWJsZXMuCgpnY2MvdGVzdHN1aXRl L0NoYW5nZUxvZzoKCglQUiBmb3J0cmFuLzEwMDA5NwoJUFIgZm9ydHJhbi8xMDAwOTgKCSog Z2ZvcnRyYW4uZGcvUFIxMDAwOTcuZjkwOiBOZXcgdGVzdC4KCSogZ2ZvcnRyYW4uZGcvUFIx MDAwOTguZjkwOiBOZXcgdGVzdC4KLS0tCiBnY2MvZm9ydHJhbi90cmFucy1hcnJheS5jYyAg ICAgICAgICAgICB8IDQ2ICsrKysrKysrKysrKysrKysrKysrKysrKysrCiBnY2MvZm9ydHJh bi90cmFucy1hcnJheS5oICAgICAgICAgICAgICB8ICAyICsrCiBnY2MvZm9ydHJhbi90cmFu cy1kZWNsLmNjICAgICAgICAgICAgICB8ICA2ICsrKy0KIGdjYy90ZXN0c3VpdGUvZ2ZvcnRy YW4uZGcvUFIxMDAwOTcuZjkwIHwgNDEgKysrKysrKysrKysrKysrKysrKysrKysKIGdjYy90 ZXN0c3VpdGUvZ2ZvcnRyYW4uZGcvUFIxMDAwOTguZjkwIHwgNDUgKysrKysrKysrKysrKysr KysrKysrKysrKwogNSBmaWxlcyBjaGFuZ2VkLCAxMzkgaW5zZXJ0aW9ucygrKSwgMSBkZWxl dGlvbigtKQogY3JlYXRlIG1vZGUgMTAwNjQ0IGdjYy90ZXN0c3VpdGUvZ2ZvcnRyYW4uZGcv UFIxMDAwOTcuZjkwCiBjcmVhdGUgbW9kZSAxMDA2NDQgZ2NjL3Rlc3RzdWl0ZS9nZm9ydHJh bi5kZy9QUjEwMDA5OC5mOTAKCmRpZmYgLS1naXQgYS9nY2MvZm9ydHJhbi90cmFucy1hcnJh eS5jYyBiL2djYy9mb3J0cmFuL3RyYW5zLWFycmF5LmNjCmluZGV4IDc5NWNlMTRhZjA4Li41 MTRjYjA1N2FmYiAxMDA2NDQKLS0tIGEvZ2NjL2ZvcnRyYW4vdHJhbnMtYXJyYXkuY2MKKysr IGIvZ2NjL2ZvcnRyYW4vdHJhbnMtYXJyYXkuY2MKQEAgLTExMTI1LDYgKzExMTI1LDUyIEBA IGdmY19hbGxvY19hbGxvY2F0YWJsZV9mb3JfYXNzaWdubWVudCAoZ2ZjX2xvb3BpbmZvICps b29wLAogfQogCiAKKy8qIEluaXRpYWxpemUgY2xhc3MgZGVzY3JpcHRvcidzIFRLUiBpbmZv bWF0aW9uLiAgKi8KKwordm9pZAorZ2ZjX3RyYW5zX2NsYXNzX2FycmF5IChnZmNfc3ltYm9s ICogc3ltLCBnZmNfd3JhcHBlZF9ibG9jayAqIGJsb2NrKQoreworICB0cmVlIHR5cGUsIGV0 eXBlOworICB0cmVlIHRtcDsKKyAgdHJlZSBkZXNjcmlwdG9yOworICBzdG10YmxvY2tfdCBp bml0OworICBsb2N1cyBsb2M7CisgIGludCByYW5rOworCisgIC8qIE1ha2Ugc3VyZSB0aGUg ZnJvbnRlbmQgZ2V0cyB0aGVzZSByaWdodC4gICovCisgIGdjY19hc3NlcnQgKHN5bS0+dHMu dHlwZSA9PSBCVF9DTEFTUyAmJiBDTEFTU19EQVRBIChzeW0pCisJICAgICAgJiYgKENMQVNT X0RBVEEgKHN5bSktPmF0dHIuY2xhc3NfcG9pbnRlcgorCQkgIHx8IENMQVNTX0RBVEEgKHN5 bSktPmF0dHIuYWxsb2NhdGFibGUpKTsKKworICBnY2NfYXNzZXJ0IChWQVJfUCAoc3ltLT5i YWNrZW5kX2RlY2wpCisJICAgICAgfHwgVFJFRV9DT0RFIChzeW0tPmJhY2tlbmRfZGVjbCkg PT0gUEFSTV9ERUNMKTsKKworICBpZiAoc3ltLT5hdHRyLmR1bW15KQorICAgIHJldHVybjsK KworICBkZXNjcmlwdG9yID0gZ2ZjX2NsYXNzX2RhdGFfZ2V0IChzeW0tPmJhY2tlbmRfZGVj bCk7CisgIHR5cGUgPSBUUkVFX1RZUEUgKGRlc2NyaXB0b3IpOworCisgIGlmICh0eXBlID09 IE5VTEwgfHwgIUdGQ19ERVNDUklQVE9SX1RZUEVfUCAodHlwZSkpCisgICAgcmV0dXJuOwor CisgIGdmY19zYXZlX2JhY2tlbmRfbG9jdXMgKCZsb2MpOworICBnZmNfc2V0X2JhY2tlbmRf bG9jdXMgKCZzeW0tPmRlY2xhcmVkX2F0KTsKKyAgZ2ZjX2luaXRfYmxvY2sgKCZpbml0KTsK KworICByYW5rID0gQ0xBU1NfREFUQSAoc3ltKS0+YXMgPyAoQ0xBU1NfREFUQSAoc3ltKS0+ YXMtPnJhbmspIDogKDApOworICBnY2NfYXNzZXJ0IChyYW5rPj0wKTsKKyAgdG1wID0gZ2Zj X2NvbnZfZGVzY3JpcHRvcl9kdHlwZSAoZGVzY3JpcHRvcik7CisgIGV0eXBlID0gZ2ZjX2dl dF9lbGVtZW50X3R5cGUgKHR5cGUpOworICB0bXAgPSBmb2xkX2J1aWxkMl9sb2MgKGlucHV0 X2xvY2F0aW9uLCBNT0RJRllfRVhQUiwgVFJFRV9UWVBFICh0bXApLCB0bXAsCisJCQkgZ2Zj X2dldF9kdHlwZV9yYW5rX3R5cGUgKHJhbmssIGV0eXBlKSk7CisgIGdmY19hZGRfZXhwcl90 b19ibG9jayAoJmluaXQsIHRtcCk7CisKKyAgZ2ZjX2FkZF9pbml0X2NsZWFudXAgKGJsb2Nr LCBnZmNfZmluaXNoX2Jsb2NrICgmaW5pdCksIE5VTExfVFJFRSk7CisgIGdmY19yZXN0b3Jl X2JhY2tlbmRfbG9jdXMgKCZsb2MpOworfQorCisKIC8qIE5VTExJRlkgYW4gYWxsb2NhdGFi bGUvcG9pbnRlciBhcnJheSBvbiBmdW5jdGlvbiBlbnRyeSwgZnJlZSBpdCBvbiBleGl0Lgog ICAgRG8gbGlrZXdpc2UsIHJlY3Vyc2l2ZWx5IGlmIG5lY2Vzc2FyeSwgd2l0aCB0aGUgYWxs b2NhdGFibGUgY29tcG9uZW50cyBvZgogICAgZGVyaXZlZCB0eXBlcy4gIFRoaXMgZnVuY3Rp b24gaXMgYWxzbyBjYWxsZWQgZm9yIGFzc3VtZWQtcmFuayBhcnJheXMsIHdoaWNoCmRpZmYg LS1naXQgYS9nY2MvZm9ydHJhbi90cmFucy1hcnJheS5oIGIvZ2NjL2ZvcnRyYW4vdHJhbnMt YXJyYXkuaAppbmRleCAwNGZlZTYxNzU5MC4uY2QyYjNkOWYyZjAgMTAwNjQ0Ci0tLSBhL2dj Yy9mb3J0cmFuL3RyYW5zLWFycmF5LmgKKysrIGIvZ2NjL2ZvcnRyYW4vdHJhbnMtYXJyYXku aApAQCAtNjksNiArNjksOCBAQCB0cmVlIGdmY19jaGVja19wZHRfZHVtbXkgKGdmY19zeW1i b2wgKiwgdHJlZSwgaW50LCBnZmNfYWN0dWFsX2FyZ2xpc3QgKik7CiAKIHRyZWUgZ2ZjX2Fs bG9jX2FsbG9jYXRhYmxlX2Zvcl9hc3NpZ25tZW50IChnZmNfbG9vcGluZm8qLCBnZmNfZXhw ciosIGdmY19leHByKik7CiAKKy8qIEFkZCBpbml0aWFsaXphdGlvbiBmb3IgY2xhc3MgZGVz Y3JpcHRvcnMgICovCit2b2lkIGdmY190cmFuc19jbGFzc19hcnJheSAoZ2ZjX3N5bWJvbCAq LCBnZmNfd3JhcHBlZF9ibG9jayAqKTsKIC8qIEFkZCBpbml0aWFsaXphdGlvbiBmb3IgZGVm ZXJyZWQgYXJyYXlzLiAgKi8KIHZvaWQgZ2ZjX3RyYW5zX2RlZmVycmVkX2FycmF5IChnZmNf c3ltYm9sICosIGdmY193cmFwcGVkX2Jsb2NrICopOwogLyogR2VuZXJhdGUgYW4gaW5pdGlh bGl6ZXIgZm9yIGEgc3RhdGljIHBvaW50ZXIgb3IgYWxsb2NhdGFibGUgYXJyYXkuICAqLwpk aWZmIC0tZ2l0IGEvZ2NjL2ZvcnRyYW4vdHJhbnMtZGVjbC5jYyBiL2djYy9mb3J0cmFuL3Ry YW5zLWRlY2wuY2MKaW5kZXggNGI1NzBjMzU1MWEuLjYzNTE1YjkwNzJhIDEwMDY0NAotLS0g YS9nY2MvZm9ydHJhbi90cmFucy1kZWNsLmNjCisrKyBiL2djYy9mb3J0cmFuL3RyYW5zLWRl Y2wuY2MKQEAgLTQ4MzUsNyArNDgzNSw3IEBAIGdmY190cmFuc19kZWZlcnJlZF92YXJzIChn ZmNfc3ltYm9sICogcHJvY19zeW0sIGdmY193cmFwcGVkX2Jsb2NrICogYmxvY2spCiAgICAg ICBlbHNlIGlmICgoIXN5bS0+YXR0ci5kdW1teSB8fCBzeW0tPnRzLmRlZmVycmVkKQogCQkm JiAoc3ltLT50cy50eXBlID09IEJUX0NMQVNTCiAJCSYmIENMQVNTX0RBVEEgKHN5bSktPmF0 dHIuY2xhc3NfcG9pbnRlcikpCi0JY29udGludWU7CisJZ2ZjX3RyYW5zX2NsYXNzX2FycmF5 IChzeW0sIGJsb2NrKTsKICAgICAgIGVsc2UgaWYgKCghc3ltLT5hdHRyLmR1bW15IHx8IHN5 bS0+dHMuZGVmZXJyZWQpCiAJCSYmIChzeW0tPmF0dHIuYWxsb2NhdGFibGUKIAkJICAgIHx8 IChzeW0tPmF0dHIucG9pbnRlciAmJiBzeW0tPmF0dHIucmVzdWx0KQpAQCAtNDkxOSw2ICs0 OTE5LDEwIEBAIGdmY190cmFuc19kZWZlcnJlZF92YXJzIChnZmNfc3ltYm9sICogcHJvY19z eW0sIGdmY193cmFwcGVkX2Jsb2NrICogYmxvY2spCiAJCSAgdG1wID0gTlVMTF9UUkVFOwog CQl9CiAKKwkgICAgICAvKiBJbml0aWFsaXplIGRlc2NyaXB0b3IncyBUS1IgaW5mb3JtYXRp b24uICAqLworCSAgICAgIGlmIChzeW0tPnRzLnR5cGUgPT0gQlRfQ0xBU1MpCisJCWdmY190 cmFuc19jbGFzc19hcnJheSAoc3ltLCBibG9jayk7CisKIAkgICAgICAvKiBEZWFsbG9jYXRl IHdoZW4gbGVhdmluZyB0aGUgc2NvcGUuIE51bGxpZnlpbmcgaXMgbm90CiAJCSBuZWVkZWQu ICAqLwogCSAgICAgIGlmICghc3ltLT5hdHRyLnJlc3VsdCAmJiAhc3ltLT5hdHRyLmR1bW15 ICYmICFzeW0tPmF0dHIucG9pbnRlcgpkaWZmIC0tZ2l0IGEvZ2NjL3Rlc3RzdWl0ZS9nZm9y dHJhbi5kZy9QUjEwMDA5Ny5mOTAgYi9nY2MvdGVzdHN1aXRlL2dmb3J0cmFuLmRnL1BSMTAw MDk3LmY5MApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMC4uMmEwNzdk MGU0NzMKLS0tIC9kZXYvbnVsbAorKysgYi9nY2MvdGVzdHN1aXRlL2dmb3J0cmFuLmRnL1BS MTAwMDk3LmY5MApAQCAtMCwwICsxLDQxIEBACishIHsgZGctZG8gcnVuIH0KKyEgeyBkZy1v cHRpb25zICItZmR1bXAtdHJlZS1vcmlnaW5hbCIgfQorIQorISBUZXN0IHRoZSBmaXggZm9y IFBSMTAwMDk3CishCisKK3Byb2dyYW0gbWFpbl9wCisgIGltcGxpY2l0IG5vbmUKKworICBj bGFzcygqKSwgcG9pbnRlciAgICAgOjogYmFyX3AoOikKKyAgY2xhc3MoKiksIGFsbG9jYXRh YmxlIDo6IGJhcl9hKDopCisKKyAgY2FsbCBmb29fcChiYXJfcCkKKyAgY2FsbCBmb29fYShi YXJfYSkKKworY29udGFpbnMKKworICBzdWJyb3V0aW5lIGZvb19wKHRoYXQpCisgICAgY2xh c3MoKiksIHBvaW50ZXIsIGludGVudChvdXQpIDo6IHRoYXQoLi4pCisKKyAgICBzZWxlY3Qg cmFuayh0aGF0KQorICAgIHJhbmsoMSkKKyAgICByYW5rIGRlZmF1bHQKKyAgICAgIHN0b3Ag MQorICAgIGVuZCBzZWxlY3QKKyAgZW5kIHN1YnJvdXRpbmUgZm9vX3AKKworICBzdWJyb3V0 aW5lIGZvb19hKHRoYXQpCisgICAgY2xhc3MoKiksIGFsbG9jYXRhYmxlLCBpbnRlbnQob3V0 KSA6OiB0aGF0KC4uKQorCisgICAgc2VsZWN0IHJhbmsodGhhdCkKKyAgICByYW5rKDEpCisg ICAgcmFuayBkZWZhdWx0CisgICAgICBzdG9wIDIKKyAgICBlbmQgc2VsZWN0CisgIGVuZCBz dWJyb3V0aW5lIGZvb19hCisKK2VuZCBwcm9ncmFtIG1haW5fcAorCishIHsgZGctZmluYWwg eyBzY2FuLXRyZWUtZHVtcCAiYmFyX2EuX2RhdGEuZHR5cGUgPSBcXHsuZWxlbV9sZW49Lipc XH0iICJvcmlnaW5hbCIgfSB9CishIHsgZGctZmluYWwgeyBzY2FuLXRyZWUtZHVtcCAiYmFy X3AuX2RhdGEuZHR5cGUgPSBcXHsuZWxlbV9sZW49LipcXH0iICJvcmlnaW5hbCIgfSB9CmRp ZmYgLS1naXQgYS9nY2MvdGVzdHN1aXRlL2dmb3J0cmFuLmRnL1BSMTAwMDk4LmY5MCBiL2dj Yy90ZXN0c3VpdGUvZ2ZvcnRyYW4uZGcvUFIxMDAwOTguZjkwCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwLi41NWIxOTU4YWE0YQotLS0gL2Rldi9udWxsCisrKyBi L2djYy90ZXN0c3VpdGUvZ2ZvcnRyYW4uZGcvUFIxMDAwOTguZjkwCkBAIC0wLDAgKzEsNDUg QEAKKyEgeyBkZy1kbyBydW4gfQorISB7IGRnLW9wdGlvbnMgIi1mZHVtcC10cmVlLW9yaWdp bmFsIiB9CishCishIFRlc3QgdGhlIGZpeCBmb3IgUFIxMDAwOTgKKyEKKworcHJvZ3JhbSBt YWluX3AKKyAgaW1wbGljaXQgbm9uZQorCisgIHR5cGUgOjogZm9vX3QKKyAgICBpbnRlZ2Vy IDo6IGkKKyAgZW5kIHR5cGUgZm9vX3QKKworICBjbGFzcyhmb29fdCksIHBvaW50ZXIgICAg IDo6IGJhcl9wKDopCisgIGNsYXNzKGZvb190KSwgYWxsb2NhdGFibGUgOjogYmFyX2EoOikK KworICBjYWxsIGZvb19wKGJhcl9wKQorICBjYWxsIGZvb19hKGJhcl9hKQorCitjb250YWlu cworCisgIHN1YnJvdXRpbmUgZm9vX3AodGhhdCkKKyAgICBjbGFzcyhmb29fdCksIHBvaW50 ZXIsIGludGVudChvdXQpIDo6IHRoYXQoLi4pCisKKyAgICBzZWxlY3QgcmFuayh0aGF0KQor ICAgIHJhbmsoMSkKKyAgICByYW5rIGRlZmF1bHQKKyAgICAgIHN0b3AgMQorICAgIGVuZCBz ZWxlY3QKKyAgZW5kIHN1YnJvdXRpbmUgZm9vX3AKKworICBzdWJyb3V0aW5lIGZvb19hKHRo YXQpCisgICAgY2xhc3MoZm9vX3QpLCBhbGxvY2F0YWJsZSwgaW50ZW50KG91dCkgOjogdGhh dCguLikKKworICAgIHNlbGVjdCByYW5rKHRoYXQpCisgICAgcmFuaygxKQorICAgIHJhbmsg ZGVmYXVsdAorICAgICAgc3RvcCAyCisgICAgZW5kIHNlbGVjdAorICBlbmQgc3Vicm91dGlu ZSBmb29fYQorCitlbmQgcHJvZ3JhbSBtYWluX3AKKworISB7IGRnLWZpbmFsIHsgc2Nhbi10 cmVlLWR1bXAgImJhcl9hLl9kYXRhLmR0eXBlID0gXFx7LmVsZW1fbGVuPS4qXFx9IiAib3Jp Z2luYWwiIH0gfQorISB7IGRnLWZpbmFsIHsgc2Nhbi10cmVlLWR1bXAgImJhcl9wLl9kYXRh LmR0eXBlID0gXFx7LmVsZW1fbGVuPS4qXFx9IiAib3JpZ2luYWwiIH0gfQotLSAKMi4zNS4z Cgo= --------------Z5xuwWtGWpRs1AFOSo70O2As--