From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id 96A7A385800A; Mon, 21 Nov 2022 20:34:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 96A7A385800A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x631.google.com with SMTP id vv4so21935375ejc.2; Mon, 21 Nov 2022 12:34:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=WlirPQ6dgV5M/TB4w7BdTDvDWN9IPzz7Xp1NScdNgDY=; b=icDCNyz2+XfTKSRqQUdN66PcRPZTeHXu9ncC6+llvdGZKdOowqNQDnbVKq/YRfQQj3 HCERl4Y3j71ho51Y8WNSDm1uL6f60HSUOirfvn+3pGIQaqPNfxN/M7YCsMbHLg6gqF6i 6jpDZqrgIs1vvPnh0mjmhhEzkXdTxgCymUQWBvGdyoduLYF+ccZAbvDfrFvWUxXrCfug XSmfKirBVfHjujyN5FBtiDEWfdZAW5DhXJuyZuHOfM8ew3tyec31AwYjTV+UjU2P9a8p h1kfoVyvzavP8My3WweqENdr33Q7YZ/bOJGpyTVEAviOEl7ILFKgzidHk1Wl396RSf03 r5Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WlirPQ6dgV5M/TB4w7BdTDvDWN9IPzz7Xp1NScdNgDY=; b=ktmR6soLT94foHqyNFk0B7Zl+S1FN1Lgzcll0HIgO1LSBmN659vcDTEMN0pMtm8K6i 2+3PBCvE3rF7nb8pwjbKsqA56E914oqJWuNw9LNCcqK5y4riMHxwrrvb1C0AxohSveJq pmBh/rL6TAuIed3hJZTB0sJ+rtrrlZvRoDjiwmn2/DUQjMKjBtyxFNUftcvWuZhOywdv TpkefYbfE8U+mQldOhCW3amARx77cSYtQXhlIt4OxNG4xWmVqFYvOUmjVrkDoXpORemL Dmx6S3oO9R11GdrWjbGUIjS/XlQToVcG/sFIoHKQFaiBLRD9Km+ONnPH50S0h5480oXX rB3w== X-Gm-Message-State: ANoB5pncwveP8V/kv6L2LqbtJ/tTjbtxFeq3DyQnlsRvVuxT65fulEOE z2XnNZomJ8cSFYSnodKFpG0= X-Google-Smtp-Source: AA0mqf7eeAepevC3aKxY014cESWienohtmPs13F7aB68U3pHv+x7XRrAMfOZfQX4aGyG7ilOHU/O5Q== X-Received: by 2002:a17:907:d60c:b0:7ae:e592:6d83 with SMTP id wd12-20020a170907d60c00b007aee5926d83mr16036350ejc.699.1669062854377; Mon, 21 Nov 2022 12:34:14 -0800 (PST) Received: from nbbrfq (80-110-214-113.static.upcbusiness.at. [80.110.214.113]) by smtp.gmail.com with ESMTPSA id 14-20020a170906308e00b007b29a6bec24sm5294796ejv.32.2022.11.21.12.34.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Nov 2022 12:34:14 -0800 (PST) Date: Mon, 21 Nov 2022 21:34:10 +0100 From: Bernhard Reutner-Fischer To: Mikael Morin Cc: rep.dot.nop@gmail.com, gcc-patches@gcc.gnu.org, Bernhard Reutner-Fischer , gfortran ML Subject: Re: [PATCH 1/2] Fortran: Cleanup struct ext_attr_t Message-ID: <20221121213410.79ae5601@nbbrfq> In-Reply-To: References: <20221110102031.1366016-1-aldot@gcc.gnu.org> <20221110102031.1366016-2-aldot@gcc.gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 21 Nov 2022 12:08:20 +0100 Mikael Morin wrote: > > * gfortran.h (struct ext_attr_t): Remove middle_end_name. > > * trans-decl.cc (add_attributes_to_decl): Move building > > tree_list to ... > > * decl.cc (gfc_match_gcc_attributes): ... here. Add the attribute to > > the tree_list for the middle end. > > > I prefer to not do any middle-end stuff at parsing time, so I would > rather not do this change. > Not OK. Ok, that means we should filter-out those bits that we don't want to write to the module (right?). We've plenty of bits left, more than Dave Love would want to have added, i hope, so that should not be much of a concern. What that table really wants to say is whether or not this attribute should be passed to the ME. Would it be acceptable to remove these duplicate strings and just have a bool/char/int that is true if it should be lowered (in trans-decl, as before)? But now i admit it's just bikeshedding and we can as well leave it alone for now.. It was just a though. thanks,