public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: Julian Brown <julian@codesourcery.com>
To: Tobias Burnus <tobias@codesourcery.com>
Cc: <gcc-patches@gcc.gnu.org>, <fortran@gcc.gnu.org>,
	Jakub Jelinek <jakub@redhat.com>,
	Chung-Lin Tang <chunglin.tang@siemens.com>
Subject: Re: [PATCH v5 2/4] OpenMP/OpenACC: Rework clause expansion and nested struct handling
Date: Wed, 7 Dec 2022 15:16:57 +0000	[thread overview]
Message-ID: <20221207151657.7340469c@squid.athome> (raw)
In-Reply-To: <65824aa6-be83-3c74-871e-6571008f2d25@codesourcery.com>

On Wed, 7 Dec 2022 15:54:42 +0100
Tobias Burnus <tobias@codesourcery.com> wrote:

> Hi Julian,
> 
> If I understand Deepak's comment (on OpenMP.org's omp-lang list, sorry
> it is a nonpublic list) correctly, the following wording implies that
> a 'from: s.w[z:4]' for a pointer 's.w' also implies a mapping of
> 's.w' - if 's' is used inside the target region and, thus, gets
> implicitly mapped.
> 
> [TR11 157:21-26] (approx. [5.2 154:22-27], [5.1 352:17-22], [5.0
> 320:22-27])
> 
> "If a list item with an implicit data-mapping attribute does not have
> any corresponding storage in the device data environment prior to a
> task encountering the construct associated with the map clause, and
> one or more contiguous parts of the original storage are either list
> items or base pointers to list items that are explicitly mapped on
> the construct, only those parts of the original storage will have
> corresponding storage in the device data environment as a result of
> the map clauses on the construct."

Hmmm... IIRC that is a different conclusion than the one we have
understood previously, leading to e.g. the patch here (Chung-Lin CC'ed):

https://gcc.gnu.org/pipermail/gcc-patches/2021-May/570075.html

Follow-on discussion then questioned whether the change was really the
intention of the spec, but we thought it was.  Has that changed now?

(I think actually changing the behaviour is a matter of flipping a
switch, but let's make sure we choose the right setting!)

Thanks,

Julian

  reply	other threads:[~2022-12-07 15:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-18 10:39 [PATCH v5 0/4] OpenMP/OpenACC: Fortran array descriptor mappings Julian Brown
2022-10-18 10:39 ` [PATCH v5 1/4] OpenMP/OpenACC: Reindent TO/FROM/_CACHE_ stanza in {c_}finish_omp_clause Julian Brown
2022-10-18 10:39 ` [PATCH v5 2/4] OpenMP/OpenACC: Rework clause expansion and nested struct handling Julian Brown
2022-10-18 12:33   ` Julian Brown
2022-10-18 12:33     ` Julian Brown
2022-12-07 14:54   ` Tobias Burnus
2022-12-07 15:16     ` Julian Brown [this message]
2022-12-07 16:13       ` Tobias Burnus
2022-12-12 15:19         ` Julian Brown
2022-10-18 10:39 ` [PATCH v5 3/4] OpenMP: Pointers and member mappings Julian Brown
2022-12-07 16:31   ` Tobias Burnus
2022-12-15 14:54     ` Julian Brown
2022-12-15 16:46       ` Julian Brown
2022-10-18 10:39 ` [PATCH v5 4/4] OpenMP/OpenACC: Unordered/non-constant component offset runtime diagnostic Julian Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221207151657.7340469c@squid.athome \
    --to=julian@codesourcery.com \
    --cc=chunglin.tang@siemens.com \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=tobias@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).