From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 1EF8F38937F6; Thu, 15 Dec 2022 16:47:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1EF8F38937F6 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.96,248,1665475200"; d="scan'208";a="93067679" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa1.mentor.iphmx.com with ESMTP; 15 Dec 2022 08:47:01 -0800 IronPort-SDR: qO+GXV60iLxhmw7aN0FiRxyDVANPPmLqOG9+EfSQzFtzbgfoV2b/1h3LjitvwEmUqBag7inHxJ pFkBvDxDwAIZ2KdWcMqqCyZxmlVineHZMOVfDLuS6d1Ktwr91m9PyESseRM1l9OY409E0Vk19d EzRTfCVNaQVhtW4wiQXh5wQwBM+UXSfvJKZ46sBdZ6Hy2JX8QT16ldcxX5zHcwXIkbDNJNXPB/ +/nLY0LdMNcgFl9nHFq4ORawJ+hd/PygHt7QTB8w9H3XXMAjGGkSfkpb/ml7nELoUr0zfZN/kf SZI= Date: Thu, 15 Dec 2022 16:46:50 +0000 From: Julian Brown To: Tobias Burnus CC: , , Jakub Jelinek , Thomas Schwinge Subject: Re: [PATCH v5 3/4] OpenMP: Pointers and member mappings Message-ID: <20221215164650.332b5084@squid.athome> In-Reply-To: <20221215145458.458074ca@squid.athome> References: <80f87c37a4f8b9f1f61c1668ecb750cefb1aec77.1666088224.git.julian@codesourcery.com> <20221215145458.458074ca@squid.athome> Organization: Siemens Embedded X-Mailer: Claws Mail 4.1.1git7 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-11.mgc.mentorg.com (147.34.90.211) To svr-ies-mbx-11.mgc.mentorg.com (139.181.222.11) X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,KAM_SHORT,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 15 Dec 2022 14:54:58 +0000 Julian Brown wrote: > On Wed, 7 Dec 2022 17:31:20 +0100 > Tobias Burnus wrote: > > > Hi Julian, > > > > I think this patch is OK; however, at least for gimplify.cc Jakub > > needs to have a second look. > > Thanks for the review! Here's a new version that hopefully addresses > your comments. (The gimplify bits change a bit more in this version!) FYI, this is the current dependency list for this patch: (1) "OpenMP/OpenACC: Reindent TO/FROM/_CACHE_ stanza in {c_}finish_omp_clause" https://gcc.gnu.org/pipermail/gcc-patches/2022-October/603791.html Approved. (2) "OpenMP/OpenACC: Rework clause expansion and nested struct handling" https://gcc.gnu.org/pipermail/gcc-patches/2022-October/603792.html Approved, but waiting for *this* patch to avoid regressing Fortran pointer-mapping behaviour, and which Tobias noticed an issue with prior to committing, addressed by (4). (3) "OpenMP/OpenACC: Refine condition for when map clause expansion happens" https://gcc.gnu.org/pipermail/gcc-patches/2022-November/607543.html Not reviewed (partly OpenACC). (4) "OpenMP: implicitly map base pointer for array-section pointer components" https://gcc.gnu.org/pipermail/gcc-patches/2022-December/608318.html Not reviewed. The following patches also depend on this one and the above: (5) "OpenMP: lvalue parsing for map clauses (C++)" https://gcc.gnu.org/pipermail/gcc-patches/2022-November/605367.html Mostly approved. (6) "OpenMP: C++ "declare mapper" support" https://gcc.gnu.org/pipermail/gcc-patches/2022-November/607544.html Revised version unreviewed. ...and the to-be-revised "lvalue parsing for C", and C/Fortran "declare mapper" patches. HTH, Julian