From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by sourceware.org (Postfix) with ESMTPS id A1AB3385841A; Sat, 25 Feb 2023 21:55:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A1AB3385841A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x534.google.com with SMTP id da10so11154404edb.3; Sat, 25 Feb 2023 13:55:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=KpO0ZiOnQPdSbswzpXX86JXUqpmxtXzCJR9Rv0mH/OM=; b=Rrh3uf1XaE9Sd9nkkjE0jGFQlQK0yxWr32xvHCaJY4RBwDerOWxdRtLLjtXIIy48kp 9EkpTwQ6CiGeMyi0VsnF0hPyxi88XndEYRQmCEFDorgnFFf4s950vFZ0mwvm905E4UpC qYAK2+YCj0EY1J6xZBYKKgXJmaLRJQvZWK2u5bcYX59FgPKfJ4KDTWl1Z6eIoTXpOtvp c+Aa44/Ta3P4iyhtunNkKyqSAgyujNO4COGhGsedzFVPHH4fl2xgY0yQkkXPtQdoc+zH qdAEOIsn3ydOKmjtxM67S8LwTkRjTuN8rXY1udR7VhSdu8prqYOS9gUjoVq9IMuFL7Oc vDbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KpO0ZiOnQPdSbswzpXX86JXUqpmxtXzCJR9Rv0mH/OM=; b=neLKtTRXEb6zhFpHcuQlOEpv4jEtuNNwNXeVVZnsIZoMueHs07k5AYdRXVlYnvEcpS JMPN6mJclsRt5ZbQ5WvFS/GpN95M+KapaqLHsuaxHj7QFq2lmQdZkEJIxuD7nuoQGFbY s2Gdu5xACRZqmwo1awAISjgcDoo/LwSXKGPntlazErH9qtntKdKeKy1lSCwCqm5iXDcY O+FOYzs5go18eAnm5bdfjurvaVFAYZMpU32+J5n1gEntfWO20dmwCaEW+1e9VM+LJCdW 5VGOSjJ9d+1b7WOkTl6L9QrWESf8ZMItCCwsomqNzYGR3YxAdQF/qK6I8HaBdTnhvkdX ao+Q== X-Gm-Message-State: AO0yUKXcpvOvhxsrgEVmcWXJXBjx6AaCmZVqZatbbF2ar86EC0Vsrfcu 5hl03uQSuoKbMMhy+tfaLt0= X-Google-Smtp-Source: AK7set+R8pBVfbsh4kmcYaE/qtalwO+xoA2hfPUl5pwtTYUIap5c/cKD498+/PTrIarge5gegRG0Fg== X-Received: by 2002:a17:907:9870:b0:889:5686:486a with SMTP id ko16-20020a170907987000b008895686486amr27585176ejc.30.1677362121977; Sat, 25 Feb 2023 13:55:21 -0800 (PST) Received: from nbbrfq ([2001:871:227:9b91:f46e:7af7:1c5a:25c6]) by smtp.gmail.com with ESMTPSA id i1-20020a170906a28100b008e45d7055f8sm1229289ejz.198.2023.02.25.13.55.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Feb 2023 13:55:21 -0800 (PST) Date: Sat, 25 Feb 2023 22:55:18 +0100 From: Bernhard Reutner-Fischer To: Harald Anlauf Cc: rep.dot.nop@gmail.com, fortran@gcc.gnu.org, Thomas Koenig Subject: drop -fdump-fortran-global ? [was: Re: [PATCH,FORTRAN] Fix memory leak of gsymbol] Message-ID: <20230225225518.3567af8d@nbbrfq> In-Reply-To: <20211031212544.043daf3a@nbbrfq> References: <20181021140434.30743-1-rep.dot.nop@gmail.com> <20211027234320.16fc848b@nbbrfq> <20211029012302.052fc4c4@nbbrfq> <20211030185256.2e1c4434@nbbrfq> <20211030235101.3d3e9041@nbbrfq> <2ffbe5d9-88d2-e9a9-4f2b-1c3944b87d76@gmx.de> <20211031212544.043daf3a@nbbrfq> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, 31 Oct 2021 21:25:44 +0100 Bernhard Reutner-Fischer wrote: > On Sun, 31 Oct 2021 20:46:07 +0100 > Harald Anlauf wrote: > > > Am 30.10.21 um 23:51 schrieb Bernhard Reutner-Fischer via Fortran: > > >>> The only caller is translate_all_program_units. > > >>> Since we free only module gsyms, even -fdump-fortran-global is > > >>> unaffected by this, fwiw. > > > > > > AFAICS we do not have a test for -fdump-fortran-global > > > Do we want to add one, would the attached be OK? > > > > This doesn't seem to test anything new or changed, or a bug fixed. > > I get the same result for all version from 9 to 12-mainline. > > So as is it seems pointless. > > Yes indeed, it just adds coverage to that functionality which we did not > exercise before. > TBH i only found that option when looking around > translate_all_program_units. I've never actually used that option > myself and cannot imagine how it is useful at all :) > > Dropped the testcase. > Thanks for your comment! The rest of 5c6aa9a8919cbf0dcf3c375f51012720bfb5f3a1 is fine, but should we really keep the option, if we don't even test basics and if it was more a specific debug dump, from the looks? Thomas? thanks,