From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by sourceware.org (Postfix) with ESMTPS id 2FCB8385771A; Wed, 10 May 2023 19:30:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2FCB8385771A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-966287b0f72so944452266b.0; Wed, 10 May 2023 12:30:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683746999; x=1686338999; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=jkp+v4esPHOwV4KuKVD8ybfssdtcnP5Ud4+O1rgJRWo=; b=HzN143uSjGaz2MaHwvTOw02oCKRIVv5DulXbShdffBLEbh3WElvSEy1l55++XYf9WH RNKjaLu1X1WaUUVOyIZIVD+IDc9BTiMvyQPj6lw0fQfg6sThDJ8SE4bUqgSBp4pQ83cv e2ZQFyy7n30I745WPTETbyLa22Zrv14prROwdfdugFMW5DVdseQ80kGVpgu+MZG+0jW2 mAUoglFqTmNZOriGDyjjIcKEQWLG+8x4AYe+0DBsju9tmSg8ZnP4linokVTf2XKNJvr8 1UThvCqHYMG+LkiUb+VdNZDEU/y4UYqRIjuvEl1yPrKgn4dAnqJ8eoFvPprDP5nPOSag Isvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683746999; x=1686338999; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jkp+v4esPHOwV4KuKVD8ybfssdtcnP5Ud4+O1rgJRWo=; b=gKpSg8InAae81+w4NyaQ/+E/2X6Rpg06ICT3mCa4Vl4/8kfSKSBmf2UqVILTelaVLH aWw0qjFyH/YqSMnSQ3TNNoZ+S0B+8aURT9FH2Vw4LiSeBtLd27rskDNVUNCiBJGZKrAW slREuXYSH8RDpIw6KGGGZltfCDdjJMIqXgmXydxb80vYElgsOlxH7a+AOcb/80OvuEIR ioNamB574EhUmiiLYslNA642QauM4x9N4hfnM/Jm965XwUYzcKAtRr2vd/FilXB2bAH2 knWrNR00+U+bY79r3X9prrWk9owr4MEIGLf375yxWCBmtyj2VbH2APIViyEVnCLYq4LG 06fg== X-Gm-Message-State: AC+VfDy3nKrSMP3kOPpU90ozjRnrWnO8TUw5naDxvzXVZSwqXCYwNAq8 +eMrQIqfFyTbSdW5V8S3lmQ= X-Google-Smtp-Source: ACHHUZ7vkpJS33l0r7kgATbkL6fGjdYgn/cb8zmFPAYZ3d8AsqFumwlgUrrBz2U31AUNtoiqHLEbOQ== X-Received: by 2002:a17:907:6d8c:b0:94f:cee:56f2 with SMTP id sb12-20020a1709076d8c00b0094f0cee56f2mr18183363ejc.4.1683746998822; Wed, 10 May 2023 12:29:58 -0700 (PDT) Received: from nbbrfq (80-110-214-113.static.upcbusiness.at. [80.110.214.113]) by smtp.gmail.com with ESMTPSA id x13-20020aa7cd8d000000b0050488d1d376sm2107120edv.0.2023.05.10.12.29.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 May 2023 12:29:58 -0700 (PDT) Date: Wed, 10 May 2023 21:29:25 +0200 From: Bernhard Reutner-Fischer To: Xi Ruoyao Cc: gcc-patches@gcc.gnu.org, Rainer Orth , Arnaud Charlet , Jonathan Wakely , fortran@gcc.gnu.org Subject: Re: [PATCH v2 4/7] fortran: use grep instead of fgrep Message-ID: <20230510212925.23e2837b@nbbrfq> In-Reply-To: <1e2be9a04a91bd061892353b578261666a1c9b75.camel@xry111.site> References: <1e2be9a04a91bd061892353b578261666a1c9b75.camel@xry111.site> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 27 Jun 2022 14:10:36 +0800 Xi Ruoyao wrote: > fgrep has been deprecated in favor of grep -F for a long time, and the > next grep release (3.8 or 4.0) will print a warning of fgrep is used. > Stop using fgrep so we won't see the warning. > > We can't hard code grep -F here or it may break build on hosts w/o GNU > grep. autoconf documentation contains a warning about this issue and > suggest to use AC_PROG_FGREP and $FGREP, but these are too overkill in > the specific case: there is no way "debian" could be interpreted as an > non-trivial regex, so we can use a plain grep here. LGTM but i cannot approve it. I'd say this one is trivial and obvious so you could sneak it in under the "obvious" rule.. Thanks for the patch! > > gcc/fortran/ChangeLog: > > * Make-lang.in: Use grep instead of fgrep. > --- > gcc/fortran/Make-lang.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/fortran/Make-lang.in b/gcc/fortran/Make-lang.in > index 1cb47cb1a52..6eb597d0ca0 100644 > --- a/gcc/fortran/Make-lang.in > +++ b/gcc/fortran/Make-lang.in > @@ -278,7 +278,7 @@ $(DESTDIR)$(man1dir)/$(GFORTRAN_INSTALL_NAME)$(man1ext): doc/gfortran.1 \ > -chmod a-x $@ > > fortran.uninstall: > - if $(SHELL) -c 'install-info --version | sed 1q | fgrep -s -v -i debian' >/dev/null 2>&1; then \ > + if $(SHELL) -c 'install-info --version | sed 1q | grep -s -v -i debian' >/dev/null 2>&1; then \ > echo " install-info --delete --info-dir=$(DESTDIR)$(infodir) $(DESTDIR)$(infodir)/gfortran.info"; \ > install-info --delete --info-dir=$(DESTDIR)$(infodir) $(DESTDIR)$(infodir)/gfortran.info || : ; \ > else : ; fi; \