From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id 043923858C41; Fri, 19 May 2023 19:20:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 043923858C41 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-95fde138693so244826566b.0; Fri, 19 May 2023 12:20:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684523999; x=1687115999; h=mime-version:references:in-reply-to:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=Q0fM4aYU3FC6fvrtFMXB8aYhG+55qwAql+YplTZcNVo=; b=Yn9Bd2yzRgwJFE6f9tLZnJi5a718LSXUXWS+dtxklJkuZwl+CQ1fivRxBohHWHuk0P GrqmCqPxvgurv8IC+tmc6+jUZOA6W2kL2B/nmL3IiN3/34knU5dmPYBg1c2StEaEo6Ua BnG2Xwlm09g+8WJu5mYpIDVRiC6IQc+CqE3kP/+ERzLIfOoZpx0Ynw//Cv2TbbJiW72G zAeEkzSuumX5wmFHF2+ZzbeEy3sKh1W+F9n5pqhkLx1R2+oqI7r1IO2xADNYV5/e8RfQ RTf8GgvV1ueaevtLU+xjFdLwgnPjniHSWvUS2gJlk95dBcMZLuF/o3LtnIh9HKcoxE5p MmIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684523999; x=1687115999; h=mime-version:references:in-reply-to:message-id:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Q0fM4aYU3FC6fvrtFMXB8aYhG+55qwAql+YplTZcNVo=; b=BZVDBrVHNDLarPz3lAMttVF8JLEo5e8riA2BHI07t2v0TOUINBNSOqtJZo9V9cmHZl hVVN800vvC2T4Ym1n+tHQFQ6RhEA+eG5B5FY9JPHlN6Vf4G8211J8P/9TbnS3XrNvoCC MPYtW1F9idrcQ35JgzppRk/+NlF/tN7qt7gUaOqJ4nQpC5h7AtlArpAUC/aFZ28LtHQa x15DdBnFmd7rEohWEWOdMpbvNTw5y6r/HCqMZvcrCp/mmAeB3AlHKz4uS34phJsPT2Hi EnEDoIEj4cWESGZPHeSHZ77URMKixd7ZexO+++dezE9UlZfBYP9IAd0yyRb9I3xbqxqe TG4g== X-Gm-Message-State: AC+VfDxvYq+En1gqzOhCfOjZFTrB1j7fsxDQc7J3Y86ddI8LuBlnEqJU rRAzlv7Zu2j8Wcvy9TcYRQE= X-Google-Smtp-Source: ACHHUZ781rRXVr2WRkJcdBG4sTCOE0PYpMn/BT8OwD4hDJ37V7nVQcZ8++wCjMuiCE8kFpjonjCUVw== X-Received: by 2002:a17:907:7291:b0:95f:969e:dc5a with SMTP id dt17-20020a170907729100b0095f969edc5amr2348363ejc.30.1684523998804; Fri, 19 May 2023 12:19:58 -0700 (PDT) Received: from nbbrfq.loc (80-110-214-113.static.upcbusiness.at. [80.110.214.113]) by smtp.gmail.com with ESMTPSA id u9-20020a1709067d0900b00965cd3a037fsm2607921ejo.112.2023.05.19.12.19.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 May 2023 12:19:58 -0700 (PDT) Date: Fri, 19 May 2023 21:19:53 +0200 From: Bernhard Reutner-Fischer To: Mikael Morin Cc: gcc-patches@gcc.gnu.org, Bernhard Reutner-Fischer , fortran@gcc.gnu.org Subject: Re: [PATCH 08/14] fortran: use _P() defines from tree.h Message-ID: <20230519211953.7f4031f2@nbbrfq.loc> In-Reply-To: <0815cec8-7180-3f55-a479-9aea2cac7026@orange.fr> References: <20230513232321.279733-1-rep.dot.nop@gmail.com> <20230513232321.279733-9-rep.dot.nop@gmail.com> <8beeaf61-a292-24b3-b821-ad31200d7ca6@orange.fr> <20230518171851.1e09c436@nbbrfq.loc> <0815cec8-7180-3f55-a479-9aea2cac7026@orange.fr> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/_NbQ3Wu+HE2xqUFoWr.i/5W" X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --MP_/_NbQ3Wu+HE2xqUFoWr.i/5W Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Thu, 18 May 2023 21:20:41 +0200 Mikael Morin wrote: > Le 18/05/2023 =C3=A0 17:18, Bernhard Reutner-Fischer a =C3=A9crit=C2=A0: > > I've fed gfortran.h into the script and found some CLASS_DATA spots, > > see attached bootstrapped and tested patch. > > Do we want to have that? =20 > Some of it makes sense, but not all of it. >=20 > It is a macro to access the _data component of a class container. > So for class-related stuff it makes sense to use CLASS_DATA, and=20 > typically there will be a check that the type is BT_CLASS before. > But for cases where we loop over all of the components of a type that is= =20 > not necessarily a class container, it doesn't make sense to use CLASS_DAT= A. >=20 > So I suggest to only keep the following hunks. [] > OK for those hunks. Pushed those as r14-1001-g05b7cc7daac8b3 Many thanks! PS: I'm attaching the fugly script i used to do these macro replacements FYA. --MP_/_NbQ3Wu+HE2xqUFoWr.i/5W Content-Type: application/x-awk Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=use-defines.1.awk IyBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjogUHVibGljIERvbWFpbgojIFJlcGxhY2Ugb3Blbi1j b2RlZCBib2RpZXMgb2YgbWFjcm9zIHdpdGggdGhlaXIgbWFjcm8gbmFtZS4KIyBDb25maWRlbmNl OiBMb3cKIyBCdWdzOiBJJ2QgYmV0dGVyIGhhdmUgd3JpdHRlbiB0aGlzIGdlbmVyYXRvciBpbiBw eXRob24gd2hlbiBpdCBncmV3CiMgICAgICAgb3ZlciA1IGxpbmVzLi4gVGVzdGVkIHdpdGggYnVz eWJveCBhd2sgYW5kIEdOVSBhd2suCiMKIyBVc2FnZToKIyAgYXdrIC1mIH4vY29jY2luZWxsZS91 c2UtZGVmaW5lcy4xLmF3ayA8IGdjYy90cmVlLmggPiB+L2NvY2NpbmVsbGUvZ2NjLXRyZWVfcC4x LmNvY2NpCiMgIGZpbmQgLi8gXCggLW5hbWUgInRlc3RzdWl0ZSIgLW8gLW5hbWUgImNvbnRyaWIi IC1vIC1uYW1lICJleGFtcGxlcyIgLW8gLW5hbWUgIi5naXQiIFwpIC1wcnVuZSAtbyBcKCAtbmFt ZSAiKi5bY2hweF0qIiAtYSAtdHlwZSBmIC1hICEgLW5hbWUgInRyZWUuaCIgXCkgLWV4ZWMgc3Bh dGNoIC0tYysrPTExIC0tc21wbC1zcGFjaW5nIC0taW4tcGxhY2UgLS1zcC1maWxlIH4vY29jY2lu ZWxsZS9nY2MtdHJlZV9wLjEuY29jY2kge30gXDsKIyBnaXQgZGlmZiB8IHNlZCBcCiMgICAtZSAn L15cKy9zL1woW15bOnNwYWNlOl1dXCkoL1wxICgvZycgXAojICAgLWUgJy9eXCtzKi4qKCAoL3Mv KCAoLygoL2cnIFwKIyAgIC1lIC9eXCsvcy8gICAgICAgIC8JL2cnIFwKIyAgIC1lICcvXlwrL3Mv W1s6c3BhY2U6XV0qJC8vJwojID4gL3RtcC9ub24ucGF0Y2gKQkVHSU57CiAgaT0xCiAgIyBTa2lw IHJlZGVmaW5pdGlvbnMgYW5kIGEgaGFuZGZ1bCBvZiB1bndhbnRlZCB0b2tlbnMgbGlrZSBOVUxM X1RSRUUKICBzZWVuWyJOVUxMX1RSRUUiXSA9IDE7ICMgd2Ugd2FudCB0byByZXRhaW4gIk5VTEwi CiAgc2VlblsiVFJFRV9SRUFMUEFSVCJdID0gMTsgIyBzZWVtcyB0byBjb25mdXNlIGNvY2NpCiAg c2VlblsiVFJFRV9JTUFHUEFSVCJdID0gMTsgIyBzZWVtcyB0byBjb25mdXNlIGNvY2NpCiAgc2Vl blsiREVDTF9CVUlMVF9JTl9DTEFTUyJdID0gMTsgIyBzZWVtcyB0byBjb25mdXNlIGNvY2NpCiAg c2VlblsiQ0FOX0hBVkVfUkFOR0VfUCJdID0gMTsgIyBrZWVwIENBTl9IQVZFX0xPQ0FUSU9OX1AK CiAgcHJpbnQoIi8vIFVzZSAqX1AoKSBmcm9tIHRyZWUuaCIpCiAgcHJpbnQoIi8vIikKICBwcmlu dCgiLy8gZmluZCAuLyBcKCAtbmFtZSAiInRlc3RzdWl0ZSIiIC1vIC1uYW1lICIiY29udHJpYiIi IC1vIC1uYW1lICIiZXhhbXBsZXMiIiAtbyAtbmFtZSAiIi5naXQiIiBcKSAtcHJ1bmUgLW8gXCgg LW5hbWUgIiIqLltjaHB4XSoiIiAtYSAtdHlwZSBmIC1hICEgLW5hbWUgIiJ0cmVlLmgiIiBcKSAt ZXhlYyBzcGF0Y2ggLS1jKys9MTEgLS1zbXBsLXNwYWNpbmcgLS1pbi1wbGFjZSAtLXNwLWZpbGUg fi9jb2NjaW5lbGxlL2djYy10cmVlX3AuMS5jb2NjaSB7fSBcOyIpCiAgcHJpbnQoIi8vIHNlZCAt ZSAnL15cKy9zL1woW15bOnNwYWNlOl1dXCkoL1xcMSAoL2cnIC1lIC4uLiIpCn0KIyAqX1AgKCkK L15bWzpzcGFjZTpdXSojW1s6c3BhY2U6XV0qZGVmaW5lW1s6c3BhY2U6XV0qW0EtWl9dK19QW1s6 c3BhY2U6XV0qXChbQS1aYS16XywgXHRdKlwpL3sKIyBhbGwgbWFjcm9zIHdpdGggYXJndW1lbnQo cykKIy9eW1s6c3BhY2U6XV0qI1tbOnNwYWNlOl1dKmRlZmluZVtbOnNwYWNlOl1dKltBLVpfXStb WzpzcGFjZTpdXSpcKFtBLVphLXowLTlfLCBcdF0qXCkvewogIGdzdWIoL15bWzpzcGFjZTpdXSoj W1s6c3BhY2U6XV0qZGVmaW5lW1s6c3BhY2U6XV0qLywgIiIpCiAgc3ViKCJcKCIsICIgIikKICBk ZWYgPSAkMQogIHN1YigiXlteWzpzcGFjZTpdXSpbWzpzcGFjZTpdXSoiLCAiIikKICBzdWIoIlwp IiwgIikgIikKICBhcmcgPSAiIgogIGRvIHsKICAgIGFyZyA9IGFyZyAkMQogICAgc3ViKCJeW14p WzpzcGFjZTpdXSpbWzpzcGFjZTpdXSoiLCAiIikKICAgIGlmIChhcmcgfiAvXCkkLykgewogICAg ICBhcmcgPSBzdWJzdHIoYXJnLCAxLCBsZW5ndGgoYXJnKSAtIDEpCiAgICAgIGJyZWFrCiAgICB9 CiAgfSB3aGlsZSAoMSkKICBnc3ViKCIsIiwgIiwgIiwgYXJnKQogIHN1YigiXlteKV0qKVtbOnNw YWNlOl1dKiIsICIiKQojcHJpbnRmKCIvLyBkZWY9JyVzJyBhcmc9JyVzJ1xuIiwgZGVmLCBhcmcp CiAgYm9keSA9ICIiCiAgZG8gewogICAgZ3N1YigvKF5bWzpzcGFjZTpdXSp8W1s6c3BhY2U6XV0q JCkvLCAiIikKICAgIGdzdWIoL1tbOnNwYWNlOl1dW1s6c3BhY2U6XV0qLywgIiAiKQogICAgYm9k eSA9IGJvZHkgJDAKICAgIGlmIChib2R5IH4gL1xcJC8pIHsKICAgICAgZ3N1YigvXFwkLywgIiIs IGJvZHkpCiAgICAgIGdldGxpbmUKICAgIH0gZWxzZSB7CiAgICAgIGJyZWFrCiAgICB9CiAgfSB3 aGlsZSAoMSkKICAjIElnbm9yZSBzb21lIGNvcm5lciBjYXNlcyBvciB1bnVzZWZ1bCBzdHVmZiBs aWtlIF9DSEVDSygpCiAgIyBOVUxMX1RSRUUodHJlZSkKICAjIENBU0VfRkxUX0ZOIENBU0VfRkxU X0ZOX0ZMT0FUTl9OWCBDQVNFX0JVSUxUX0lOX1RNX1NUT1JFIC4uLgogIGlmICghbGVuZ3RoKGJv ZHkpIHx8IGJvZHkgfiAvIyMvIHx8IGJvZHkgPT0gIk5VTEwiIHx8IGRlZiB+IC9fQ0hFQ0skLykg ewogICAgbmV4dAogIH0KICBpZiAoYm9keSB+IC9eX19leHRlbnNpb25fXy8pIHsKICAgIG5leHQ7 ICMgTklICiAgfQogIGZvcl9sb29wID0gYm9keSB+IC9eZm9yW15bOmFsbnVtOl1dLwogIGRvX2xv b3AgPSBib2R5IH4gL14oZG98d2hpbGUpW15bOmFsbnVtOl1dLwogIGlmIChmb3JfbG9vcCB8fCBk b19sb29wKSB7CiAgICBuZXh0OwogIH0KCiAgaWYgKCEgc2VlbltkZWZdKSB7CiAgICBzZWVuW2Rl Zl0gPSAxCiNwcmludGYoIi8vIGJvZHk9JyVzJ1xuIiwgYm9keSkKICAgIHByaW50KCJAIHJ1bGUi IGkrKyAiIEAiKQogICAgcHJpbnQoImV4cHJlc3Npb24gIiBhcmcgIjsiKQogICAgaWYgKDAgJiYg Zm9yX2xvb3ApIHsKICAgICAgcHJpbnQoInN0YXRlbWVudCBGT1JfTE9PUF9CT0RZOyIpCiAgICB9 CiAgICBzcGxpdCgiSE9TVF9XSURFX0lOVCBzaWdub3AiLCB0eXBlcykKICAgIGZvciAodCBpbiB0 eXBlcykgewogICAgICBpZiAoYm9keSB+IHR5cGVzW3RdKSB7CiAgICAgICAgcHJpbnRmKCJ0eXBl ICVzO1xuIiwgdHlwZXNbdF0pCiAgICAgIH0KICAgIH0KICAgIHNwbGl0KCJ0cmVlIGJ1aWx0X2lu X2NsYXNzIiwgdHlwZXMpCiAgICBmb3IgKHQgaW4gdHlwZXMpIHsKICAgICAgaWYgKGJvZHkgfiB0 eXBlc1t0XSkgewogICAgICAgIHByaW50ZigidHlwZWRlZiAlcztcbiIsIHR5cGVzW3RdKQogICAg ICB9CiAgICB9CiAgICBzcGxpdCgiZXJyb3JfbWFya19ub2RlIiwgdHlwZXMpCiAgICBmb3IgKHQg aW4gdHlwZXMpIHsKICAgICAgaWYgKGJvZHkgfiB0eXBlc1t0XSkgewogICAgICAgIHByaW50Zigi aWRlbnRpZmllciAlcztcbiIsIHR5cGVzW3RdKQogICAgICB9CiAgICB9CiAgICBwcmludCgiQEAi KTsKICAgIHByaW50KCItICIgYm9keSkKICAgIHByaW50KCIrICIgZGVmICIgKCIgYXJnICIpIikK ICAgIHByaW50KCIiKQogIH0KfQo= --MP_/_NbQ3Wu+HE2xqUFoWr.i/5W--