From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) by sourceware.org (Postfix) with ESMTPS id F1BF33858CD1 for ; Sat, 17 Jun 2023 14:43:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F1BF33858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=kitware.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kitware.com Received: by mail-qk1-x731.google.com with SMTP id af79cd13be357-7624012c0b4so64695885a.1 for ; Sat, 17 Jun 2023 07:43:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kitware.com; s=google; t=1687013015; x=1689605015; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=euNHs8EIqgmHqR46TCGr3wBmtSwcYq+ARpCacNdV4Ek=; b=HG+mp8kn86H4B5u1H4WIZVjdPjuyBqi4TTZT/xeX7JZcUsGAoE+erMoUJiG1eF33mK jzHMnhjyYIKZxKXPeP8CNWttko1d2rYZNTWoY6i9v2xpAapsODMiVU/mWkbtO9/foCY9 KtfvPKPM03eHut//gsnZRSK9PO8UrXegkF2zQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687013015; x=1689605015; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=euNHs8EIqgmHqR46TCGr3wBmtSwcYq+ARpCacNdV4Ek=; b=ccDPBy3R+KXV0tocuduwiShUZtL7IZ+jXWvv6mMBcvNx0FuWW/zP21R1sIBF88X5vs t182t8HENbcydVZGRh+jvPFEXJ8SuCB28S1H5sqgAjCVD7z0coiv8QNAHJMbR6rGCZpo UD405saQpTBlLYKUC00m1FvVJGVwxmKY0ZoPt3k7EzUDJHRuz7Wg9Six+dRvlhojlxjM A0uVfZhD0OWRSKZ9JBOOSu2P37tb+uvuehxqBpqYaBHMw87zD4KsfyUSmdf0dDOzFmrB /NqLeZGQebBoiizgCT/4In+5hkaAVw/LxKey8SdyxMzH06uXHN+/SEuzeaRJNiSPgatV /Clg== X-Gm-Message-State: AC+VfDyjyD+/4i84As9RzsJpiEDJwDrp+SXvSXN5/ex4NGj7Xk7+bCFc 9e5DrQBvFbKzMnbvqCM4QH0L3g== X-Google-Smtp-Source: ACHHUZ5TNx0Jv9iTOxR5J9lbiC/FiZ1rTA/Bypvl5OLhs7TCnP79YBcYNqPUhRKYDSb6Bm32kIWsgg== X-Received: by 2002:a05:620a:4d8c:b0:762:4773:d704 with SMTP id uw12-20020a05620a4d8c00b007624773d704mr1255435qkn.49.1687013015345; Sat, 17 Jun 2023 07:43:35 -0700 (PDT) Received: from localhost (cpe-142-105-146-128.nycap.res.rr.com. [142.105.146.128]) by smtp.gmail.com with ESMTPSA id w8-20020a05620a148800b0075b168fcde9sm7638102qkj.77.2023.06.17.07.43.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Jun 2023 07:43:34 -0700 (PDT) Date: Sat, 17 Jun 2023 10:43:32 -0400 From: Ben Boeckel To: Jason Merrill Cc: Maxim Kuvyrkov , gcc-patches , nathan@acm.org, fortran@gcc.gnu.org, gcc@gcc.gnu.org, brad.king@kitware.com Subject: Re: [PATCH v6 0/4] P1689R5 support Message-ID: <20230617144332.GB36863@farprobe> References: <20230606205025.3164738-1-ben.boeckel@kitware.com> <444B887D-CA74-47EF-AD02-F17D000FE9A4@linaro.org> <20230616194856.GA24524@farprobe> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.9 (2022-11-12) X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,WEIRD_PORT autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Jun 16, 2023 at 23:55:53 -0400, Jason Merrill wrote: > I see the same thing with patch 4 on x86_64-pc-linux-gnu, e.g. > > FAIL: g++.dg/modules/ben-1_a.C -std=c++17 (test for excess errors) > Excess errors: > /home/jason/gt/gcc/testsuite/g++.dg/modules/ben-1_a.C:9:1: internal > compiler error: Segmentation fault > 0x19e2f3c crash_signal > /home/jason/gt/gcc/toplev.cc:314 > 0x340f3f8 mkdeps::vec::size() const > /home/jason/gt/libcpp/mkdeps.cc:57 > 0x340dc1f apply_vpath > /home/jason/gt/libcpp/mkdeps.cc:194 > 0x340e08e deps_add_dep(mkdeps*, char const*) > /home/jason/gt/libcpp/mkdeps.cc:318 > 0xea7b51 module_client::open_module_client(unsigned int, char const*, > mkdeps*, void (*)(char const*), char const*) > /home/jason/gt/gcc/cp/mapper-client.cc:291 > 0xef2ba8 make_mapper > /home/jason/gt/gcc/cp/module.cc:14042 > 0xf0896c get_mapper(unsigned int, mkdeps*) > /home/jason/gt/gcc/cp/module.cc:3977 > 0xf032ac name_pending_imports > /home/jason/gt/gcc/cp/module.cc:19623 > 0xf03a7d preprocessed_module(cpp_reader*) > /home/jason/gt/gcc/cp/module.cc:19817 > 0xe85104 module_token_cdtor(cpp_reader*, unsigned long) > /home/jason/gt/gcc/cp/lex.cc:548 > 0xf467b2 cp_lexer_new_main > /home/jason/gt/gcc/cp/parser.cc:756 > 0xfc1e3a c_parse_file() > /home/jason/gt/gcc/cp/parser.cc:49725 > 0x11c5bf5 c_common_parse_file() > /home/jason/gt/gcc/c-family/c-opts.cc:1268 Thanks. I missed a `nullptr` check before calling `deps_add_dep`. I think I got misled by `make check` returning a zero exit code even if there are failures. Thanks, --Ben