From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by sourceware.org (Postfix) with ESMTPS id B92A63858C52; Thu, 14 Sep 2023 15:14:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B92A63858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-9aa0495f9cfso486700166b.1; Thu, 14 Sep 2023 08:14:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694704473; x=1695309273; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=usP7PAyokhujG4zSO3ifuiFm/An2cdWI2ZavAIyTZLg=; b=A1H/u3XMSOK53ejXpkVRL1EVQAbt1Xcb7rIHeaFM/goL5/mS6WDTh0GdjlZeuXtDtn ukUYT4rNuD8KWroh9m7FNYHihPMy+1nQpQqshsJ9ChHC1MyFfp8QDe+IiTzftDjFaLl7 3IdJPp6nrV52Jt49jDy3Vuaa3qmCS0HbYirjcF1PLN/FF0wJB+P25OzGpbfDuRxy2PYn vL0etZkzWeBJOxe7PJjNREsufp+snXrdUTQCADbuxxO33YREEz+iYB8PdshGwxjuTV3x 1AMH1ZPflmVGZ2z2OkHDlv9GCJ+yyisryXzs8KGrCZAVrDnukHqMvzn3yGpfh+xsIPPP Nu/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694704473; x=1695309273; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=usP7PAyokhujG4zSO3ifuiFm/An2cdWI2ZavAIyTZLg=; b=nOutIU5viHXDsTWm5+9AanwL2qlYCxeT1lz4G+Vd/0MwwLmRVfa5E5h0gkptAAoAAI bTLCAEtGp1LrdTMsZ/zUuLWiyzhsgQisCM2utJFmZA9YDecPgoDi4BKKU/MwcK9IN7e5 Kbc0YhcrbSpY6zAAyi/wX6Y/qDRtJXMUVqjvP0e7ujg/6noegXzwwkV1uU5GrSGT7XBU kIvnVZmHQQN4AVAP4YOIBg+o4guYNCjLCER2JlbaHhPpmkMLpQFCHi1wULeEya6q3r6s XZBdxU6W03gHlk1NspSrXDBJmuenjvpjKsMOcX9ScvNOCIMeFvgjz7wPzPkHDbEm3lY/ YYpA== X-Gm-Message-State: AOJu0YwcgShoHIHNFevqOot/GMvkrPg7jrLHFI2o1SgO29iP2hgb+vTL AGmT09E71ixBgg9IF77KaPM= X-Google-Smtp-Source: AGHT+IEKgm8yJcIynzObt8J1PVqm0cS/kGpAK5TV5GHKuQiTi3/5g/sB9H8QFsIDgOj2t62SD+fIXA== X-Received: by 2002:a17:907:7793:b0:9a2:143e:a070 with SMTP id ky19-20020a170907779300b009a2143ea070mr2885059ejc.20.1694704473125; Thu, 14 Sep 2023 08:14:33 -0700 (PDT) Received: from nbbrfq.loc (80-110-214-113.static.upcbusiness.at. [80.110.214.113]) by smtp.gmail.com with ESMTPSA id z15-20020a1709060acf00b0098d2d219649sm1148241ejf.174.2023.09.14.08.14.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Sep 2023 08:14:32 -0700 (PDT) Date: Thu, 14 Sep 2023 17:13:02 +0200 From: Bernhard Reutner-Fischer To: Julian Brown Cc: rep.dot.nop@gmail.com, , , , Subject: Re: [PATCH 8/8] OpenMP: Fortran "!$omp declare mapper" support Message-ID: <20230914171302.4bef7adc@nbbrfq.loc> In-Reply-To: <2aaa9204cded930d85531c3e2a32a6c07cf6d545.1693941293.git.julian@codesourcery.com> References: <2aaa9204cded930d85531c3e2a32a6c07cf6d545.1693941293.git.julian@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 5 Sep 2023 12:28:28 -0700 Julian Brown wrote: > + static bool > + equal (const omp_name_type &a, > + const omp_name_type &b) > + { > + if (a.name == NULL_TREE && b.name == NULL_TREE) > + return a.type == b.type; I'm curious if (and why) the type comparison above is safe and does not use gfc_compare_types () ? thanks, > + else if (a.name == NULL_TREE || b.name == NULL_TREE) > + return false; > + else > + return a.name == b.name && gfc_compare_types (a.type, b.type); > + }