From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) by sourceware.org (Postfix) with ESMTPS id 594143857340; Mon, 17 Jun 2024 07:51:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 594143857340 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 594143857340 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=212.227.15.15 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718610681; cv=none; b=lS5ro8U795VCJM4CEWi6nNPzAMFIs25d2KX2kBHE6RdNXtKHmigSs5m94gQceLDH2ZcPelDUUbwF3EX/FFmMlskgJr+vGpelwKFEDZZIeeV8buZWfuSOA10fD6Uvdj3+6qXQP7x0kn7njdlH7nJq6pmW4Gl6Lg4XiDB/sPSovUc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718610681; c=relaxed/simple; bh=4AHSGc2xbPR97SKfJwVJvY2Sqa0OHkjprgnViY7o2m8=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=HrzIdtnYjVNfOsuFWAYv5WornWT4LprFJBUsSaID3LXclsdKVsJ41L9dyknxmLEc6tLwjgvbyFbbC/4fSDLcB2QGt5KXciQEmLP/cHSNPgBnPko8aVJAceljd3zqpY0ymjlKb0njeztHP2mQ6zQP5/qCDtD25UdvjP+zlps7bJs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1718610678; x=1719215478; i=vehre@gmx.de; bh=lfieTiDvlD5DYRismvv76to9MNRo3/lcP4oT3uAeI5E=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:Message-ID:In-Reply-To: References:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=Dd7cbHar80sMF0207wvwJ6dSkCK/JNl8tq0HDZ5LGdt5/YE8fNlbyflnlZ425kQr lRxl9021p6bnCK9C0BoWQ41JQHHR5zTVD7zTA3WT1HEuOHm6yzpEk8PBWfmyZgzFj LEY48iYFLSOo5vYc5K8zzHgbbDuPQQM3oFyCW05XcdvQAv/L9GxmjGeeE86YjwL9b NWk//OLiuY3c1yYX92oxnR5ur7Kem8mARyIuvwuE+bhUsvzPOmNeat5MGXRdk258P MqZArF2efwY4sHNP8hcj/BjzGzRysJsSfhqfriNpe+KubAcRwXSblIbL6NADh60N8 1y+BkSZ6riZdFtjLug== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from vepi2 ([79.194.165.201]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MXXuH-1rstoI3oml-00J4QD; Mon, 17 Jun 2024 09:51:18 +0200 Date: Mon, 17 Jun 2024 09:51:17 +0200 From: Andre Vehreschild To: Harald Anlauf Cc: GCC-Patches-ML , GCC-Fortran-ML Subject: Re: [Patch, Fortran, 96418] Fix Test coarray_alloc_comp_4.f08 ICEs Message-ID: <20240617095117.096bd158@vepi2> In-Reply-To: References: <20240611161238.14634f57@vepi2> <20240614092256.48442c03@vepi2> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:hZhU4eCoFqHSaCmxtnmnQWyhZuZcjNM3myrDeg7RkmixDPiQKVl 51IfSJ/S9wovmaK4Gj1sye8sN1Z2GMYPNKNN0Myx2qgif+U3aHhzKh7OBgwQLyh3R13UILJ 6NoSJVO5xwUgi+lweQfbB/FcIkmK7MYbYF+cyKOKXKZFJcj4sSfoRyriy42XRV8ImHALuB4 D8nEcw4I5Q8GM2sw5YsCQ== UI-OutboundReport: notjunk:1;M01:P0:aSFpICt6NNI=;cUbXCvjKDsjGZ0IjPDeXNQx48yE ihIsbcNCLVTNoaiIuoSCn9/1cDFNMaWsuDfUKQJws0txC7r3lLgAZ9KAtg6Z7tnLaT0BZGJw+ xc/NRaoJoMi1ZijuPyY0HCMWLYnrKC6ng/UsV4k7n2A3gvjiLzlXGPgcN1dh/7XmddrXAu8zE 0ydXxLDBzYxfMRKQbS9o01VD4pGq2lU7uWPUOqjCaPsCYK7UOk2ZKZfYlEL+lEyh1OOucSYWw e7wzIZnD2N3dSuqujc9ydWPZAxQ9e73/5fCpPJOk9GOk5SqPAnPZUD4xKg2ZhAl83+l36xrgR xnhRnKQX37MQoZyqlh4sMCQWMi3xtLLMORR1Ah2OFVrGH+3kC9co0XPRnF3ztQDSAE3JnsQ49 lailT3jvNoOABU2kWRWnzCPVDS77Sjj9pXcF96izNgW3pU7IYTAfvtslnvF1GZ3r9NEW3mjGi YDGBn6K13+Fbw6yECtDKeeIYPNm4opHq1HVATX7CrQiEyDLN3BLoUO/t4yougebwAzmYpBLY/ yc6+AJaX6jLxAKooMAHBg/Kr3GsSDVpor1lst6VCApoDcv9uERONxelfBl147msnScmlE50XZ KF+cqZ/J1ftGYk6qCqRY6ULu5NniHl+Vg+yiQf8X96/KdBX1xRAuWYzGQrm99VwF5R/mM/loh IYEXp7yGPL8Ff/7I66tpOFqvHhmYSGk6FFvwKGBPVerXErs7bXeSd+mtviWRO/BWJ5VuGojvO jYZm4jtLL1xGCjBnOex8IXpXsUdpbBYOVJV5ToU5X09Yj3sODVBT9FET1y3Mbkefx55auA6gA vmXU2dX/Jc9oCMcnpSKJlctdNGpCiuqd7ToK6+RrKPdRc= X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Harald, thank you very much for the review. Committed as: gcc-15-1369-gdb75a6657e9 Regarding your question on the coarray-tests that are not in the coarray-directory: These test in most cases test only one method of implementing coarrays. I.e., they are either testing just -fcoarray=3Dsing= le or -fcoarray=3Dlib -lcaf_single, which are two different approaches. The test= s in the coarray-directory test all available methods to implement coarrays. Pu= shing all coarray-tests into the coarray-directory will fail a lot of them, beca= use the behavior of -fcoarray=3Dsingle and -fcoarray=3Dlib -lcaf_single is dif= ferent in some corner cases. That's why the coarray-tests in the main gfortran-dir a= re separate. I do understand why it may be confusing, but I don't see an easy solution.= Does this answer your question? Thanks again for the review. Regards, Andre On Fri, 14 Jun 2024 21:43:47 +0200 Harald Anlauf wrote: > Hi Andre, > > the patch looks fairly simple and obvious, so OK from my side. > > *** > > Regarding the testsuite: since you renamed one of the testcases > gfortran.dg/coarray_alloc_comp_* and moved it to gfortran.dg/coarray/, > I checked and noticed that there are other similar runtime tests for > coarrays (while some are compile-time only tests). > > Do we plan to "clean" this up and move more/all related runtime > tests to the coarray/ subdirectory? What is the general opinion on > this? > > *** > > Thanks for the patch! > > Harald > > > Am 14.06.24 um 09:22 schrieb Andre Vehreschild: > > Hi all, > > > > I messed up renaming of the coarray_alloc_comp-test. This is fixed in = the > > second version of the patch. Sorry for the inconvenience. > > > > Additionally I figured that this patch also fixed PR fortran/103112. > > > > Regtests ok on x86_64 Fedora 39. Ok for mainline? > > > > Regards, > > Andre > > > > On Tue, 11 Jun 2024 16:12:38 +0200 > > Andre Vehreschild wrote: > > > >> Hi all, > >> > >> attached patch has already been present in 2020, but lost my attentio= n. It > >> fixes an ICE in the testsuite. The old mails description is: > >> > >> attached patch fixes PR96418 where the code in the testsuite when com= piled > >> with -fcoarray=3Dsingle lead to an ICE. The reason was that the coar= ray > >> object was derefed as an array, but it was no array. Introducing the = test > >> for the descriptor removes the ICE. > >> > >> Regtests ok on x86_64-linux/Fedora 39. Ok for mainline? > >> > >> Regards, > >> Andre > >> -- > >> Andre Vehreschild * Email: vehre ad gmx dot de > > > > > > -- > > Andre Vehreschild * Email: vehre ad gmx dot de > =2D- Andre Vehreschild * Email: vehre ad gmx dot de