Re: Optimization of add_dt_to_dt_list() in resolve.c

[Andrew Benson <abenson@carnegiescience.edu>]

Steve,

I have just sent my copyright assignment documents back to the FSF, so I think 
it should be ok to submit my patch as soon as it has approval.

-Andrew

On Monday, June 11, 2018 11:17:10 AM PDT Steve Kargl wrote:
> On Fri, Jun 01, 2018 at 08:14:04AM +0200, Janus Weil wrote:
> > 2018-05-31 20:04 GMT+02:00 Andrew Benson <abenson@carnegiescience.edu>:
> > > One other question: for copyright assignment, who do I need to
> > > talk to to get the relevant form(s)?
> > 
> > I think you need to send a request to assign@gnu.org and
> > gcc@gcc.gnu.org in order to get the copyright assignment form. After
> > the form is mailed to you, you sign it and send it back to the FSF.
> 
> Andrew, I see that you've asked on gcc@gcc on June 1 about
> Copyright forms.  Has anyone responded?
> 
> I ask because my patch for PR fortran/68544 walks the
> gfc_derived_types list.
> 
> https://gcc.gnu.org/ml/fortran/2018-06/msg00054.html
> 
> and Thomas has approved the patch.  In my patch, I
> have
> 
> +static bool
> +is_dt_name (const char *name)
> +{
> +  gfc_dt_list *dt_list;
> +
> +  for (dt_list = gfc_derived_types; dt_list; dt_list = dt_list->next)
> +    if (strcmp(dt_list->derived->name, name) == 0)
> +      return true;
> +  return false;
> +}
> 
> we'll need to update this to deal with your change for a
> circular linked list.


-- 

* Andrew Benson: http://users.obs.carnegiescience.edu/abenson/contact.html

* Galacticus: https://bitbucket.org/abensonca/galacticus