From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 0ABFF3858C1F; Fri, 25 Aug 2023 08:34:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0ABFF3858C1F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="6.02,195,1688457600"; d="scan'208";a="17316233" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa1.mentor.iphmx.com with ESMTP; 25 Aug 2023 00:34:24 -0800 IronPort-SDR: 48zE6hk2ykJDv02S0b46zNSzxHWAAOfBeO5oTULRGLAeTYsVP5iRDz0DqJEI2KyPOF/58G1D6J SWaMGgSRdXw+54whJXSGcUIbYljxDDopMqF6xAu26mtReO8l+XFVjKkdagl1SaPSjQv/zimawp Jv822pD1J3dJjmTT+FESG1cxtLSPpb9ixyxA2Hqru9noPHe2nnsa62qDICjOvL2vyPsAwDa0cc SZHl59X4ZayF4EXwc8dYyk41ST7yEna3uIjOy9J+/u4Oz7gHPNbcAuNpMMZPN5DS+YRPRJmKrc zRU= Message-ID: <22cf226c-89d6-6931-2943-3bf988493904@codesourcery.com> Date: Fri, 25 Aug 2023 10:34:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH] fortran: Rename TRUE/FALSE to true/false in *.cc files Content-Language: en-US To: Uros Bizjak , "gcc-patches@gcc.gnu.org" , Fortran List References: From: Tobias Burnus In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 25.08.23 10:26, Uros Bizjak via Gcc-patches wrote: > gcc/fortran/ChangeLog: > > * match.cc (gfc_match_equivalence): Rename TRUE/FALSE to true/false. > * module.cc (check_access): Ditto. > * primary.cc (match_real_constant): Ditto. > * trans-array.cc (gfc_trans_allocate_array_storage): Ditto. > (get_array_ctor_strlen): Ditto. > * trans-common.cc (find_equivalence): Ditto. > (add_equivalences): Ditto. > > Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}. > OK for master? OK. Not really necessary but it makes the code more consistent. (We already heavily use true/false (5000+ times) and the patch changes the remaining 11 TRUE/FALSE.) Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955