From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id 893F1385841F; Thu, 24 Feb 2022 03:07:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 893F1385841F Received: by mail-pl1-x635.google.com with SMTP id bd1so515240plb.13; Wed, 23 Feb 2022 19:07:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=1CDcw8x9CR5XDt98wJYxewndN/zQt61WeDE8D5KEW6w=; b=noBfsHIucfzvqM7QdhkSpK9N7OaI642moIFeGyDWsOe7WuhxyR5ufgY6Jb2ZMdmVSi JE5eXqbCuM72jjF7Qk7pYgdm/6yb52OC1yDnVko33Wg0vxPIT/HaVZ3z3hZ7kgBxMK2G RduhupDj4pKTjgTrkA0nO/HxqdCIxLzeUXtQyI4dYsutiL+hWIo65c09Y7LM9eX64dmv o95DfHE7Rd0DbfWNTMF6qmy26OITcr2xABK9xW8oj2jy1TO40sAAVMvK+ByfGsr7yrs/ bGTLPJ1NuxBZbyWgywLOYqyh8KHDq2xgIlAkQCUx4ZMgcSCYAXjQxt3fGj2i82aV45wR LacA== X-Gm-Message-State: AOAM532PuP//j+tgmMLN8bVFeRL6tNqOKG4tR912gsuHq/YRViYDQd9+ 4erHzf341DtYBaZoRiASzLs= X-Google-Smtp-Source: ABdhPJxM4EdVxwE+qciX18a3HyNXaou0rCtoWRfk4uV1qiMmY/QdoReAL4cFpm+mCbDlg3JO3nFb9A== X-Received: by 2002:a17:902:db0d:b0:14f:b047:8d22 with SMTP id m13-20020a170902db0d00b0014fb0478d22mr746078plx.90.1645672056448; Wed, 23 Feb 2022 19:07:36 -0800 (PST) Received: from [192.168.1.28] ([50.46.203.130]) by smtp.gmail.com with ESMTPSA id q13sm1021978pfl.210.2022.02.23.19.07.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Feb 2022 19:07:36 -0800 (PST) Message-ID: <2a20af75-a28f-3e9c-913f-5810673e3c6a@gmail.com> Date: Wed, 23 Feb 2022 19:07:33 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] PR fortran/84519 - [F2018] STOP and ERROR STOP statements with QUIET specifier Content-Language: en-US To: Harald Anlauf , fortran , gcc-patches References: From: Jerry D In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Feb 2022 03:07:47 -0000 On 2/23/22 2:21 PM, Harald Anlauf via Fortran wrote: > Dear Fortranners, > > Fortran 2018 added a QUIET= specifier to STOP and ERROR STOP statements. > Janne already implemented the library side code four (4!) years ago, > but so far the frontend implementation was missing. > > Furthermore, F2018 allows for non-default-integer stopcode expressions > (finally!). > > The attached patch provides this implementation. > > That was not too much fun for the following reasons: > > - fixed format vs. free format > - F95 and F2003 apparently did not require a blank between STOP and > stopcode, while F2008+ do require it. > > This should explain for the three testcases. > > Regtested on x86_64-pc-linux-gnu. OK for mainline? > > One step closer to F2018! > > Thanks, > Harald > A minor comment.  Is there a way to also have a run-time test case? OK to commit now and additional test case can be added if necessary later. Regards, Jerry