From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by sourceware.org (Postfix) with ESMTPS id 515F63858D20; Wed, 5 Apr 2023 18:53:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 515F63858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1680720829; i=anlauf@gmx.de; bh=Kzlf58VylaJ8o50oI4XRpt6gE6FCRbDZS80SarXSJSc=; h=X-UI-Sender-Class:Date:Subject:To:References:From:In-Reply-To; b=a6MFwyk8799GGScDWW6BM98SFAc9JFpvLdADZWiQAISGbPiB8qK+4Um87c4pr4dOi q9G9jhdgpJdqBLJPJ8WuaKzbHqzyET857gurVXnpLq+t9ieS2NmaOlWt62gGPAhZaf pFUayubXWZmjxUMMkj4gvYzZqNKHY9hPEKaXK3KnKhGjuqH4YSXEdJJEewMeUlPg2I cQbzDVfno8nq4DbfrJ+B8tCedlRxlU5+rovuEEBkrSF8gFdJgY2PsozQKHR8ft/5IU 2bJsgAfkMz2DKHr4yel1/LQrUjpOP9kLXcwLEo/miFhO2wcavczeFB2DP6GuJWSVPF iC4I6KW9tgnjw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.178.29] ([93.207.89.166]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MfpOT-1qL8po1ULJ-00gEBJ; Wed, 05 Apr 2023 20:53:49 +0200 Message-ID: <2f926853-bf23-cdc3-6bf5-b75b7f7e872e@gmx.de> Date: Wed, 5 Apr 2023 20:53:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [Patch, fortran] PR104272 - finalizer gets called during allocate To: Paul Richard Thomas , "fortran@gcc.gnu.org" , gcc-patches Newsgroups: gmane.comp.gcc.patches,gmane.comp.gcc.fortran References: <072f908e-ab68-1087-7e86-f7a494d8f35b@gmx.de> Content-Language: en-US From: Harald Anlauf In-Reply-To: <072f908e-ab68-1087-7e86-f7a494d8f35b@gmx.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:VXFqnNTw4l7yt4OJ3HTJZ0GLOMLlfs/pYngd2vTmry4gnZF3bD5 3DLYgHLFxUt0EcDLhjsDQoCavbq0Via/8j+xtXyKYGANXV4MlCyXaUrtBq4evtZ0GzC4xNz vBtGK8vSMShxQWOmuCUhRFq8uRs/xOc4F0/DuLIMW3iajbyFXWmOJelReDjkwDVOUGBArhR u5bs433cN9J1aiAUxTtwg== UI-OutboundReport: notjunk:1;M01:P0:vYoDuNP7l50=;wwuCuoH0XPttrLh1sce1l8yRJ3v KpAocLPCekjN/p18imMfnQhuRCsxGrcfGTy8YK0vSpUOuQepSEmmJKzSXCJURug9m2iiRZwDq 2Fn2KEWl9LqtzPXBXkjNBuWV+Q9xqkF0AYo2+9mLSHOENwSaH7O+mGgW4LFYxOGz7Bxjc+/Je 44WN9wb8nEDJJ1cRX53tDC88tQ8Zmakj+AZLYN+zzS/Jemmu22NjCvKcELNNrfc4tI0wb2PSg Al/kNcA9nXu74QSV7Rxo3LGs5HiJ64ZykeZwZ8Y4u9QRrs3N5uSmz+xSYwpKfbNNYnr1N8wPy a0SxnXIqsEf+DTengG0b8iisHII6NlyUPfAcbwcFSJzvh7uWjbYLjpW+iDQ/ko3OWVr1cn9H5 r3c3vW2hwWMO6PircsOZkRHNKfTwsTVIDq65XAgWwX7aOebe9KgMrphmogFiK2d9487lmRz58 oSAAs/mjZp/PEzu9RkDRujG8Gz6uBHY3WZOQvALYcdoy0o48uBpcgPKtk8l5lspK/maKh47NJ ZpyCDuzGVIaVCGGyIUxF/aHpAMgRc6Eowl6YDivg+Nv9+VYP72y0RZnXlqs0UZZWFaA6fh/aG qzkNwe22ehNpv+GXv7zK7XNpsus9IxqoyFNhud93ONlIg4i7LAgBow7R0nfu8mRAT8DABi/Oi ZSnxZe81iAiIqXH+WLq5H1OkSLO7JprTG4X/Sf682TE4xZ7in6TaCNMIlUOGvHZ32R6Xwr04E wlpKsNag3E75AwpNTMNXRvIW6SGH56tJ14vlweT62fN5R9L+Nqdha2Jn96df5CgpTbvluBDEI 5i7w4QA9Ri/+yp7Gcbb1Tr7XidVxqDI7iWb3CvhG0/BaIfLXP7BJf99TY0S2QgkQ6ojYUedST eQ2E7yPcurhZlA6+i9K9SDwzMDzEYIC+EWZVyNXZGQS9A7I5AuFJtUPQQIho4YLtNhLBghxXv +viOBZCBWJXj3wRC8OuUmJXV2FQ= X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/5/23 20:50, Harald Anlauf via Gcc-patches wrote: > can you have a look again at the logic in the hunk touching > trans-stmt.cc (gfc_trans_allocate)?=C2=A0 I haven't checked in detail, > but it seems possible that you get a stale tmp in the > gfc_prepend_expr_to_block if (code->ext.alloc.expr3_not_explicit =3D=3D = 0). Oops, I meant if (code->ext.alloc.expr3_not_explicit !=3D 0) > Wouldn't it make more sense to move this condition before the braces > as part of the overall condition? > >> OK for mainline? > > Otherwise this LGTM. > > Thanks for the patch! > > Harald From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ciao.gmane.io (ciao.gmane.io [116.202.254.214]) by sourceware.org (Postfix) with ESMTPS id 188B43858D20 for ; Wed, 5 Apr 2023 19:00:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 188B43858D20 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=m.gmane-mx.org Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1pk8MT-0005U0-Or for fortran@gcc.gnu.org; Wed, 05 Apr 2023 21:00:01 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: fortran@gcc.gnu.org From: Harald Anlauf Subject: Re: [Patch, fortran] PR104272 - finalizer gets called during allocate Date: Wed, 5 Apr 2023 20:53:48 +0200 Message-ID: <2f926853-bf23-cdc3-6bf5-b75b7f7e872e@gmx.de> References: <072f908e-ab68-1087-7e86-f7a494d8f35b@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Content-Language: en-US In-Reply-To: <072f908e-ab68-1087-7e86-f7a494d8f35b@gmx.de> Cc: gcc-patches@gcc.gnu.org X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Message-ID: <20230405185348.zxQU_T4aWCQ7xOw0UnvM1KyCH20SrqAxM7-fjb2Z8l8@z> On 4/5/23 20:50, Harald Anlauf via Gcc-patches wrote: > can you have a look again at the logic in the hunk touching > trans-stmt.cc (gfc_trans_allocate)?  I haven't checked in detail, > but it seems possible that you get a stale tmp in the > gfc_prepend_expr_to_block if (code->ext.alloc.expr3_not_explicit == 0). Oops, I meant if (code->ext.alloc.expr3_not_explicit != 0) > Wouldn't it make more sense to move this condition before the braces > as part of the overall condition? > >> OK for mainline? > > Otherwise this LGTM. > > Thanks for the patch! > > Harald