From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
To: Mikael Morin <morin-mikael@orange.fr>,
Thomas Koenig <tkoenig@netcologne.de>,
Mikael Morin <mikael@gcc.gnu.org>,
gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org
Subject: Re: [PATCH 09/10] fortran: Support clobbering of variable subreferences [PR88364]
Date: Sat, 17 Sep 2022 23:24:04 +0200 [thread overview]
Message-ID: <327611EA-65FC-4AB6-8D7C-C3A9DFC2325F@gmail.com> (raw)
In-Reply-To: <a2a6d094-c4f2-980b-3130-efba32d50262@orange.fr>
On 17 September 2022 21:50:20 CEST, Mikael Morin <morin-mikael@orange.fr> wrote:
>Le 17/09/2022 à 21:33, Mikael Morin a écrit :
>> The testcase from the patch was not specifically checking lack of side-effect clobbers, so I have double-checked with the following testcase, which should lift your concerns.
>>
>The dump matches didn’t fail as expected with patch 2/10 reversed.
>This testcase should be better.
! { dg-final { scan-tree-dump-times "456" 0 "optimized" { target __OPTIMIZE__ } } }
I'd spell this as scan-tree-dump-not, fwiw.
That said, plain scan-tree-dump is usually only viable in arch influenced checks which in fortran we do not usually have. Here, we should for the most part use -not or a specific -times.
I think you had a check for integer(kind=4) in there, too, which might not work all that well for -fdefault-integer-8 or, for the corresponding real scan, -fdefault-real-8, eventually. Easily tweaked on top if anyone (certainly will) complain later on, though..
fore, either way, I'd say :-)
thanks,
next prev parent reply other threads:[~2022-09-17 21:24 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 20:24 [PATCH 00/10] fortran: clobber fixes [PR41453] Mikael Morin
2022-09-16 20:24 ` [PATCH 01/10] fortran: Move the clobber generation code Mikael Morin
2022-09-16 20:24 ` [PATCH 02/10] fortran: Fix invalid function decl clobber ICE [PR105012] Mikael Morin
2022-09-16 20:24 ` [PATCH 03/10] fortran: Move clobbers after evaluation of all arguments [PR106817] Mikael Morin
2022-09-16 20:24 ` [PATCH 04/10] fortran: Support clobbering with implicit interfaces [PR105012] Mikael Morin
2022-09-16 20:24 ` [PATCH 05/10] fortran: Support clobbering of reference variables [PR41453] Mikael Morin
2022-09-16 20:24 ` [PATCH 06/10] fortran: Support clobbering of SAVE variables [PR87395] Mikael Morin
2022-09-16 20:24 ` [PATCH 07/10] fortran: Support clobbering of ASSOCIATE variables [PR87397] Mikael Morin
2022-09-16 20:24 ` [PATCH 08/10] fortran: Support clobbering of allocatables and pointers [PR41453] Mikael Morin
2022-09-16 20:24 ` [PATCH 09/10] fortran: Support clobbering of variable subreferences [PR88364] Mikael Morin
2022-09-17 17:03 ` Thomas Koenig
2022-09-17 19:33 ` Mikael Morin
2022-09-17 19:49 ` Bernhard Reutner-Fischer
2022-09-17 19:50 ` Mikael Morin
2022-09-17 21:24 ` Bernhard Reutner-Fischer [this message]
2022-09-18 6:12 ` Richard Biener
2022-09-18 9:10 ` Mikael Morin
2022-09-18 10:23 ` Thomas Koenig
2022-09-18 18:32 ` Harald Anlauf
2022-09-18 20:55 ` Mikael Morin
2022-09-19 7:11 ` Mikael Morin
2022-09-19 19:46 ` Harald Anlauf
2022-09-19 20:50 ` Mikael Morin
2022-09-20 6:54 ` Thomas Koenig
2022-09-20 8:46 ` Mikael Morin
2022-09-20 21:08 ` Harald Anlauf
2022-09-20 21:08 ` Harald Anlauf
2022-09-21 9:57 ` Thomas Koenig
2022-09-21 18:56 ` Mikael Morin
2022-09-21 19:12 ` Harald Anlauf
2022-09-21 19:12 ` Harald Anlauf
2022-09-18 20:43 ` Mikael Morin
2022-09-18 10:48 ` Richard Biener
2022-09-19 7:31 ` Mikael Morin
2022-09-19 7:58 ` Richard Biener
2022-09-16 20:24 ` [PATCH 10/10] fortran: Support clobbering of derived types [PR41453] Mikael Morin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=327611EA-65FC-4AB6-8D7C-C3A9DFC2325F@gmail.com \
--to=rep.dot.nop@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=mikael@gcc.gnu.org \
--cc=morin-mikael@orange.fr \
--cc=tkoenig@netcologne.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).