From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by sourceware.org (Postfix) with ESMTPS id 27BB33857C72; Sat, 17 Sep 2022 21:24:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 27BB33857C72 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x533.google.com with SMTP id y8so29239958edc.10; Sat, 17 Sep 2022 14:24:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:to:from:date:from:to:cc:subject:date; bh=rFG37leHbSGDlH7CFHnbncEjyDcLiYBwC1PCi1RH8YQ=; b=BdrcMCF3wb9AL6RqbeyDNmCEPgVi29b95DbkOZHv+OTRsQ1Rfi6msVxmEOIjB6Q4mh U20S71BJuizld2e8C3tDVxN6Z232KAXOhx7EjkyQVPlbeaS/g9qo+11GLav78+9vaYve 8wTpnTAghsdmezjJQ1UHj7LX3WaS+s7lv2D44t0hbnskOTsgnS7ofQ6wUIXEJfqV2eoy nyoJ1V79mnPSt7cFqi7UNgjwMd68IRGBQWO+H2pyr2llN+ak7xjYjJ6oQHxoG1lPVPua g0Znrcr/t100pGczqgx4vTmch7iR34mlRlFee0ZR+Ac6LmDHe8r31Uu0rnxr9X9qfeay XkFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:to:from:date:x-gm-message-state:from:to:cc :subject:date; bh=rFG37leHbSGDlH7CFHnbncEjyDcLiYBwC1PCi1RH8YQ=; b=VEfhDbbUf12IcOaBHL0UzULexkxzkQv1B/SWvTVEKRKj0Od7FLGTBVwq2SFzrejoYo GQ1OIrx6guIaruc+ke9xVI7yENB2tSmdNgppb/S5Tc4HExtq3HXNCRPF8Qcz/LsoWuh8 OOXzZXA/jfOhot9JaLLYOnmgySDEeg7AAJmLUcCa2jOtF/va9cspLpTzL7SzcaoajhXv NjKSVSof6+xYskCdT/brqUxTWD2rqtHOZ2+kE2Zlxa2KyD+ugZVewMoYhGmsp9krOv3f L8c6vdXGev1ohP3Z+ncREhXoM2W9cpWOC2VJ1aSirrbeSaUKx88EvQLHeh218wDPLgRO SZ4w== X-Gm-Message-State: ACrzQf0Bs1grUx4CZFcOEW6oGgh3xdtyERT6vZLkil4qBMUK8eU+8Wal Z75cW0cUtyyaUjSK1KSB9Z0= X-Google-Smtp-Source: AMsMyM6D0t/eTctOqHc2qZ1iTn0ZA6IaWxI/eUdzQ9AZCbA1tp+cOtyGxKXTJ8n09Tr5fPIqdi2IwQ== X-Received: by 2002:a05:6402:5507:b0:452:183f:16d1 with SMTP id fi7-20020a056402550700b00452183f16d1mr9388239edb.96.1663449846804; Sat, 17 Sep 2022 14:24:06 -0700 (PDT) Received: from [127.0.0.1] (80-110-214-113.static.upcbusiness.at. [80.110.214.113]) by smtp.gmail.com with ESMTPSA id z25-20020aa7d419000000b0044efc3d4c4csm16574613edq.33.2022.09.17.14.24.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Sep 2022 14:24:06 -0700 (PDT) Date: Sat, 17 Sep 2022 23:24:04 +0200 From: Bernhard Reutner-Fischer To: Mikael Morin , Thomas Koenig , Mikael Morin , gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_09/10=5D_fortran=3A_Support_clobb?= =?US-ASCII?Q?ering_of_variable_subreferences_=5BPR88364=5D?= In-Reply-To: References: <20220916202439.549820-1-mikael@gcc.gnu.org> <20220916202439.549820-10-mikael@gcc.gnu.org> <3edab734-f5bb-5557-ff98-b0ce47d7c510@orange.fr> Message-ID: <327611EA-65FC-4AB6-8D7C-C3A9DFC2325F@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 17 September 2022 21:50:20 CEST, Mikael Morin = wrote: >Le 17/09/2022 =C3=A0 21:33, Mikael Morin a =C3=A9crit=C2=A0: >> The testcase from the patch was not specifically checking lack of side-= effect clobbers, so I have double-checked with the following testcase, whic= h should lift your concerns=2E >>=20 >The dump matches didn=E2=80=99t fail as expected with patch 2/10 reversed= =2E >This testcase should be better=2E ! { dg-final { scan-tree-dump-times "456" 0 "optimized" { target __OPTIMIZ= E__ } } } I'd spell this as scan-tree-dump-not, fwiw=2E That said, plain scan-tree-dump is usually only viable in arch influenced = checks which in fortran we do not usually have=2E Here, we should for the m= ost part use -not or a specific -times=2E I think you had a check for integer(kind=3D4) in there, too, which might n= ot work all that well for -fdefault-integer-8 or, for the corresponding rea= l scan, -fdefault-real-8, eventually=2E Easily tweaked on top if anyone (ce= rtainly will) complain later on, though=2E=2E fore, either way, I'd say :-) thanks,