From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by sourceware.org (Postfix) with ESMTPS id 8709B3858D28; Tue, 22 Aug 2023 18:45:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8709B3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1692729917; x=1693334717; i=anlauf@gmx.de; bh=nRU2aT0SoibXJUtIP+UK/ana48ctYn29CYFKdoLN4L8=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=ncEppIlPVjmSHozcQ5D4amq9TLvSS7E+nsnRE/y5zWGPLP9hj4C0XDIK03rrUUHy5hBN7VY MG7y9SS7+079qEzRmxE+r3H9gCHKbmm0Kfbsyzbpu+XvqgwGYxnbk8CLar7Q1GCyTMBIg5qzp FT7TnL4KqBi0/4HPG9wksNSfc695kHOLnjdF8YYlrJ498VKHBb14555R88as1KVmtJJIPuk+W 6LEP7VEYOF1AMuTsnEu95IfXD1hETJ0658y4KDvVhZWXZ1HZm7OcVL4wD8eA6T3wcgUdVARlX 32/hLBMHeLm0uga8Nb28PWZtS52cxNYRr7JRMVa8sUdhHyscmHiQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.178.29] ([93.207.93.177]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M59C8-1qXQRl1HaG-001B5l; Tue, 22 Aug 2023 20:45:17 +0200 Message-ID: <32a1acd3-11c6-4692-a940-87f343c862f4@gmx.de> Date: Tue, 22 Aug 2023 20:45:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Fortran: implement vector sections in DATA statements [PR49588] Content-Language: en-US To: Paul Richard Thomas Cc: fortran , gcc-patches Newsgroups: gmane.comp.gcc.patches,gmane.comp.gcc.fortran References: From: Harald Anlauf In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:jDFBNdjbvd6YYnCKky5rfHI1V15aoRwH+jGUev7faEkrknkU2Xe +ngqhjVFKDFU5emOLoxd+zrF1P52rfGjs27Tr/+AtZwfhoDdVskE27dV8JgKBanVyYaSKKQ UjzvLGhK0INg13l52hLbHomWY8pV8GlkdC18EJpzDaT2kw4ug3xLiTws/f8KZ+DbZWFJq2T oP0O+8dSHsrbNQP1gCjkA== UI-OutboundReport: notjunk:1;M01:P0:L8/Bwb8z/J4=;XCzSp5HGum20nwN3GL9YYrLZoDt GB3VEWulrd0/rViom6EmnE1NHXkmbayhYVug5T4EyhGF2dDgWrWNZBOoYHvKz+G/qyi+x7Uex rwHF5aAjq3OtwFF8iSe0pDPQ+k0xcj28gr3lR4LGG13FI12DCG0R+KFvOqLi/dKSyFbI/CGe7 2UUj73nGzBPoEAxerFDuS3yaFYCiSMMVZEB1LxUaavTkHFlMsxf122w9aGmDv3DswQXpt8Esz i2S5j1neBGom+g+vI3patabXlnb43Isk/QlFyTLlNwc3LTIHyWavshq0WUTXFnDljPY6BnwdB aD4uuid8dNq/U1eUNh9pNPrGxMdsvzalNXmWUgSCa7VVhJLc5Z7673R1StYG/wErlxzwQ5BMF wLX7IEi8VfmMxBE1/PvySllE4vsDTH4y4yVP9hC6nlOYyQXSdCzq2/LoyGTe9gozMz1E58TW7 RlXtGjhbsEfbGpbwZnA1dPRHrchhN0lx1XQfblo0hIFX/qlLT/D9B0fiM7e2ad0ywgnpCDDDZ jSx3ub5VNlJqX9CkKxvHmQH+bpP6fQX2Pnt8tb1kbm/AXvV8YZP4rYmeviNX1l+MedWz+JbH7 W+Et8H8HbEWE49kdetQ8ZeXyC+X0FXfEvwQeezK1QK14j6IRXjd3IHXSQMRUHtpcEsK57YS8s SpYVe+mPA44QYRhSKXfzz0A3vsvO1OC1IxAQWxTiPc15r/tlHW93RptioQyXRXqfANDe7Wwmi iQEtGJVUWSoSY5tUkfSZqRWxjyRPWtfqxCX9sUXADX/ffw99VJd2/sLxWWnbP3fi+gB+luCZo 6y4NvsJNylcw7e7Gj9wuKqofjGY4dIih01PSzUfcEKA8L8PVB0z8HX+qMH1veFAtNCaeuMcf9 o14dvgMFgJha8quI7WJrEGHiKydRqjBQ6UZ3uWwQWSFIG91tNo/Oig06RMXCec2ZLb8jxZK78 4z7zbjNvU/t4m2c7U5ob0ki8LJs= X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Paul, Am 22.08.23 um 08:32 schrieb Paul Richard Thomas via Gcc-patches: > Hi Harald, > > It all looks good to me and does indeed make the code clearer. OK for tr= unk. > > Thanks for the patch. thanks for the review! > I was shocked to find that there are 217 older bugs than 49588. Does > anybody test older bugs to check if any of them have been fixed? I am not aware of this being done systematically. At the same time, we have over 100 PRs marked as regression, with a few being fixed on mainline but not backported (or undecided whether to backport). Fixing and/or closing them might be low-hanging fruits. There are also far more than 100 TODOs in gcc/fortran/*.cc ... And with the usual PRs, there's enough work left for all kinds of contributions. Cheers, Harald > Paul > > On Mon, 21 Aug 2023 at 20:48, Harald Anlauf via Fortran > wrote: >> >> Dear all, >> >> the attached patch implements vector sections in DATA statements. >> >> The implementation is simpler than the size of the patch suggests, >> as part of changes try to clean up the existing code to make it >> easier to understand, as ordinary sections (start:end:stride) >> and vector sections may actually share some common code. >> >> The basisc idea of the implementation is that one needs a >> temporary vector that keeps track of the offsets into the >> array constructors for the indices in the array reference >> that are vectors. >> >> Regtested on x86_64-pc-linux-gnu. OK for mainline? >> >> Thanks, >> Harald >> >