From: Andrew Stubbs <ams@codesourcery.com>
To: Janne Blomqvist <blomqvist.janne@gmail.com>
Cc: Toon Moene <toon@moene.org>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Fortran List <fortran@gcc.gnu.org>
Subject: Re: [PATCH 08/25] Fix co-array allocation
Date: Thu, 20 Sep 2018 16:23:00 -0000 [thread overview]
Message-ID: <32c9e35c-2edd-02c5-bbf9-57efdb3d4c16@codesourcery.com> (raw)
In-Reply-To: <CAO9iq9F0Txh9v6brug-Ytj+tt8=igYQod6hbfWyUMM7QZv1x=A@mail.gmail.com>
On 20/09/18 16:56, Janne Blomqvist wrote:
> Ok, looks good.
Thanks.
> There are some other remaining incorrect uses of integer_type_node (at
> least one visible in the diff), but that can be done as a separate patch
> (not saying you must do it as a precondition for anything, though it
> would of course be nice if you would. :) )
I'm not confident I can tell what should be integer_type_node, and what
should not?
Once it gets to build_call_expr_loc it's clear that the types should
match the function signature, but the intermediate values' types are not
obvious to me.
Andrew
prev parent reply other threads:[~2018-09-20 16:23 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <024e798b9539b765a1259cfc9cb2f1dc480b24ca.1536144068.git.ams@codesourcery.com>
2018-09-05 16:54 ` Fwd: " Toon Moene
2018-09-05 17:02 ` Bernhard Reutner-Fischer
2018-09-05 18:07 ` Janne Blomqvist
2018-09-19 16:24 ` Andrew Stubbs
2018-09-19 21:18 ` Damian Rouson
2018-09-19 22:30 ` Andrew Stubbs
2018-09-19 23:09 ` Damian Rouson
2018-09-20 20:02 ` Thomas Koenig
2018-09-20 20:56 ` Damian Rouson
2018-09-21 7:33 ` Toon Moene
2018-09-23 11:40 ` Janne Blomqvist
2018-09-21 16:25 ` OpenCoarrays integration with gfortran Jerry DeLisle
2018-09-21 19:13 ` Janne Blomqvist
2018-09-21 19:37 ` Richard Biener
2018-09-21 20:17 ` Damian Rouson
2018-09-21 23:23 ` Jerry DeLisle
2018-09-23 9:47 ` Toon Moene
2018-09-23 16:48 ` Bernhard Reutner-Fischer
2018-09-23 19:17 ` Toon Moene
2018-09-23 20:19 ` Bernhard Reutner-Fischer
2018-09-24 10:58 ` Alastair McKinstry
2018-09-27 12:29 ` Richard Biener
2018-09-27 13:32 ` Jorge D'Elia
2018-09-20 15:56 ` [PATCH 08/25] Fix co-array allocation Janne Blomqvist
2018-09-20 16:23 ` Andrew Stubbs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32c9e35c-2edd-02c5-bbf9-57efdb3d4c16@codesourcery.com \
--to=ams@codesourcery.com \
--cc=blomqvist.janne@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=toon@moene.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).