From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fortran-return-51051-listarch-fortran=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 124739 invoked by alias); 20 Sep 2018 16:23:33 -0000
Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <fortran.gcc.gnu.org>
List-Subscribe: <mailto:fortran-subscribe@gcc.gnu.org>
List-Post: <mailto:fortran@gcc.gnu.org>
List-Help: <mailto:fortran-help@gcc.gnu.org>, <http://sourceware.org/lists.html#faqs>
Sender: fortran-owner@gcc.gnu.org
Received: (qmail 124355 invoked by uid 89); 20 Sep 2018 16:23:33 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*i:tt8, H*f:tt8, H*i:sk:igYQod6, H*f:sk:igYQod6
X-HELO: relay1.mentorg.com
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Sep 2018 16:23:31 +0000
Received: from nat-ies.mentorg.com ([192.94.31.2] helo=svr-ies-mbx-01.mgc.mentorg.com)	by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256)	id 1g31jl-0003tV-Q0 from Andrew_Stubbs@mentor.com ; Thu, 20 Sep 2018 09:23:29 -0700
Received: from [172.30.90.243] (137.202.0.90) by svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Thu, 20 Sep 2018 17:23:24 +0100
Subject: Re: [PATCH 08/25] Fix co-array allocation
To: Janne Blomqvist <blomqvist.janne@gmail.com>
CC: Toon Moene <toon@moene.org>, GCC Patches <gcc-patches@gcc.gnu.org>,	Fortran List <fortran@gcc.gnu.org>
References: <024e798b9539b765a1259cfc9cb2f1dc480b24ca.1536144068.git.ams@codesourcery.com> <7f5064c3-afc6-b7b5-cade-f03af5b86331@moene.org> <CAO9iq9HSBfLANeKKUD=8byyNoujnWG2+Q7wGGWwXf3jmiS5ddA@mail.gmail.com> <9290b55e-b12a-838a-5943-0c72d040dc3f@codesourcery.com> <CAO9iq9F0Txh9v6brug-Ytj+tt8=igYQod6hbfWyUMM7QZv1x=A@mail.gmail.com>
From: Andrew Stubbs <ams@codesourcery.com>
Message-ID: <32c9e35c-2edd-02c5-bbf9-57efdb3d4c16@codesourcery.com>
Date: Thu, 20 Sep 2018 16:23:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <CAO9iq9F0Txh9v6brug-Ytj+tt8=igYQod6hbfWyUMM7QZv1x=A@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2018-09/txt/msg00144.txt.bz2

On 20/09/18 16:56, Janne Blomqvist wrote:
> Ok, looks good.

Thanks.

> There are some other remaining incorrect uses of integer_type_node (at 
> least one visible in the diff), but that can be done as a separate patch 
> (not saying you must do it as a precondition for anything, though it 
> would of course be nice if you would. :) )

I'm not confident I can tell what should be integer_type_node, and what 
should not?

Once it gets to build_call_expr_loc it's clear that the types should 
match the function signature, but the intermediate values' types are not 
obvious to me.

Andrew