From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) by sourceware.org (Postfix) with ESMTPS id AA2B8388E823; Mon, 9 May 2022 19:34:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AA2B8388E823 X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.178.29] ([93.207.89.237]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N4hvR-1nyLza2vTD-011ihv; Mon, 09 May 2022 21:34:01 +0200 Message-ID: <37207063-62ba-27b4-8c10-f530c2cd1273@gmx.de> Date: Mon, 9 May 2022 21:34:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] PR fortran/105501 - check for non-optional spaces between adjacent keywords Content-Language: en-US To: Mikael Morin , fortran , gcc-patches Newsgroups: gmane.comp.gcc.patches,gmane.comp.gcc.fortran References: From: Harald Anlauf In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:JOw/QdsrtBt7DrfFUAA+hpIQhZK7mvgr8ymIVM+fI9axVyPcxuD 1uimdu/WcSJDBzQ7L4rTCLOIETp0BP7At5DW2jDytJp5X7dd1ySJE2uGwMcrHJG9I1qxoPk VBM+0V7WbJVlaRssME9YcW4pO2zclgkUBgz6uX6/lvt30uqPGT+7HySXg8OYew3HRJAi7RL a1pb0b3UCEURF7lgkeGNw== X-UI-Out-Filterresults: notjunk:1;V03:K0:XAvfrjbnNko=:lyRjZoxNRbh4Te1x11pJ4Q o6l+gTGXBV4D9C9zKp0kv740DVbjO1GWXC+V7aFzA71PCLZEaj8fbQC4vRsc6tninbCkHeSb+ jH/rG2VdH7n/t1XA5q8Z6n2sXFuTYozL6uNaY0kX24VGGEtLyiAi2nzCs1pY0TOuJ4hRR5NO8 9XT2u4EqZtQR4KWFRAWPcdoYJRgbvrohclatS9LZqrCZdeseBWCfyhmYbJayzEvLOaV36vqBg wyQvtz0Uv1SiyEdIZX+YXZDoTp3o6Q/40jsJ0s/j2Dz88spifETcLUoNly6kzc5ncCYhcskDb AeVqhFvl85xele9M6XImmL2kprrRxq2+vAbwxiYBw9RvPAlx3oDGdJQjBDIXwriE/CYgILRN/ VGIqpprWkxPT47z0CqzSM6hYng8qRaWlV1ATI3iTTVqLiosLOdIE0H5jYJ2kglimLr+Yc2CoL FFnfdJ39wK7nk5ahRmqtYp+wDueDyM0+lx2oRwoGyNCpG6e8mKOEqxNNOuQwUZgIVe1czVyww AYKJzFmYji55mldZ2Tz//23VMfflwTm66JoFA3/aEX++VTLItYw5oGnMH8ud3IaxbHkHWcPEj wcXVjC5O2WDWSOlegwcsN1Q7rG81Gpx2QBU7phxpDBIfiXOfDTzlBn6Hb/OHhvdyu8C5FV/Lj QJQ52kMlg4MUqN4wKgvBxJMySOgrcKZTfJWAsEHmwU7wL2bnlk/p4GLJwUDCUpZonGMOaBblc 8nFUyZbBH4iBljMl9VmwqtTpf4C4t2ixsSg9IzyL8P5szzuCslk+DTwXIgf8xTaDeUt3DajQ+ MG1w3cS69lF6TtcvGVg4n/1aiZ4GYGupWIxEowhCzx3I+GCkZ7d/K1bidu35xlM12VutThct3 WXlMgFYTXDgIOtUALQTs4xcKtWIp8ISIqyw4ccoMC3eiP7DBTKjkJbBVampHNEfmfyWQ9e7tD 6CQNHeIw4teWhcj6XB7yY0vWy90ZS2DBSd5Z25cvtY3KoYaHuD9cXUKtvepsBzM32/v72a9HU MtQ+EVR43aQJeu0iM8r8NBFshS643SbnG4G4o1odghmZZzAtimzF1HtOP601Xou+/g== X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 May 2022 19:34:05 -0000 Hi Mikael, Am 09.05.22 um 20:24 schrieb Mikael Morin: > The fix itself looks good.=C2=A0 Regarding the test, I don=E2=80=99t und= erstand the > problem.=C2=A0 Can=E2=80=99t there be multiple subroutines, each having = one (or more) > problematic statement(s)? that's why I tried but failed. Example: subroutine a errorstop end subroutine b errorstop end This now gives just one (the first) error, after which it bails out: xxx.f90:2:3: 2 | errorstop | 1 Error: Unclassifiable statement at (1) That is the reason I mentioned it. I'll commit the patch as-is. Thanks for the review! Harald