From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by sourceware.org (Postfix) with ESMTPS id 981DF385E012; Tue, 25 Jan 2022 21:30:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 981DF385E012 X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.178.29] ([93.207.86.57]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MeU4s-1meW5X099o-00aTSB; Tue, 25 Jan 2022 22:30:27 +0100 Message-ID: <3a178fe2-7e38-f4f5-9efd-b861f9740abd@gmx.de> Date: Tue, 25 Jan 2022 22:30:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PR103970, Fortran, Coarray] Multi-image co_broadcast of derived type with allocatable components fails^ Content-Language: en-US To: Andre Vehreschild , GCC-Patches-ML , GCC-Fortran-ML Newsgroups: gmane.comp.gcc.fortran,gmane.comp.gcc.patches References: <20220125173213.1265f8e3@vepi2> From: Harald Anlauf In-Reply-To: <20220125173213.1265f8e3@vepi2> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:gPTm/qnf2ljFEyLFa/vbXXV8Y9WcMbGaO5OSfTPHYlUKAAXCxD7 GabGWwLnzb0g8YPZU0Y5w5Z/oyUVtQb7HRTdMejFY1L8Vi9z6xMIjdMOJT3riW0myqfwvMY h7Gba1BgeIXNFsqlwdSXd7GD8F37EzFeUnTMIEQEEWwzEMyPCF/BWhdkj78GwlJPBM2XGUm y7OQyYKNbZbN0nxCedxkw== X-UI-Out-Filterresults: notjunk:1;V03:K0:h6BDX+lLaos=:DQwxjf1RkaSN0rFJ9SuBp2 jrgdrdtJaSnk9Cm67qZT8Lrm+vfBI5p6+++1YbCGdDJMwQWNx8wzsEcY55VXe4egbHW+Xhl3m 1hPUJS6MhG0VSR1wKjn/I5qTU/p+GnxHdijKcHSjI2KjC6PgxE80wScOZ+RP0pk5R0oGcgn/X 8NoLzr1G0ZEsJusLp2N0ij0YBHs3zHOaOLGOa8Ov7GI/7dSV9mEpchIDHMCfszfcjc+lHwqgi qjnOXmD0SEUOt6KCicXYayurXcr2X3KNoOy5cM6trFKVJyfvTYY8kwaISdF/tGTDqu4gOa6Pr 8WsodMJupy4MAOMg3CC06WWwnrRUqy6I/7QgHqTpJ7v3vT2GSE+nCR4hnH2f0ritC8JvcCsfL 3GxGqZoWFu9MEw911TGoCONuAZ7h2Liu752zq7o2mM9WVeHrEPg5ajmw3iMhfJ8CnpvAP1pNu zErXYSZ8tyNI4o27vtj0+rnvFM5czFFbu4ncLQvr/SlWIhfTAXXKUrxiDJwmgiMB+GsuvDf03 yEonoOC2ktgI6I2WA/sblUqNVhhCaZC0FuHtg4AEXyrbOAMmOtuOdBaoT66UZjtaju9OnGNIo 2CoHxad4YP1GfqQ3j7S+dP8vDeTtXLL20RNcWdrUSRYQWiBveIPq/SdVEv8A8uWDIWR+VZkIY r1G00o+ZsKYftbl2jSVF/4zMK2qb15kfst3heO9cfgo1SGSXodYoC2Bql/dSTuoF8AZWK1BjJ aoStvJnsq3IuBL4m/b89NXEhTvdfXRJwhq83LbFUNcca3Bijm7scKHC8Cp58CMPYB32d0eyui h9wmUiWERNhZWNsIN9KkfHrsMQoC14xnZnzCk3+h92ai1Mk3cAVMEf4djIHhtIOH9mB/bWe8Z clC5iGrrNWmuNExk1QQyB0c3A9wHhsdHVyqKpYEn7fK0O5mmum1okjDd5FxW1X6Z75CfDy3v3 jrCdQiFKoLDpYajXOxOyiWltkJmTZpPfafA7yMrNLltZoaoRq+PcgyQYMZaKZQYprY5Eg3AEk yjJq4GdMd2/cAgMR3QluGJyNQhUvYWySniyCY4iMmNNDUeu6CXM+KJ46zD7FRkz3UDqiai4H7 ZWx4PzbT3vwvug= X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Jan 2022 21:30:30 -0000 Hi Andre', Am 25.01.22 um 17:32 schrieb Andre Vehreschild via Fortran: > Hi all, > > attached patch fixes wrong code generation when broadcasting a derived t= ype > containing allocatable and non-allocatable scalars. Furthermore does it = prevent > broadcasting of coarray-tokens, which are always local this_image. Thus = having > them on a different image makes no sense. > > Bootstrapped and regtested ok on x86_64-linux/F35. > > Ok, for trunk and backport to 12 and 11-branch after decent time? > > I perceived that 12 is closed for this kind of bugfix, therefore asking = ok for > 13. I do not think that 12 is closed for bugfixing, especially not for fortran. And if my cursory reading of the patch is not misleading, the impact of the patch is really limited to coarrays. You may want to wait for another 1-2 days for additional comments. If not, it is OK from my side. Thanks for the patch! Harald > Regards, > Andre > -- > Andre Vehreschild * Email: vehre ad gmx dot de From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ciao.gmane.io (ciao.gmane.io [116.202.254.214]) by sourceware.org (Postfix) with ESMTPS id 7BEBC3853801 for ; Tue, 25 Jan 2022 21:30:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7BEBC3853801 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1nCTOZ-0000jy-HT for fortran@gcc.gnu.org; Tue, 25 Jan 2022 22:30:31 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: fortran@gcc.gnu.org From: Harald Anlauf Subject: Re: [PR103970, Fortran, Coarray] Multi-image co_broadcast of derived type with allocatable components fails^ Date: Tue, 25 Jan 2022 22:30:22 +0100 Message-ID: <3a178fe2-7e38-f4f5-9efd-b861f9740abd@gmx.de> References: <20220125173213.1265f8e3@vepi2> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Content-Language: en-US In-Reply-To: <20220125173213.1265f8e3@vepi2> Cc: gcc-patches@gcc.gnu.org X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Jan 2022 21:30:34 -0000 Message-ID: <20220125213022.kZMWTwPAsmZJ3hHC7giDS8Wa3EAOxsrdc6VrXyUjmiU@z> Hi Andre', Am 25.01.22 um 17:32 schrieb Andre Vehreschild via Fortran: > Hi all, > > attached patch fixes wrong code generation when broadcasting a derived type > containing allocatable and non-allocatable scalars. Furthermore does it prevent > broadcasting of coarray-tokens, which are always local this_image. Thus having > them on a different image makes no sense. > > Bootstrapped and regtested ok on x86_64-linux/F35. > > Ok, for trunk and backport to 12 and 11-branch after decent time? > > I perceived that 12 is closed for this kind of bugfix, therefore asking ok for > 13. I do not think that 12 is closed for bugfixing, especially not for fortran. And if my cursory reading of the patch is not misleading, the impact of the patch is really limited to coarrays. You may want to wait for another 1-2 days for additional comments. If not, it is OK from my side. Thanks for the patch! Harald > Regards, > Andre > -- > Andre Vehreschild * Email: vehre ad gmx dot de