From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.smtpout.orange.fr (smtp09.smtpout.orange.fr [80.12.242.131]) by sourceware.org (Postfix) with ESMTPS id 321EF3858D28 for ; Mon, 25 Apr 2022 13:29:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 321EF3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orange.fr Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orange.fr Received: from [192.168.1.17] ([86.253.179.215]) by smtp.orange.fr with ESMTPA id iymInEwv7KpuHiymIn6GHO; Mon, 25 Apr 2022 15:29:23 +0200 X-ME-Helo: [192.168.1.17] X-ME-Auth: MDU4MTIxYWM4YWI0ZGE4ZTUwZWZmNTExZmI2ZWZlMThkM2ZhYiE5OWRkOGM= X-ME-Date: Mon, 25 Apr 2022 15:29:23 +0200 X-ME-IP: 86.253.179.215 Message-ID: <3a25a2f6-cc9e-0b9b-7837-b3f01df19b95@orange.fr> Date: Mon, 25 Apr 2022 15:29:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: =?UTF-8?Q?Re=3a_=5bpushed=5d_testsuite=3a=c2=a0add_additional_optio?= =?UTF-8?Q?n_to_force_DSE_execution_=5bPR103662=5d?= Content-Language: en-US To: Jakub Jelinek Cc: gfortran , gcc-patches References: <8541b594-57c9-f6aa-7164-3918abe67a8f@orange.fr> <88c39110-ff0f-d06b-b331-133cb5213c67@gmx.de> <5d85fc5c-8e06-8568-43e5-6b9273f86a76@orange.fr> From: Mikael Morin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00, FREEMAIL_FROM, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=unavailable autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Apr 2022 13:29:25 -0000 Le 25/04/2022 à 14:12, Jakub Jelinek a écrit : > On Mon, Apr 25, 2022 at 01:38:25PM +0200, Mikael Morin wrote: >> I have just pushed the attached fix for two UNRESOLVED checks at -O0 that I >> hadn’t seen. > > I don't like forcing of DSE in -O0 compilation, wouldn't it be better > to just not check the dse dump at -O0 like in the following patch? > Certainly better. I actually looked for something alike already existing before trying to write a conditional in the dg-final code and finally deciding to go the easy way. > Even better would be to check that the z._data = stores are both present > in *.optimized dump, but that doesn't really work at -O2 or above because > we inline the functions and optimize it completely away (both the stores > and corresponding reads). > Yes, and global optimization is already checked by test execution anyway. > The first hunk is needed so that __OPTIMIZE__ effective target works in > Fortran testsuite, otherwise one gets a pedantic error and __OPTIMIZE__ > is considered not to match at all. > Maybe worth putting as code comment. OK from my side, thanks.