From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by sourceware.org (Postfix) with ESMTPS id 84E573858D39; Sat, 17 Feb 2024 15:05:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 84E573858D39 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 84E573858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=212.227.15.19 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708182322; cv=none; b=dIL8gCjOrTHZ/EwUWgpn+d8UqH8C2+O7+1Oe7rKF+0p21CWrj+QxWidPv8YWF3XaVPTK2MGuc8TkAoI4By1fof2L3MaWAZaZrr6sZX4RG1xJ+RYkyGteRjsmd4BDLTQ9XzSCjNqP4nD/y3Vj+YgAjFWtdhyDqAdpYeAcEdfVrJw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708182322; c=relaxed/simple; bh=xpBwQZbBR6/DG97RthQYtTsdLdRoq7o4KZo9oE/8tAQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=r9AvOAq70zLTBKfVPX2FB+Ufn43mV6iEjfB8zQyer5TApB+ea8+Jgd0SlgYBo7LYXNsMlYSauedY261Q/WAzt4bEHwhUjNitEKJahBcxlQLlOT+vgsu2+2D9Ql7lHKTWjNtVhhzHJpWx1zoyy9EzwjuaQPmWWMd8QXLvUVNUwTg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1708182318; x=1708787118; i=anlauf@gmx.de; bh=xpBwQZbBR6/DG97RthQYtTsdLdRoq7o4KZo9oE/8tAQ=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From: In-Reply-To; b=Zg6tIaGLY1NT9x/C/AvW9e3o0NnO/2E6CyPvUTNDCvKNtKYwz4EVWFZ88Ur2DFTt qbOvXmRRja/rbVKE5LRL+FPTD9YK2WtPIXW0b8YRi/n8NeTAx7M7I5FX5ukdDxKLY F/j7dsHG6rzfo2pKJEl2oM0/q7leQMOPubCdrl4yTX3fzPy7SohizQAigT298wDBc H3dXi/o3flBqnCEN31Zi+18aqL3kFxbn/7nt/ZuzKAxrvFqNKn+HM0GBajzjKTqwj 1++Wb5sHMaje68p6lcH6c954W8J3HNeEaUvqSQwf0v5fwtc+pT2pcgDYjkoUqJAAZ YGcOQtKmY697DL2A0w== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.178.29] ([79.251.4.42]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1McY8d-1r5anj0qVx-00cvXl; Sat, 17 Feb 2024 16:05:18 +0100 Message-ID: <3da43bd3-82c8-45c8-9f88-3be17ef1d36c@gmx.de> Date: Sat, 17 Feb 2024 16:05:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] fortran: gfc_trans_subcomponent_assign fixes [PR113503] To: Jakub Jelinek , fortran@gcc.gnu.org Cc: gcc-patches@gcc.gnu.org Newsgroups: gmane.comp.gcc.patches,gmane.comp.gcc.fortran References: Content-Language: en-US From: Harald Anlauf In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:ImijjXLZMUMqTQ5MC/6NVMyz/i3W1YRr3Avi83G4rx5J/dycxkr wcTyn2itVk3VtSF0volXpuCqEeuGjhpIELcE5ZIAFqOi235EnstjVYi5L7zSWpU2lpgs21l lZa3VqkC7KjBufzR2bjbLsuVrMoHwgyAUP9sMEaGkF8erdPXinzJEdG6PZKfqujmQOW/mK5 XO0Nt9fKOmjq1dKMrED1w== UI-OutboundReport: notjunk:1;M01:P0:FdjXN15htys=;zZl8h0QKngfK86L5tOlDKLALFbY 6D7VMenhzVFrkV49806KJ9LvPPbUxa3TrttE8D0sMAlK1imDBh6oW4KuGsztoTWFkLlrEhjEW IFS0lxFawvDGzt5+ZAJMbO5MnKbIXVIBt10E3YuGo9S4K/ukjkGHuaXJhKs3Jj/HhnPGUXmqE SpvTgk/22BdN4pG4eV0H81nB5xa8KRntvdQ9LNCUdiF4Vv2ptnqGiUekOzEHvSA7LWIDWWW4I rDdsjOIPnJcdgNaK31uiP5rFLge8TK6Hqjv8nsYogpNopKGN0OIfRkDzsbMjVpLkyN1mH/AtA RrLKnl0voNKUkpxXrq+/7Ky4bdm5veR0jin6FUAedkywxgXGXZHu8QshgA5aFfRw26Ylu+wT9 6lM7fJ/vRRqvW2+PcoGAoh5TVvuGGRZ579hhCcwir+G4iznU/l+fcDqslGr9ODYHxR9oBDSQJ 1sRdZWKxIy6XUeeZ4FMmLIQwAUGdFquWgPLrUO9DJsK/YY7I22twhJsY8jvZW+o6SJLMqOY5g x7Urq81kqT1txQ0m9kCRD4w6WrEYY2veLehjS6CRC4SwiYHraiZHwtJJARcUdxFil4zF6vQDy n5d3UcQtWSpPk0U9WYe0Gy3fPIpPbvxyVjneGvzrc1kMdHPWBTEDnPtbAG6JGYOGEmMBGgTyT jo69cov/Jc+wbxILsEnurLOeE1Gu5v9U+jKEHmcDoq/qvP4u8fjbhRJ+EhQ3uYK2fXf8fQyti +B4ZMohV/mHmiQphiULpXOsjCop5JvDZtGWUYyxifZTif7grnAKnqGGKj+c5u6Dd6rDOoFsTx NXvSogXMVcn74qf+IU53rsbP3dYi6BXZfevSypsPneMz0= X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jakub, On 2/17/24 10:02, Jakub Jelinek wrote: > Hi! > > The r14-870 changes broke xtb package tests (reduced testcase is the fir= st > one below) and caused ICEs on a test derived from that (the second one). [...] thanks for your detailed analysis and for the patch, which puts things in straight order to actually fix two issues here! > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? OK for trunk, except for the minor nit below. > --- gcc/testsuite/gfortran.dg/pr113503_1.f90.jj 2024-02-16 14:16:17.9371= 53094 +0100 > +++ gcc/testsuite/gfortran.dg/pr113503_1.f90 2024-02-16 14:16:10.1242588= 15 +0100 > @@ -0,0 +1,18 @@ > +! PR fortran/113503 > +! { dg-do compile } > +! { dg-options "-O2 -fno-inline -Wuninitialized" } > + > +program pr113503 > + implicit none > + type :: T > + character(len=3D:), allocatable :: u > + end type > + character(len=3D20) :: us(1) =3D 'foobar' > + type(T) :: x > + x =3D T(u =3D trim (us(1))) ! { dg-bogus "is used uninitialized" } ^^^^ tab here not allowed in Fortran My newsreader shows a tab here, giving a warning when running the test. Also, applying your patch on top of r14-9045 I do not see the uninitialized warning, which could have been fixed by r14-8947. Please recheck and adjust accordingly. > + call foo > +contains > + subroutine foo > + if (x%u /=3D 'foobar') stop 1 > + end subroutine > +end Thanks, Harald