From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=0j0f=4C=orange.fr=morin-mikael@sourceware.org>
Received: from smtp.smtpout.orange.fr (smtp-22.smtpout.orange.fr [80.12.242.22])
	by sourceware.org (Postfix) with ESMTPS id D84EC3851405
	for <fortran@gcc.gnu.org>; Sun,  4 Dec 2022 13:11:12 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D84EC3851405
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orange.fr
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=orange.fr
Received: from [192.168.1.17] ([2.10.193.163])
	by smtp.orange.fr with ESMTPA
	id 1olrpzxyzbw2u1olzpxQ5g; Sun, 04 Dec 2022 14:11:11 +0100
X-ME-Helo: [192.168.1.17]
X-ME-Auth: bW9yaW4tbWlrYWVsQG9yYW5nZS5mcg==
X-ME-Date: Sun, 04 Dec 2022 14:11:11 +0100
X-ME-IP: 2.10.193.163
Message-ID: <428cdc11-84c7-3837-e96f-9ec00c640643@orange.fr>
Date: Sun, 4 Dec 2022 14:11:03 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH] Fortran: error recovery simplifying UNPACK for
 insufficient FIELD [PR107922]
To: Harald Anlauf <anlauf@gmx.de>, fortran <fortran@gcc.gnu.org>,
 gcc-patches <gcc-patches@gcc.gnu.org>
References: <trinity-36a140f9-17a0-4d3d-8a78-f2ae946960cb-1669926330700@3c-app-gmx-bs60>
Content-Language: en-US
From: Mikael Morin <morin-mikael@orange.fr>
In-Reply-To: <trinity-36a140f9-17a0-4d3d-8a78-f2ae946960cb-1669926330700@3c-app-gmx-bs60>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <fortran.gcc.gnu.org>

Le 01/12/2022 à 21:25, Harald Anlauf via Fortran a écrit :
> Dear all,
> 
> we did not properly handle the case of insufficient array-valued
> FIELD when trying to simplify UNPACK and could run into a NULL
> pointer dereference.  The fix is obvious.
> 
> Regtested on x86_64-pc-linux-gnu.  OK for mainline?
> 
The change looks good, but please add braces around the new if-else 
structure.
OK with that change.
Thanks.