From: Mikael Morin <morin-mikael@orange.fr>
To: Harald Anlauf <anlauf@gmx.de>, fortran <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: *** SPAM *** [PATCH] PR fortran/104128 - ICE in gfc_widechar_to_char, at fortran/scanner.c:199
Date: Thu, 27 Jan 2022 12:58:54 +0100 [thread overview]
Message-ID: <43811c43-3fc8-322a-c3b9-41de41c8b859@orange.fr> (raw)
In-Reply-To: <trinity-6b057ca7-d643-409f-a2da-f6b8a0848211-1642972121019@3c-app-gmx-bs60>
Le 23/01/2022 à 22:08, Harald Anlauf via Fortran a écrit :
> Dear Fortranners,
>
> conversions between different character kinds using TRANSFER exhibit
> inconsistencies that can occur between expr->representation.string
> (which is char*) on the one hand, and expr->->value.character.string.
>
> One issue (in target-memory.cc) is easily fixed by simply passing
> a conversion flag that was likely forgotten in the past.
>
> The other issue happens in gfc_copy_expr. Before we unconditionally
> converted an existing representation.string to wide char, which is
> definitely wrong. Restricting that code path to default character
> kind fixed the problems I could find and produces dumps that looked
> fine to me. Maybe some expert here can find a better fix.
>
> Regtested on x86_64-pc-linux-gnu. OK for mainline?
This was submitted on time before stage4, so it seems to remain valid.
OK.
> Maybe 11-branch?
This is not a regression; I would rather not.
Thanks for the patch.
prev parent reply other threads:[~2022-01-27 11:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-23 21:08 Harald Anlauf
2022-01-27 11:58 ` Mikael Morin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43811c43-3fc8-322a-c3b9-41de41c8b859@orange.fr \
--to=morin-mikael@orange.fr \
--cc=anlauf@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).