From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 7DB393858D39 for ; Mon, 19 Jun 2023 21:34:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7DB393858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687210442; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PaALnMoRk3WcnhhwgrFsTgKnx8MxFF+fZyCHWPiehAU=; b=TkDxoVTCd7UOKZ+34x7DBj1eLUEllLK6benGknFSdRaM8B4dz3CUxs5COGXK2kizKHVlMb 1vcHBbrqTFamcaBPgzVtQZx+ccAEbY82yLWl9q/7j8RE5e5vJooCLlYabJBIcob1U0iYNK hfwGPnugPG/xtTD5hxY1cqVc8pp0qLk= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-657-UHDCjBz_MayjacUwjudjvg-1; Mon, 19 Jun 2023 17:34:00 -0400 X-MC-Unique: UHDCjBz_MayjacUwjudjvg-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-62ff96335b0so39776796d6.0 for ; Mon, 19 Jun 2023 14:34:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687210440; x=1689802440; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PaALnMoRk3WcnhhwgrFsTgKnx8MxFF+fZyCHWPiehAU=; b=kEadD01j0oQ/Ivhvx1fwwk7rKis7JISs/+vLKR5I+2Hjuq8D/adZFan406tDXRHWPU qJMco4lsM105mKV4/VujOgmXXGw0WD9Vuc03ebBiFhUmqKoVH4f4JC3XhLXIx7mUF0Kb zZB3BsMH9NY4kyViD2VsqkTKfxYqtxRxbaLfy5CoBLQNRVuujGWGHr6BL7/WB51K+Hv2 9GC30/t87hqgFJaqYqxl+kbMlZZ8pReH7aCgk8dgF7Ri7NaV8pM+cb/QT8ZgQkBTJlJn EhJaAalkWNncpJNA2BD1Z2CRP+HF+BMeabV3CFp2BQ5mgsh81TWUEEblD2d/w1LVfNOh SXkA== X-Gm-Message-State: AC+VfDxsOyqdk5q8tkFsUrvtKEeiJOJEH1VNcvXV12Ixqa+aLVt1I5AQ 2+7fuFlQUQ3GZhYKblrz6CuhlvrTDMUdgKx6paoJ+myNafCaLE9umoh6/a9X7hlva8HVzn7WnaJ WX69GVKqA+MTP X-Received: by 2002:a05:6214:f01:b0:62f:fc11:b714 with SMTP id gw1-20020a0562140f0100b0062ffc11b714mr12005401qvb.27.1687210439953; Mon, 19 Jun 2023 14:33:59 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4GO2JruwfUXqRDJa4CASBW7aoX8Rl0GdUewJE6yPe29/FCb4acCx3be+xV5zqGZhrAckwYHQ== X-Received: by 2002:a05:6214:f01:b0:62f:fc11:b714 with SMTP id gw1-20020a0562140f0100b0062ffc11b714mr12005389qvb.27.1687210439680; Mon, 19 Jun 2023 14:33:59 -0700 (PDT) Received: from [192.168.1.108] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id x5-20020a05620a14a500b00761f635fbf6sm383302qkj.8.2023.06.19.14.33.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jun 2023 14:33:59 -0700 (PDT) Message-ID: <44880095-f972-ca16-f75b-2c64940e0433@redhat.com> Date: Mon, 19 Jun 2023 17:33:58 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v5 3/5] p1689r5: initial support To: Ben Boeckel Cc: gcc-patches@gcc.gnu.org, nathan@acm.org, fortran@gcc.gnu.org, gcc@gcc.gnu.org, brad.king@kitware.com References: <20230125210636.2960049-1-ben.boeckel@kitware.com> <20230125210636.2960049-4-ben.boeckel@kitware.com> <77ee5db6-e45e-5178-4807-5b2fef29e8c7@redhat.com> From: Jason Merrill In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/12/23 10:24, Ben Boeckel wrote: > On Tue, Feb 14, 2023 at 16:50:27 -0500, Jason Merrill wrote: >> I notice that the actual flags are all -fdep-*, though some of them are >> -fdeps-* here, and the internal variables all seem to be fdeps_*. I >> lean toward harmonizing on "deps", I think. > > Done. > >> I don't love the three separate options, but I suppose it's fine. I'd >> prefer "target" instead of "output". > > Done. > >> It should be possible to omit both -file and -target and get reasonable >> defaults, like the ones for -MD/-MQ in gcc.cc:cpp_unique_options. > > `file` can be omitted (the `output_stream` will be used then). I *think* > I see that adding: > > %{fdeps_file:-fdeps-file=%{!o:%b.ddi}%{o*:%.ddi%*}} %{!fdeps-file: but yes. > would at least do for `-fdeps-file` defaults? I don't know if there's a > reasonable default for `-fdeps-target=` though given that this command > line has no information about the object file that will be used (`-o` is > used for preprocessor output since we're leaning on `-E` here). I would think it could default to %b.o? I had quite a few more comments on the v5 patch that you didn't respond to here or address in the v6 patch; did your mail client hide them from you? Jason