From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 59E4E3858413; Sat, 2 Apr 2022 12:42:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 59E4E3858413 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.90,230,1643702400"; d="scan'208";a="73765136" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa3.mentor.iphmx.com with ESMTP; 02 Apr 2022 04:42:32 -0800 IronPort-SDR: hD4ANSy2VZhqrb4sKPNxWo4pFrGRW2Ka19qRM2J3tk/K3c7D4L75yNX2smZUbVijM1K9UBhSYj T3NWBMGprTy4sKr0jBEFW3aqo44+6azeKUFgl0UTR5kxai/phT/IPVjGrZzt9fHvIlM+ldiNOG cuV9TZYLYfIOcIXuK/S/t9mMmeOkdBQAJTR02Kxg1+Qe1IFNFcRHmeUKFw1yVP1YuSd6P8uLm/ SzeXz/EmOVP1yuTGeW5WbGJyYN0B8UWqmSftPfh04QiouGTZiQ4mNANUgLlX8gIVZXRFwRGFFX phY= Message-ID: <44ae4c92-ce1a-f160-8bb6-713e5686ea70@codesourcery.com> Date: Sat, 2 Apr 2022 13:42:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 4/5] openmp: Use libgomp memory allocation functions with unified shared memory. Content-Language: en-GB From: Andrew Stubbs To: Hafiz Abid Qadeer , , CC: , References: <20220308113059.688551-1-abidh@codesourcery.com> <20220308113059.688551-5-abidh@codesourcery.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-08.mgc.mentorg.com (139.181.222.8) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Apr 2022 12:42:33 -0000 On 02/04/2022 13:04, Andrew Stubbs wrote: > This additional patch adds transformation for omp_target_alloc. The > OpenMP 5.0 document says that addresses allocated this way needs to work > without is_device_ptr. The easiest way to make that work is to make them > USM addresses. Actually, reading on, it says "Every device address allocated through OpenMP device memory routines is a valid host pointer", so USM is the correct answer. Andrew