From: Janne Blomqvist <Janne.Blomqvist@tkk.fi>
To: Brooks Moses <brooks.moses@codesourcery.com>
Cc: fortran@gcc.gnu.org, patches@gcc.gnu.org
Subject: Re: [PATCH, fortran, committed]
Date: Fri, 03 Nov 2006 20:27:00 -0000 [thread overview]
Message-ID: <454BA632.6030708@tkk.fi> (raw)
In-Reply-To: <4.3.1.2.20061102210810.02a213d8@cits1.stanford.edu>
Brooks Moses wrote:
> Approved by Steve Kargl in IRC, committed to trunk.
>
> This patch changes the "In file:" lines in GFortran error messages to a
> format which is in agreement with the GNU standards for such things, and
> changes the testsuite error-parsing functions to parse the new format,
> so that no regressions arise from the change.
>
> Many thanks to Steve and to Jerry DeLisle for regression testing the
> patch while my build machine was otherwise occupied. :)
>
> - Brooks
>
>
> -fortran/ChangeLog----------------------------------------------------
> 2006-11-02 Brooks Moses <brooks.moses@codesourcery.com>
>
> * error.c (show_locus): Remove "In file" from error messages.
>
> -testsuite/ChangeLog--------------------------------------------------
> 2006-11-02 Brooks Moses <brooks.moses@codesourcery.com>
>
> * lib/gfortran-dg.exp (gfortran-dg-test): Remove expected "In file"
> from error messages.
>
> ----------------------------------------------------------------------
Shouldn't there be a ":" at the end of the line as well? And the output
should start in column 2 and not 1? I.e.
foo.f:line:
instead of the current
foo.f:line
At least I need to add that to get emacs to jump to the error line.
--
Janne Blomqvist
next prev parent reply other threads:[~2006-11-03 20:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-03 5:14 Brooks Moses
2006-11-03 20:27 ` Janne Blomqvist [this message]
2006-11-03 21:13 ` Brooks Moses
2020-11-17 21:28 [Patch, Fortran, committed] Harald Anlauf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=454BA632.6030708@tkk.fi \
--to=janne.blomqvist@tkk.fi \
--cc=brooks.moses@codesourcery.com \
--cc=fortran@gcc.gnu.org \
--cc=patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).