Re: [PATCH, fortran, committed]

[Brooks Moses <brooks.moses@codesourcery.com>]

Janne Blomqvist wrote:
> Brooks Moses wrote:
>>-fortran/ChangeLog----------------------------------------------------
>>2006-11-02  Brooks Moses  <brooks.moses@codesourcery.com>
>>
>>    * error.c (show_locus): Remove "In file" from error messages.
>>
>>-testsuite/ChangeLog--------------------------------------------------
>>2006-11-02  Brooks Moses  <brooks.moses@codesourcery.com>
>>
>>    * lib/gfortran-dg.exp (gfortran-dg-test): Remove expected "In file"
>>    from error messages.
>>
>>----------------------------------------------------------------------
> 
> Shouldn't there be a ":" at the end of the line as well? And the output 
> should start in column 2 and not 1? I.e.
> foo.f:line:
> instead of the current
>   foo.f:line
> 
> At least I need to add that to get emacs to jump to the error line.

You could well be correct -- I don't use emacs, so I was merely using 
the changed message format that others had suggested.

I was about to say that this should be a simple patch very much along 
the lines of the previous one, but then I looked into it a little more, 
and realized that I have no idea where the space at the beginning of the 
line is coming from.  Does anyone know, offhand?

Thanks,
- Brooks


P.S. I inadvertantly cc'ed my initial post in this thread to 
patches@gcc.gnu.org, when the real address is gcc-patches@.  Apparently 
the patches@ address is a spamtrap and anyone who sends email there gets 
automatically blacklisted (Or, at least, that's what happened to me). 
My sincere apologies, and I've already emailed the GCC postmaster to 
request removal of any blocks against your name that came from this.