From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id E1989385B53B; Fri, 12 May 2023 20:36:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E1989385B53B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1ab125a198dso16543015ad.1; Fri, 12 May 2023 13:36:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683923818; x=1686515818; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=KJyangsAJFkED9IwqLtYmNg5oEg3udhDIx3svQ7Qbfk=; b=RIljh4guk17mVupcpiPMjHSRulLFKynp/HgCZKKY8phWm4eAgE+8F3wcK3bA7lRx+o AdbewC4OpNcW//igaaZYpGv9SqljDIDppxD2tiw23R1tvru95zzk4xTfENQDeTc6anzF IGSiYCP99q0Ddmsb2sbs0Qdz90k6MQzV94SgRt12JdrNWXLo/31edE1v8UcGEsP13bkn nigyvnxjTstO/qZgMocqv+89Xo11uCveznWOn77kA/onl+fVVxqyHO6yqp+FQqWWwaVe hs6x87u4hx+/E9lcscuk69kDO0KD6CgtAmjqCRMbO6QuRRKm2I/E+C6oGlARLGM+6cQr Re2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683923818; x=1686515818; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=KJyangsAJFkED9IwqLtYmNg5oEg3udhDIx3svQ7Qbfk=; b=f4c2LV77foJmLArkpQ67OP3P6OSCNCCWJlWKHsJNnUxvLSgjAf2CO3sR4h18sp12SN baUNP8vDOq+WPzxl/TgoUYHTQcXq3dVJK2z8Bjc7RUeSDwRwrkO3o+BbEPi+ozZQVWu8 W9MRpCyus1FBTDkXo89snqLuzxYRHv10n5an8SJi/7e/WJULi/bhPxqLjXR0wdTDLwcs IYuQd4fg/NzRI0iCxwPadqrAHN0KEbw/dLquj0BCiNRgbPtM639Sjq82GHj7q0P3zhsr eXE901jZlnbI4piq16TCQNne67IlwsQSMOMAtoVJMKDM2XRXygn4UmZEU7msLzV8eTBd oOcA== X-Gm-Message-State: AC+VfDwy4Grg8dfg/LXDdz3gnCe+3T0W2qmkmVo0YQIMh9R6A8j7p0zs NJY3nXJ7//BedgMrSBPmwFw= X-Google-Smtp-Source: ACHHUZ4pBA5LJgYYId0Y4GC38DgTY6K0EDyjP8UrpJXvzrXOkF8seNohNay9EpmmBuEZMbUvx6BZeg== X-Received: by 2002:a17:902:e843:b0:1a9:6467:aa8d with SMTP id t3-20020a170902e84300b001a96467aa8dmr32761479plg.1.1683923817739; Fri, 12 May 2023 13:36:57 -0700 (PDT) Received: from [192.168.1.20] ([50.37.188.226]) by smtp.gmail.com with ESMTPSA id f10-20020a170902ce8a00b001a221d14179sm8366192plg.302.2023.05.12.13.36.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 May 2023 13:36:57 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------jTAJUBwJ8whcm0WywJg73TdP" Message-ID: <47439763-d673-5ea0-545b-40dd1200d5dd@gmail.com> Date: Fri, 12 May 2023 13:36:56 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [patch, fortran] PR109662 Namelist input with comma after name accepted Content-Language: en-US To: Harald Anlauf , sgk@troutmask.apl.washington.edu Cc: gfortran , gcc-patches References: <508ee742-97fa-9f61-ab65-98d3fa8e7dca@gmx.de> <658d646d-d699-0d7c-06ce-396af393008f@gmx.de> <5b8f724b-1a65-279b-cdc3-85e658d6ab2c@gmx.de> From: Jerry D In-Reply-To: <5b8f724b-1a65-279b-cdc3-85e658d6ab2c@gmx.de> X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------jTAJUBwJ8whcm0WywJg73TdP Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit I plan to commit the following as simple. The issue was a value was being modified on a short namelist read. After tthe first read gives the correct EOF, a second read would give the error but modify the variable. diff --git a/libgfortran/io/unit.c b/libgfortran/io/unit.c index 82664dc5f98..36d025949c2 100644 --- a/libgfortran/io/unit.c +++ b/libgfortran/io/unit.c @@ -504,6 +504,7 @@ set_internal_unit (st_parameter_dt *dtp, gfc_unit *iunit, int kind) iunit->current_record=0; iunit->read_bad = 0; iunit->endfile = NO_ENDFILE; + iunit->last_char = 0; /* Set flags for the internal unit. */ The revised test case attached. It has been regression tested OK. Regards, Jerry --------------jTAJUBwJ8whcm0WywJg73TdP Content-Type: text/x-fortran; charset=UTF-8; name="pr109662-a.f90" Content-Disposition: attachment; filename="pr109662-a.f90" Content-Transfer-Encoding: base64 ISB7IGRnLWRvIHJ1biB9CiEgeyBkZy1vcHRpb25zICItc3RkPWYyMDAzIiB9CiEgUFIxMDk2 NjItYSBzZW1pLWNvbG9uIGFmdGVyIG5hbWVsaXN0IG5hbWUgYWNjZXB0ZWQgb24gaW5wdXQu IApwcm9ncmFtIHRlc3RubWxyZWFkCiAgaW1wbGljaXQgbm9uZQogIGNoYXJhY3RlcigxNikg OjogbGluZSA9ICcmc3R1ZmY7IG4gPSA3NTkvJwogIGNoYXJhY3RlcigxMDApOjptZXNzYWdl CiAgaW50ZWdlciAgICAgICA6OiBuLCBpLCBpb3Jlc3VsdAogIG5hbWVsaXN0L3N0dWZmL24K ICBtZXNzYWdlID0gIiIKICBpb3Jlc3VsdCA9IDAKICBuID0gOTkKICByZWFkKGxpbmUsbm1s PXN0dWZmLGlvc3RhdD1pb3Jlc3VsdCkKICBpZiAoaW9yZXN1bHQgPT0gMCkgU1RPUCAxMyAh IFNob3VsZCBlcnJvciB3aXRoIHRoZSBzZW1pLWNvbG9uIGluIHRoZXJlLgoKICAhIEludGVu dGlvbmFsIHNob3J0IGlucHV0ICgtPiBFT0YpCiAgbGluZSA9ICImc3R1ZmYiCiAgISBQcm9i bGVtIG1hbmlmZXN0cyBvbiB0d28gYmFkIHJlYWRzIG9uIHNhbWUgc3RyaW5nLgogIGRvIGkg PSAxLCA2CiAgICBuID0gLTEKICAgIGlvcmVzdWx0ID0gMAoKICAgIHJlYWQgKGxpbmUsbm1s PXN0dWZmLGlvc3RhdD1pb3Jlc3VsdCkKICAgIGlmIChuIC89IC0xKSBTVE9QIDI0CiAgICBp ZiAoaW9yZXN1bHQgPT0gMCkgU1RPUCAyNQogIGVuZCBkbwoKZW5kIHByb2dyYW0gdGVzdG5t bHJlYWQK --------------jTAJUBwJ8whcm0WywJg73TdP--