From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cc-smtpout1.netcologne.de (cc-smtpout1.netcologne.de [89.1.8.211]) by sourceware.org (Postfix) with ESMTPS id 63AEA385771A; Wed, 10 May 2023 20:02:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 63AEA385771A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=netcologne.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=netcologne.de Received: from cc-smtpin2.netcologne.de (cc-smtpin2.netcologne.de [89.1.8.202]) by cc-smtpout1.netcologne.de (Postfix) with ESMTP id ECDD9127C8; Wed, 10 May 2023 22:02:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=netcologne.de; s=nc1116a; t=1683748941; bh=AXd4wDTZf6nuJIGOk9AZhoPTnQqZSecwLTwsizh2J2Y=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To:From; b=iH2Vs+S6ShqT/84XoGOCMlCyMdHwAP1Sy6zJsW1YqTNszpJ6IOUOJMWjpqX+y0qez 9pU6u+f6lkxK0taJgIjR1g91wRaTbT3WhsUjP551MEdKfLGAy0UUZi2LOBHVXVp7tI 50GY91/BkCDUB5OPlfLYF3qWu+qfUDLsdRcMGX9noXQ1bnzvv8pa1MFWmYgiKqYutN z3kENc/sVs0hQZV4KsiauiRqf/RVLEihoHSQT9B1PmEnT521rmipbxD+QkU2MsSqpJ ZDUp2pUo/MbC32RaMH6uvpAjxMW0dkbuXXcLHUFKqhMhChtpxQQ+0tG3jA0y55HbGS boDmTCdLT9FRA== Received: from [IPV6:2001:4dd6:3fec:0:7285:c2ff:fe6c:992d] (2001-4dd6-3fec-0-7285-c2ff-fe6c-992d.ipv6dyn.netcologne.de [IPv6:2001:4dd6:3fec:0:7285:c2ff:fe6c:992d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by cc-smtpin2.netcologne.de (Postfix) with ESMTPSA id 4CB2211FA1; Wed, 10 May 2023 22:02:15 +0200 (CEST) Message-ID: <48620eb1-699b-5d34-2c72-356f8f059b04@netcologne.de> Date: Wed, 10 May 2023 22:02:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 4/7] fortran: use grep instead of fgrep To: Bernhard Reutner-Fischer , Xi Ruoyao Cc: gcc-patches@gcc.gnu.org, Rainer Orth , Arnaud Charlet , Jonathan Wakely , fortran@gcc.gnu.org References: <1e2be9a04a91bd061892353b578261666a1c9b75.camel@xry111.site> <20230510212925.23e2837b@nbbrfq> Content-Language: en-US From: Thomas Koenig In-Reply-To: <20230510212925.23e2837b@nbbrfq> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-NetCologne-Spam: L X-Rspamd-Queue-Id: 4CB2211FA1 X-Spamd-Bar: / X-Rspamd-Action: no action X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10.05.23 21:29, Bernhard Reutner-Fischer via Fortran wrote: > On Mon, 27 Jun 2022 14:10:36 +0800 > Xi Ruoyao wrote: > >> fgrep has been deprecated in favor of grep -F for a long time, and the >> next grep release (3.8 or 4.0) will print a warning of fgrep is used. >> Stop using fgrep so we won't see the warning. >> >> We can't hard code grep -F here or it may break build on hosts w/o GNU >> grep. autoconf documentation contains a warning about this issue and >> suggest to use AC_PROG_FGREP and $FGREP, but these are too overkill in >> the specific case: there is no way "debian" could be interpreted as an >> non-trivial regex, so we can use a plain grep here. > > LGTM but i cannot approve it. I'd say this one is trivial and obvious > so you could sneak it in under the "obvious" rule.. I concur, this could also have been obvious. Anyway, OK for trunk, and > Thanks for the patch!