public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: FX <fxcoudert@gmail.com>
To: Thomas Koenig <tkoenig@netcologne.de>
Cc: FX via Fortran <fortran@gcc.gnu.org>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fortran: Add IEEE_SIGNBIT and IEEE_FMA functions
Date: Fri, 9 Sep 2022 19:50:47 +0200	[thread overview]
Message-ID: <4A798A7C-1D75-41D2-8E09-192BDA810738@gmail.com> (raw)
In-Reply-To: <5CFF18E6-7A7D-4042-A6E4-F170633CFA8F@gmail.com>

Hi Thomas,

>> Both of these functions are new with Fortran 2018, could you add
>> a standards version check?
> 
> Thanks Thomas, I will do that and post here the commit diff. The check will not be perfect, though, because the warning/error cannot be emitted when loading the module (because it’s in an external file), but will have to be when the call is actually emitted.

Actuelly, that does not work. gfc_notify_std() should not be used at code-generation time, but in matching or setting-up symbols. It is never used in trans-* files, so I do not think I should introduce it now.

Any hard objection to committing as it is? In the middle term, I intend to revamp this part anyway, as I said in my previous email.

Thanks,
FX

  reply	other threads:[~2022-09-09 17:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-31 13:46 FX
2022-08-31 14:22 ` FX
2022-09-06 13:26   ` FX
2022-09-07  5:43     ` Thomas Koenig
2022-09-07 18:57       ` FX
2022-09-09 17:50         ` FX [this message]
2022-09-10 10:14           ` FX
2022-09-11  9:49             ` Mikael Morin
2022-09-11  9:57               ` FX
2022-09-11 10:23                 ` Mikael Morin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A798A7C-1D75-41D2-8E09-192BDA810738@gmail.com \
    --to=fxcoudert@gmail.com \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=tkoenig@netcologne.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).