From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by sourceware.org (Postfix) with ESMTPS id 1AEDC3858C2F; Mon, 15 Aug 2022 20:00:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1AEDC3858C2F Received: by mail-wr1-x433.google.com with SMTP id l4so10196254wrm.13; Mon, 15 Aug 2022 13:00:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc; bh=xCq/PmcQybPx3gAh9IJCM+fLXdKuj0LNSb+QB1PFMWs=; b=oDTQhg3zvAEnpW1LiWS4hHzlvMxIxf61DS6l9JI31yHN9T3jp4v0WUCZkEmEnwVRST EbVjbDe07kQICtBPtkMd7IccUcNb11EAbJC+6K6z/FoNotLLWvKWSgLB30Z0Yy/N2jK3 /nr2Z+5ISkRRoFv8+hzmAXNJ5xBJqmu9rIoZ3HXIwQz0PHRRDgEhMVP2GW/N39D8ixvl 12gSTQ4d4U+oGQ94FgYagQ/UeyBlMee00/Hi7i3mkBdAEgnyycxMILuV9RSJLqZK8Wui jjZA/pfSQYM3+71nXEQ7NweY0FIHdJeBqoyPmfOQUe4RiSzHTZ/BgJV/03PJBOLAMiJv Ef0A== X-Gm-Message-State: ACgBeo0fFLgE8xRuvyeQBYDRhuIx02tCSODtBJlIWZUZsFAU+9+5CPmd pa68Gcj+zLETihUfBkbiNUs= X-Google-Smtp-Source: AA6agR4JNjbFmUXc0huh5X1BT1A9zM6MRznw5PHJuiLUdwSUHZ/sdLIIzGYhqI1KZM2e5cESt6BTWg== X-Received: by 2002:a05:6000:8c:b0:220:5a9b:577f with SMTP id m12-20020a056000008c00b002205a9b577fmr9301819wrx.81.1660593603901; Mon, 15 Aug 2022 13:00:03 -0700 (PDT) Received: from smtpclient.apple (lfbn-ren-1-637-46.w81-53.abo.wanadoo.fr. [81.53.21.46]) by smtp.gmail.com with ESMTPSA id bn27-20020a056000061b00b0021e47fb24a2sm8229158wrb.19.2022.08.15.13.00.03 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Aug 2022 13:00:03 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: [PATCH] fortran: Expand ieee_arithmetic module's ieee_value inline [PR106579] From: FX In-Reply-To: Date: Mon, 15 Aug 2022 22:00:02 +0200 Cc: gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org Content-Transfer-Encoding: quoted-printable Message-Id: <4B7DE3A3-8F13-49D1-BCA9-723360EC386A@gmail.com> References: To: Jakub Jelinek X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Aug 2022 20:00:07 -0000 Hi Jakub, I have two questions, on this and the ieee_class patch: > + tree type =3D TREE_TYPE (arg); > + gcc_assert (TREE_CODE (type) =3D=3D RECORD_TYPE); > + tree field =3D NULL_TREE; > + for (tree f =3D TYPE_FIELDS (type); f !=3D NULL_TREE; f =3D = DECL_CHAIN (f)) > + if (TREE_CODE (f) =3D=3D FIELD_DECL) > + { > + gcc_assert (field =3D=3D NULL_TREE); > + field =3D f; > + } > + gcc_assert (field); Why looping over fields? The class type is a simple type with only one = member (and it should be an integer, we can assert that). > + case IEEE_POSITIVE_ZERO: > + /* Make this also the default: label. */ > + label =3D gfc_build_label_decl (NULL_TREE); > + tmp =3D build_case_label (NULL_TREE, NULL_TREE, label); > + gfc_add_expr_to_block (&body, tmp); > + real_from_integer (&real, TYPE_MODE (type), 0, SIGNED); > + break; Do we need a default label? It=E2=80=99s not like this is a more likely = case than anything else=E2=80=A6 Thanks, FX=