From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22407 invoked by alias); 7 Nov 2010 12:11:54 -0000 Received: (qmail 22384 invoked by uid 22791); 7 Nov 2010 12:11:53 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=AWL,BAYES_40,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.physik.uni-muenchen.de (HELO mail.physik.uni-muenchen.de) (192.54.42.129) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 07 Nov 2010 12:11:46 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.physik.uni-muenchen.de (Postfix) with ESMTP id 880D328050; Sun, 7 Nov 2010 13:11:43 +0100 (CET) Received: from mail.physik.uni-muenchen.de ([127.0.0.1]) by localhost (mail.physik.uni-muenchen.de [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 3Xda23A2-ksw; Sun, 7 Nov 2010 13:11:43 +0100 (CET) Received: from tobias-schluters-computer.local (e181035253.adsl.alicedsl.de [85.181.35.253]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.physik.uni-muenchen.de (Postfix) with ESMTP id 031942804B; Sun, 7 Nov 2010 13:11:42 +0100 (CET) Message-ID: <4CD6977B.6010002@physik.uni-muenchen.de> Date: Sun, 07 Nov 2010 12:11:00 -0000 From: =?ISO-8859-1?Q?Tobias_Schl=FCter?= User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.12) Gecko/20101027 Thunderbird/3.1.6 MIME-Version: 1.0 To: Janus Weil CC: Tobias Burnus , Dominique Dhumieres , fortran , gcc-patches , tkoenig Subject: Re: [Patch, Fortran, OOP] PR 46313: OOP-ABI issue, ALLOCATE issue, CLASS renaming issue References: <20101106233415.7DA533BE18@mailhost.lps.ens.fr> <4CD65B85.8030903@net-b.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org X-SW-Source: 2010-11/txt/msg00119.txt.bz2 On 2010-11-07 13:04, Janus Weil wrote: >>> Yes, that is expected, because the patch changes the name of the vtab >>> to "vtab$main$dt", so one needs to change the name of the subroutine >>> in the test case in the same way in order to see the failure: >> >> Dot? vtab.main.dt? > > Yes, we once had this variant. I think the reason why I switched to > dollars was that it made the dumps easier to read (think > "vtab.main.dt..extends..size" etc). Sorry I'm late, but gcc has the macro ASM_FORMAT_PRIVATE_NAME which does the work of making a name collision-free. If you use it you can make the rest of the name as readable as you want. Cheers, - Tobi > > The best option I can currently see is to use leading underscores (as > in "_vtab_main_dt"). This is forbidden in Fortran (cf. F08:R303), but > accepted by the assembler (cf. > http://sourceware.org/binutils/docs-2.20/as/Symbol-Names.html#Symbol-Names). > > Attached is a patch which does this change. I also added a few macros > in gfortran.h. Ok for trunk after successful regtest? > > Cheers, > Janus